Repository navigation
Close remaining dev gaps: stale project heartbeats, GCC worker C compiler, search-jump test, formatting - #1622
Merged
Merged
Conversation
Both commits left whole-file clang-format 22.1.2 differences in four files, so scripts/check_clang_format.py fails any later change that touches them. Formatting only.
The worker's heartbeat thread builds its message under the state lock and sends it afterwards, so a heartbeat built just before a reply that opens another project can arrive after that reply. Its background state is the previous project's: its discovery completion released #1612's large-image replica gate early, and its function count and generation briefly replaced the new project's. Apply only heartbeats for the project the session's replies established.
082b2e3 switched the worker tests that compile the engine's C to Clang when the SDK is built by cl.exe. GCC's C front end lacks the same Clang builtins (__builtin_bit_cast), so a GUI-project build with GCC still failed NeverDWorkerCallSiteTypes on a floating-point variadic argument. Prefer an installed Clang there as well, and keep GCC only when there is none.
c96ff8d starts a search after a pending jump settles, so that the landing no longer drops the reply as belonging to a moved cursor. searchResultsClearOnFailureCloseAndProjectSwitch reached that only through timing. Navigate and press Next before the listing answers: the listing replies first, so this fails deterministically when the search starts from the cursor the jump is leaving.
gmh5225
force-pushed
the
claude/dev-ci-gaps
branch
from
October 21, 2026 14:03
19472cf to
643af8c
Compare
Contributor
Author
|
Local verification on 643af8c (Linux x64, Release; engine with clang 23, GUI project with GCC 15 and Qt 6.8.3):
Merged on local verification at the maintainer's request, without waiting for the hosted checks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #1618: what still fails or drifts on dev after #1610-#1614 and #1604. This branch was rebuilt on dev after #1604 merged. #1604 independently fixed the stale HLT test, the Make array/alignment icons, the call-type menu entries, the search during a pending jump and the MSVC worker compiler, so my versions of those were dropped.
discovery_completereleased Reuse analysis replicas for bounded source preparation #1612's large-image replica gate early, and its function count and generation briefly replaced the new project's. Heartbeats now apply only when theirproject_idis the one the session's replies established. That interleaving cannot be produced deterministically through the fixture worker, so it has no dedicated test; the normal path is covered by the GUI suite, which depends on heartbeat updates throughout.__builtin_bit_cast), so a GUI-project build with GCC still failedNeverDWorkerCallSiteTypeson a floating-point variadic argument. GCC builds now prefer an installed Clang too, keeping GCC only when there is none.searchResultsClearOnFailureCloseAndProjectSwitchreached that only through timing.searchDuringAJumpStartsWhereTheJumpLandsnavigates and presses Next before the listing answers. The listing replies first, so the test fails deterministically when the search starts from the cursor the jump is leaving (it failed twice that way before the fix).scripts/check_clang_format.pyfor any later change that touches them. Formatting only.warm:trueopen no longer mirrors the workbench, which Reuse analysis replicas for bounded source preparation #1612 stopped warming. The comment now gives the server's own reason, which 0a2b35d measured.Local verification (Linux x64, Release) on this branch: see the comment below. The PR stays open until its Linux, Windows and macOS checks finish.