Repository navigation
Fix portable SEH fixtures and remaining GUI CI failures - #1623
Merged
Merged
Conversation
…nish-performance-validation
…nish-performance-validation # Conflicts: # unittests/emulation/fixtures/driver_seh_v2.S
…ce-followup # Conflicts: # tools/neverd-mcp/CMakeLists.txt
NeverSightAI
marked this pull request as ready for review
October 21, 2026 14:14
…ce-followup # Conflicts: # tools/neverd-worker/tests/source_variable_types_test.py # unittests/SessionCAPITests.cpp
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clang 18 and Apple Clang cannot assemble the newer V2 SEH fixture directives. Encode the same unwind records explicitly, preserving the trailing-marker case. Both Clang 18 and 23 produce a byte-identical complete PE to the original Clang 23 fixture.
Keep a context menu's invoking view as its command target while the popup owns focus, so Copy preserves the pseudocode selection. Use Qt's native Tab spelling in the menu assertion. Fill the startup file dialog's name editor directly, bound modal test automation with diagnostic deadlines, and retain bounded macOS controller logs/XML alongside the Windows diagnostics.
Local Release validation:
8b663a7a4efe9f17b69636deb69adcbdc71a17870654d95d16413b818524306bmatches all three producers.Commands:
build-prof/bin/NeverDLiftTests,build-prof/bin/NeverDSessionCAPITests,ctest --test-dir build-prof --output-on-failure -R 'NeverDWorker|NeverDAllocator|^NeverDMCP', andQT_QPA_PLATFORM=offscreen ctest --test-dir build-gui-finish --parallel 1 --output-on-failure. Lift used the installed Swift 6.4.1 toolchain and AArch64 parity fixture; Session used the existing optional kernel inputs.Windows clang-cl passed on
3afaae871: all three critical owners and 10 integration targets pass with TBB enabled and disabled, without skips. The maintainer accepts local verification for delivery; remaining CI is not a merge gate. Darwin-native execution remains unverified locally.