Shared UI fixes and short toasts - #144
Closed
HarryRandall wants to merge 5 commits into
Closed
HarryRandall wants to merge 5 commits into
HarryRandall wants to merge 5 commits into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This was referenced Sep 26, 2026
HarryRandall
changed the title
2 tasks
Owner
Author
|
Replaced by #150 (same commits, branch renamed to Generated by Claude Code |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by haz · project thread
Summary
First of six PRs that split
feat/requirement-placementsby feature: #144 → #145 → #146 → #147 → #148 → #149. Each builds on the one before, so merge with merge commits, not squash.Before: toasts were long and inconsistent, breadcrumbs showed years, empty states stopped short of the page bottom, search boxes could drift from the URL while typing, and admin search needed an exact phrase.
After: every toast is a short title with at most two lines of detail through a shared
showToast, long admin tasks show a progress bar that fills before completing, breadcrumbs show the parent page, empty states stretch to the bottom, search boxes stay in sync, admin search matches every word, and a few layout fixes land (course search drops its Requisites column, option picker lists scroll in dialogs, collapsed sidebar padding, dashboard width, tuition bars).How: five commits (toasts, breadcrumbs, empty states, search, layout fixes). Toast call sites in files that later PRs rewrite arrive with those PRs.
Verification
pnpm format:check,pnpm check:repository, ESLint,tscand unit tests pass; CI greenDeployment notes
None.