Repository navigation
[CP Staging] Revert "Confirm new expenses with a “View” toast instead of scrolling to and highlighting the row" - #99277
Conversation
… to and highlighting the row"
🦜 Polyglot Parrot! 🦜Squawk! Looks like you added some shiny new English strings. Allow me to parrot them back to you in other tongues: View the translation diffdiff --git a/src/languages/el.ts b/src/languages/el.ts
index e2c13634..d4091d95 100644
--- a/src/languages/el.ts
+++ b/src/languages/el.ts
@@ -1258,7 +1258,6 @@ const translations: TranslationDeepObject<typeof en> = {
if (count === 0) {
return duplicates > 0 ? 'Δεν προστέθηκαν κανόνες εμπόρων, καθώς υπάρχουν ήδη όλοι.' : 'Δεν έχουν προστεθεί κανόνες εμπόρου.';
}
-
return {
one: 'Προστέθηκε 1 κανόνας εμπόρου.',
other: `Έχουν προστεθεί ${count} κανόνες εμπόρων.`,
diff --git a/src/languages/es.ts b/src/languages/es.ts
index 5e635d42..3288b80c 100644
--- a/src/languages/es.ts
+++ b/src/languages/es.ts
@@ -1182,7 +1182,6 @@ const translations: TranslationDeepObject<typeof en> = {
if (count === 0) {
return duplicates > 0 ? 'No se han añadido reglas de comerciante, ya que todas ya existen.' : 'No se han añadido reglas de comerciante.';
}
-
return {
one: 'Se ha añadido 1 regla de comerciante.',
other: `Se han añadido ${count} reglas de comerciante.`,
diff --git a/src/languages/ja.ts b/src/languages/ja.ts
index f85b3cb1..68401cfd 100644
--- a/src/languages/ja.ts
+++ b/src/languages/ja.ts
@@ -9004,9 +9004,6 @@ ${reportName}`,
reject: '却下',
duplicateExpense: () => ({
one: '経費を複製',
- // Japanese has no grammatical plural, so `Intl.PluralRules` selects `other` for every count,
- // including 1. The single/bulk distinction here is semantic rather than grammatical, so `other`
- // branches on the count itself to keep 一括 (bulk) on the multi-expense action only.
other: (count: number) => (count === 1 ? '経費を複製' : '経費を一括複製'),
}),
noOptionsAvailable: '選択した経費グループには利用できるオプションがありません。',
Note You can apply these changes to your branch by copying the patch to your clipboard, then running |
|
@justinpersaud Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 47ece0230e
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| if (!ref || !triggeredByHookRef.current || !newSearchResultKey) { | ||
| return; |
There was a problem hiding this comment.
When Search is not already mounted—such as on wide layouts or the narrow-layout slow path—the create action queues a manual highlight before navigating, but triggeredByHookRef remains false because the hook did not observe the transaction being added. Although newSearchResultKeys is populated from the queued ID, this guard prevents scrolling, so an expense outside the visible viewport is never brought into view and its highlight is effectively invisible. Manual highlight keys should be permitted to drive the scroll independently of the auto-refetch trigger.
Useful? React with 👍 / 👎.
| if (!isFromGlobalCreate || isReportTopmostSplitNavigator() || !transactionID) { | ||
| return; |
There was a problem hiding this comment.
In the LOOKING_AROUND self-DM global-create flow, navigateAfterExpenseCreate() intentionally treats the user as not being on Inbox and sends them to Search, but this helper still returns whenever the Reports split navigator is topmost. That same context is excluded from Search pre-insertion, so Search mounts only after the transaction exists and cannot auto-detect the addition; without the manual flag, the newly created expense is not highlighted after navigation. This check needs to follow the same LOOKING_AROUND/self-DM exception as the navigation decision.
Useful? React with 👍 / 👎.
|
🚧 luacmartins has triggered a test Expensify/App build. You can view the workflow run here. |
…ense-added-growl [CP Staging] Revert "Confirm new expenses with a “View” toast instead of scrolling to and highlighting the row" (cherry picked from commit 493585a) (cherry-picked to staging by luacmartins)
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Cherry-picked to staging by https://github.com/luacmartins in version: 9.4.59-1 🚀
|
|
🤖 No help site changes required. This PR reverts #96496, restoring the previous behavior where a newly confirmed expense scrolls to and highlights its row instead of showing a View toast. That is an internal UI micro-interaction (toast/growl vs scroll-and-highlight) — it isn't described in any article under How I verified
Since no article describes this behavior, there's nothing to update and I did not create a draft PR. @mountiny, let me know if you expected an article to cover this confirmation behavior and I'll take another look. |
|
🚀 Deployed to production by https://github.com/AndrewGable in version: 9.4.59-5 🚀
Bundle Size Analysis (Sentry): |
|
🚀 Cherry-picked to staging by https://github.com/luacmartins in version: 9.4.60-0 🚀
|
|
🤖 I reviewed the changes and no help site changes are required under Why: This PR reverts #96496. That change had replaced the "scroll to and highlight the newly-added expense row" confirmation with a transient Expense added toast (the Both the toast and the restored scroll-and-highlight are transient UI feedback shown right after creating an expense — a momentary micro-interaction, not a documented feature. I searched |
|
🚀 Deployed to production by https://github.com/AndrewGable in version: 9.4.60-2 🚀
Bundle Size Analysis (Sentry): |
Reverts #96496
Fixed issues
$ #99264
$ #99262
$ #99261
$ #99258
$ #99257
$ #99255
$ #99253
$ #99252
$ #99249
$ #99248