feat: Enable Insights and comparisons on desktop web by luacmartins · Pull Request #104591 · Expensify/App

luacmartins · 2026-10-21T16:30:20Z

Explanation of Change

Enable Insights and its comparison controls by default on desktop web only. Mobile web, iOS and Android continue to require the existing insightsPage and insightsCompare betas, so desktop can launch without waiting for the native navigation fixes and app-store rollout.

Keep both betas off globally until the mobile rollout is ready. Local beta overrides still take precedence outside production.

Related native PRs: #104368 and https://github.com/Expensify/Mobile-Expensify/pull/14193.

Fixed Issues

N/A

Tests

Sign in on desktop web with an account that is not enrolled in insightsPage or insightsCompare and has no local beta overrides; confirm the Insights tab is visible.
Open the same account in mobile web and iOS and Android native apps; confirm Insights remains hidden and Account remains in the tab bar.

Offline tests

N/A

QA Steps

Same as tests

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

chatgpt-codex-connector · 2026-10-21T16:45:24Z

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	🔄 Running since 2026-10-21T16:45:21.053910Z	`8517d44`	Draft marked ready

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

melvin-bot · 2026-10-21T16:45:54Z

@mjasikowski Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

JS00001

lgtm, why do this in isBetaEnabled though, why not at the level where we check if the beta is enabled?

codecov · 2026-10-21T16:46:38Z

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
src/libs/Permissions.ts	`95.45% <50.00%> (-4.55%)`	⬇️
... and 51 files with indirect coverage changes

github-actions · 2026-10-21T17:21:08Z

🚧 luacmartins has triggered a test Expensify/App build. You can view the workflow run here.

feat: Enable Insights and comparisons on desktop web (cherry picked from commit 6b318fc) (cherry-picked to staging by luacmartins)

github-actions · 2026-10-21T17:26:16Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #104591.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-6b318fc-2e707d3-c7b37050f670f8bb0d765db7c47faac06851246e/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-6b318fc-2e707d3-a49f20f01c3b19da137ef85c6d9aebdac744ec97/index.html

Web 🕸️
https://104591.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-10-21T17:28:11Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2026-10-21T17:48:19Z

🚀 Cherry-picked to staging by https://github.com/luacmartins in version: 9.5.15-3 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

MelvinBot · 2026-10-21T17:58:03Z

Help site update needed. I opened a draft docs PR: Docs updates for E/A#104591 Point web Insights steps to new Insights tab

This PR gives every desktop web user the new Insights tab. It also removes the Insights section from Spend on web. That made these web steps wrong:

How to Use Insights in Expensify: "Click Spend in the navigation tabs … Scroll to Insights."
The Top spenders, Top merchants and Top categories articles: "select Spend, then click Top … under the Insights section."
Expensify Home Overview: View "takes you to that insight on the Spend page." On web, it now opens the Insights page.

Each fix is a one-sentence edit for web. Mobile steps are unchanged.

I didn't change the Violations by submitter article. On web it's no longer under Spend, and it isn't on the new Insights page either. I couldn't confirm the new web path, so please check that article.

@luacmartins, please review the linked help site PR and confirm it reflects the current behavior. Then mark the linked help site PR Ready for review

view run · no recording available

OSBotify · 2026-10-21T19:32:44Z

🚀 Deployed to production by https://github.com/grgia in version: 9.5.15-3 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android
iOS

OSBotify · 2026-10-21T20:09:36Z

🚀 Cherry-picked to staging by https://github.com/luacmartins in version: 9.5.16-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

MelvinBot · 2026-10-21T20:12:47Z

A help site update is needed, and the draft docs PR already exists: [No QA] Docs updates for E/A#104591 Point web Insights steps to new Insights tab. It's still open, labeled HelpDot, and assigned to luacmartins, so I didn't open a duplicate.

This PR's diff hasn't changed since I opened it. On desktop web, Insights now has its own Insights tab and is no longer under Spend. The docs PR updates the web steps that still said to select Spend and then Insights.

One open item: I didn't edit the Violations by submitter article. On web it's no longer under Spend, and I couldn't verify its new location.

@luacmartins, please review the linked help site PR and confirm it reflects the current behavior. Then mark the linked help site PR Ready for review

view run

OSBotify · 2026-10-22T19:23:44Z

🚀 Cherry-picked to staging by https://github.com/luacmartins in version: 9.5.18-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	cancelled 🔪

MelvinBot · 2026-10-22T19:34:59Z

A help site update is needed. I opened a draft PR: Docs updates for E/A#104591 Add Compare filter to How to Use Insights.

This PR turns on the insightsCompare beta for all desktop web users. That adds a Compare filter (Previous period / Average) to Insights. It makes this sentence in How to Use Insights wrong:

You can adjust the data shown across Insights using three shared filters:

The docs PR changes "three" to "these" and adds one Compare bullet marked web-only.

Why nothing else changes

The Insights tab itself is already documented as web-only in Navigating New Expensify and How to Use Insights. That already matches this PR.
Mobile web and native still need the beta, so the mobile instructions stay as they are.
I confirmed the Compare label and options in the live web UI.

@luacmartins, please review the linked help site PR and confirm it reflects the current behavior. Then mark the linked help site PR Ready for review

view run · view recording

OSBotify · 2026-10-23T16:54:53Z

🚀 Deployed to production by https://github.com/grgia in version: 9.5.18-1 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android
iOS

feat: Enable Insights on web ahead of native rollout

c17f3ed

luacmartins requested a review from a team October 21, 2026 16:30

feat: Include Insights comparison in web rollout

d5db705

melvin-bot Bot assigned luacmartins Oct 21, 2026

feat: Limit Insights rollout to desktop web

8517d44

luacmartins changed the title ~~feat: Enable Insights on web ahead of native rollout~~ feat: Enable Insights and comparisons on desktop web Oct 21, 2026

luacmartins mentioned this pull request Oct 21, 2026

Deploy Checklist: New Expensify 2026-10-20 #104495

Closed

81 tasks done

luacmartins marked this pull request as ready for review October 21, 2026 16:41

luacmartins requested a review from a team as a code owner October 21, 2026 16:41

melvin-bot Bot requested review from garrettmknight and removed request for a team October 21, 2026 16:41

melvin-bot Bot requested review from mjasikowski and removed request for a team October 21, 2026 16:45

JS00001 approved these changes Oct 21, 2026

View reviewed changes

luacmartins removed the request for review from mjasikowski October 21, 2026 16:50

luacmartins changed the title ~~feat: Enable Insights and comparisons on desktop web~~ [HOLD] feat: Enable Insights and comparisons on desktop web Oct 21, 2026

aldo-expensify approved these changes Oct 21, 2026

View reviewed changes

luacmartins changed the title ~~[HOLD] feat: Enable Insights and comparisons on desktop web~~ [HOLD product approval] feat: Enable Insights and comparisons on desktop web Oct 21, 2026

luacmartins mentioned this pull request Oct 21, 2026

[HOLD rollout] Remove Insights page and comparison beta gates #104595

Draft

36 tasks

luacmartins changed the title ~~[HOLD product approval] feat: Enable Insights and comparisons on desktop web~~ feat: Enable Insights and comparisons on desktop web Oct 21, 2026

luacmartins merged commit 6b318fc into main Oct 21, 2026
55 of 56 checks passed

luacmartins deleted the cmartins-insights-web-first branch October 21, 2026 17:20

OSBotify pushed a commit that referenced this pull request Oct 21, 2026

Merge pull request #104591 from Expensify/cmartins-insights-web-first

01bf54c

feat: Enable Insights and comparisons on desktop web (cherry picked from commit 6b318fc) (cherry-picked to staging by luacmartins)

OSBotify added the CP Staging marks PRs that have been CP'd to staging label Oct 21, 2026

MelvinBot mentioned this pull request Oct 21, 2026

[No QA] Docs updates for E/A#104591 Point web Insights steps to new Insights tab #104603

Closed

38 tasks

MelvinBot mentioned this pull request Oct 22, 2026

[No QA] Docs updates for E/A#104591 Add Compare filter to How to Use Insights #104796

Draft

38 tasks

Conversation

luacmartins commented Oct 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

chatgpt-codex-connector Bot commented Oct 21, 2026

Codex Review Summary

Uh oh!

melvin-bot Bot commented Oct 21, 2026

Uh oh!

JS00001 left a comment

Choose a reason for hiding this comment

Uh oh!

codecov Bot commented Oct 21, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

github-actions Bot commented Oct 21, 2026

Uh oh!

github-actions Bot commented Oct 21, 2026

Uh oh!

OSBotify commented Oct 21, 2026

Uh oh!

OSBotify commented Oct 21, 2026

Uh oh!

MelvinBot commented Oct 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

OSBotify commented Oct 21, 2026

Uh oh!

OSBotify commented Oct 21, 2026

Uh oh!

MelvinBot commented Oct 21, 2026

Uh oh!

OSBotify commented Oct 22, 2026

Uh oh!

MelvinBot commented Oct 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

OSBotify commented Oct 23, 2026

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

luacmartins commented Oct 21, 2026 •

edited

Loading

codecov Bot commented Oct 21, 2026 •

edited by github-actions Bot

Loading

MelvinBot commented Oct 21, 2026 •

edited

Loading

MelvinBot commented Oct 22, 2026 •

edited

Loading