Repository navigation
[No QA] Docs updates for E/A#104591 Add Compare filter to How to Use Insights - #104796
Conversation
Co-authored-by: Carlos Martins <luacmartins@users.noreply.github.com>
|
A preview of your ExpensifyHelp changes have been deployed to https://6eb69b9d.helpdot.pages.dev ⚡️ Updated articles: |
Product reviewer checklist:
For more detailed instructions on completing this checklist, see How do I review a HelpDot PR? |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
@trjExpensify Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
|
||
| You can adjust the data shown across **Insights** using three shared filters: | ||
| You can adjust the data shown across **Insights** using these shared filters: | ||
|
|
There was a problem hiding this comment.
Naming/consistency (minor): The other filter bullets follow a parallel "Choose..." structure (e.g. "Choose the period you want to analyze."). Per HELPSITE_NAMING_CONVENTIONS.md, use choose when a member decides between options. Consider rewording to match, e.g. "Compare: Choose Previous period or Average to compare spending. This filter is only available on web." This keeps the list parallel and uses the governance-preferred verb for selecting between options.
HelpDot Documentation ReviewOverall AssessmentThis PR makes a small, targeted copy update to How-to-Use-Insights.md to reflect the newly enabled insightsCompare beta on desktop web. It changes "three shared filters" to "these shared filters" (the count is now variable by platform) and adds a Compare bullet describing the new filter with its Previous period and Average options, noting the filter is web-only. The change is accurate, minimal, and consistent with the existing bulleted filter list. Scores Summary
Key Findings
Recommendations
Files Reviewed
Note: Detailed line-by-line feedback has been provided as inline comments. |
|
🚀 Deployed to staging by https://github.com/stephanieelliott in version: 9.5.24-1 🚀
|
Explanation of Change
Enable Insights on desktop web (
Expensify/App#104591) turns on theinsightsComparebeta for all desktop web users. That adds a Compare control to the Insights filter bar, with Previous period and Average options.This made a sentence in How to Use Insights incorrect:
Web users now see a fourth shared filter. This PR changes "three shared filters" to "these shared filters" and adds one Compare bullet. The bullet says the filter is only available on web, because mobile still requires the beta.
Labels were checked against
src/languages/en.tsand the live web UI.Fixed Issues
$ #104591
PROPOSAL:
Tests
// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review"
// Please describe what tests you performed that validates your changed worked.
Offline tests
QA Steps
// TODO: The human co-author must fill out the QA tests you ran before marking this PR as "ready for review".
// Please describe what QA needs to do to validate your changes and what areas do they need to test for regressions.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
UI verification by MelvinBot on desktop web:
@luacmartins, please review the files changed and confirm they reflect the current behavior. Then post a new comment saying
@MelvinBot mark this PR as ready for review.