[luacmartins]

Explanation of Change

Remove the insightsPage and insightsCompare gates and their disabled paths. Keep the current beta-on behavior for navigation, Home insights and comparisons on every platform.

Keep this PR in draft until both betas are enabled for everyone and the native fixes have fully rolled out. Backend beta definitions remain unchanged for older clients.

Also remove the temporary desktop-only permission override introduced in #104591, which is now on main.

Fixed Issues

$ #100658
$ #100665

Tests

1. Sign in on desktop web, mobile web, iOS and Android with an account outside both betas and a group workspace containing expenses; confirm Insights is visible and opens its dashboard.
2. Select each Compare option; confirm the charts and tables show comparison data without beta enrollment.
3. Change the date range and workspace filters, then reload the dashboard; confirm the selections persist and the matching data loads.
4. Open Home and use the Insights widget's View action; confirm it opens the Insights Spend dashboard.
5. Search for Insights in the Search Router; confirm the navigation suggestion opens the dashboard and Spend navigation does not duplicate Insights-only menu items.
6. On mobile web and native, open Account through the top-bar avatar and go back; confirm Account opens on the first tap and returns to the previous tab.
7. Replace the dashboard identifier in the Insights URL with an invalid value; confirm the not-found page still appears.
8. Check the JS console while navigating and comparing data; confirm no new errors appear.

Offline tests

1. Open Insights and load a dashboard, then disconnect the network.
2. Navigate to Home and back to Insights; confirm Insights remains available and shows cached data or its existing offline state instead of a beta-related not-found page.

QA Steps

1. Sign in on desktop web, mobile web, iOS and Android with a group workspace containing expenses and no Insights beta enrollment; confirm Insights and Compare are available.
2. Select each Compare option and change the date range and workspace filters; confirm the dashboard updates and preserves the selections after reload.
3. Open Insights from Home and the Search Router; confirm both paths reach the dashboard.
4. On mobile web and native, open Account through the top-bar avatar and go back; confirm navigation works and the bottom bar contains Home, Inbox, Spend, Insights and Workspaces.
5. Open an Insights URL with an invalid dashboard identifier; confirm the not-found page still appears.
6. Check the JS console while opening Insights and comparing data; confirm no new errors appear.

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I verified any copy / text that was added to the app is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• If new assets were added or existing ones were modified, I verified that:
  • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
  • The assets load correctly across all supported platforms.
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• If the PR adds or modifies the UI:
  • I asked an AI agent to review the changes for accessibility issues and addressed its findings.
  • I tested with a screen reader (VoiceOver on macOS) and verified all new/changed elements are reachable with a logical focus order.
  • I verified all new/changed elements have meaningful accessible names and roles.
  • I verified state changes are announced (e.g. checked/unchecked, expanded/collapsed, selected).
• I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

[codecov]

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
src/CONST/index.ts	95.90% <ø> (ø)
src/components/Navigation/AccountAvatarButton.tsx	86.95% <100.00%> (-4.72%)	⬇️
...s/Search/SearchRouter/useNavigationSuggestions.tsx	93.20% <100.00%> (-0.20%)	⬇️
...c/hooks/useIsSettingsDrawnOverTabs/index.native.ts	100.00% <100.00%> (ø)
src/hooks/useSearchTypeMenuSections.ts	100.00% <ø> (+2.50%)	⬆️
...gators/NativeTabNavigator/useNativeTabNavigator.ts	100.00% <100.00%> (ø)
src/libs/Permissions.ts	100.00% <ø> (+4.54%)	⬆️
src/libs/SearchUIUtils.ts	73.74% <ø> (ø)
src/pages/Insights/InsightsDashboard.tsx	82.55% <100.00%> (-0.40%)	⬇️
src/pages/Insights/InsightsPage.tsx	85.71% <100.00%> (-1.79%)	⬇️
... and 7 more
... and 13 files with indirect coverage changes