Skip to content

[No QA] Docs updates for E/A#104591 Point web Insights steps to new Insights tab - #104603

Closed
MelvinBot wants to merge 1 commit into
mainfrom
claude-docsInsightsTabDesktopWeb
Closed

MelvinBot wants to merge 1 commit into
mainfrom
claude-docsInsightsTabDesktopWeb

Conversation

@MelvinBot

Copy link
Copy Markdown
Contributor

Explanation of Change

feat: Enable Insights and comparisons on desktop web turns on the insightsPage and insightsCompare betas for everyone on desktop web. On desktop web, Insights now has its own Insights tab in the navigation tabs, and the Insights section (Spend over time, Top spenders, Top categories, Top merchants, Violations by submitter) no longer appears under Spend. Mobile is unchanged.

These article sentences were incorrect on web:

  • How-to-Use-Insights-in-Expensify.md: "Click Spend in the navigation tabs (on the left on web, or on the bottom on mobile). Scroll to Insights." → Split into web (select Insights) and mobile (unchanged) steps.
  • View-the-Top-Spenders-report.md: "Use the navigation tabs on the left and select Spend, then click Top spenders under the Insights section." → Select Insights; Top spenders appears as a chart on the Insights page.
  • View-the-Top-Merchants-report.md: "Click Spend in the left navigation, then click Top merchants under the Insights section" → same fix.
  • View-the-Top-Categories-report.md: "Click Spend in the left navigation, then click Top categories under the Insights section" → same fix.
  • Expensify-Home-Overview.md: "The available insights match the ones you can open under Spend" and "This takes you to that insight on the Spend page." → On web, View now opens the Insights page.

Not changed: View-the-Violations-by-submitter-report.md web steps ("select Spend. Under Insights, select Violations by submitter") are also out of date on web, but Violations by submitter isn't on the new Insights page, and I couldn't verify a replacement web path. Please confirm where it lives now.

Verified on desktop web: navigation tabs are Home, Inbox, Spend, Insights, Workspaces, Account, and the Spend menu shows only Expense reports, Accounting, and Saved.

Desktop web: Insights tab in navigation tabs; Spend menu has no Insights section

Desktop web: Insights page

Fixed Issues

$ #104591
PROPOSAL:

Tests

// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review"
// Please describe what tests you performed that validates your changed worked.

  • Verify that no errors appear in the JS console

Offline tests

QA Steps

// TODO: The human co-author must fill out the QA tests you ran before marking this PR as "ready for review".
// Please describe what QA needs to do to validate your changes and what areas do they need to test for regressions.

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I verified any copy / text that was added to the app is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If the PR adds or modifies the UI:
    • I asked an AI agent to review the changes for accessibility issues and addressed its findings.
    • I tested with a screen reader (VoiceOver on macOS) and verified all new/changed elements are reachable with a logical focus order.
    • I verified all new/changed elements have meaningful accessible names and roles.
    • I verified state changes are announced (e.g. checked/unchecked, expanded/collapsed, selected).
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari

@luacmartins, please review the files changed and confirm they reflect the current behavior. Then post a new comment saying @MelvinBot mark this PR as ready for review.

Co-authored-by: Carlos Martins <luacmartins@users.noreply.github.com>
@MelvinBot
MelvinBot requested a review from a team October 21, 2026 17:57
@MelvinBot MelvinBot added the HelpDot Apply this label if the issue relates to ExpensifyHelp label Oct 21, 2026
@github-actions github-actions Bot changed the title Docs updates for E/A#104591 Point web Insights steps to new Insights tab [No QA] Docs updates for E/A#104591 Point web Insights steps to new Insights tab Oct 21, 2026
@stephanieelliott

Copy link
Copy Markdown
Contributor

These changes are already covered in https://github.com/Expensify/App/pull/102832/changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

HelpDot Apply this label if the issue relates to ExpensifyHelp

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants