Skip to content

Add Exact Online waitlist - #103997

Merged
carlosmiceli merged 11 commits into
mainfrom
codex/691056-exact-online-waitlist
Oct 20, 2026
Merged

carlosmiceli merged 11 commits into
mainfrom
codex/691056-exact-online-waitlist

Conversation

@inimaga

@inimaga inimaga commented Oct 14, 2026 •

Copy link
Copy Markdown
Contributor

Held on:

Explanation of Change

Exact Online is not available yet, so workspace admins need a way to register interest before launch. This adds Exact Online with Coming soon and Join waitlist to Accounting and Connections. Signup shows the confirmation from the design and the same joined state across the account's workspaces.

Signup uses the existing account save action, works offline, keeps its timestamp on retries, and rolls back on failure. Beta users also see the waitlist until R1 adds the connection flow.

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/691056

PROPOSAL: N/A (internal implementation issue)

Tests

Manual Test steps

  1. Sign in as a workspace admin, enable Accounting, and open the Accounting page.
  2. Verify Exact Online shows its icon, Coming soon, and Join waitlist.
  3. Press Join waitlist. Verify the confirmation says “You’re on the waitlist” and “Concierge will send you a message to let you know when this integration is ready and how to connect.” Dismiss it with Got it.
  4. Verify the row now says “You’re on the waitlist” without another signup button.
  5. Reload the app, open Accounting in a second workspace, and verify the same joined state.
  • Verify that no errors appear in the JS console

Offline tests

Automated tests verify that signup remains available offline, the queued save and optimistic update use one timestamp, and failure restores the absent value. Existing live connectors remain disabled offline.

QA Steps

Same as manual test steps above

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I verified any copy / text that was added to the app is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If the PR adds or modifies the UI:
    • I asked an AI agent to review the changes for accessibility issues and addressed its findings.
    • I tested with a screen reader (VoiceOver on macOS) and verified all new/changed elements are reachable with a logical focus order.
    • I verified all new/changed elements have meaningful accessible names and roles.
    • I verified state changes are announced (e.g. checked/unchecked, expanded/collapsed, selected).
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Exact.Online.Web.mp4

@inimaga
inimaga requested review from a team as code owners October 14, 2026 14:08
@melvin-bot
melvin-bot Bot requested review from JmillsExpensify and jayeshmangwani and removed request for a team October 14, 2026 14:08
@melvin-bot

melvin-bot Bot commented Oct 14, 2026

Copy link
Copy Markdown

@jayeshmangwani Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot
melvin-bot Bot removed the request for review from a team October 14, 2026 14:08
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 14, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-15T15:38:42.404122Z c1cfff3 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@OSBotify

This comment has been minimized.

@inimaga inimaga added the Design label Oct 14, 2026
@melvin-bot
melvin-bot Bot requested a review from shawnborton October 14, 2026 14:09
Comment thread src/pages/workspace/accounting/PolicyAccountingPage.tsx Outdated
Comment thread src/pages/workspace/connections/ConnectionCard.tsx Outdated
@inimaga
inimaga marked this pull request as draft October 14, 2026 14:17
@codecov

codecov Bot commented Oct 14, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines Coverage Δ
src/CONST/index.ts 95.90% <ø> (ø)
src/ONYXKEYS.ts 100.00% <ø> (ø)
...rc/components/Icon/chunks/expensify-icons.chunk.ts 0.00% <ø> (ø)
src/libs/ExportOnyxState/masking.ts 80.95% <ø> (ø)
...es/workspace/accounting/ExactOnlineWaitlistRow.tsx 100.00% <100.00%> (ø)
...ages/workspace/accounting/PolicyAccountingPage.tsx 87.93% <100.00%> (+0.21%) ⬆️
...rc/pages/workspace/connections/ConnectionsGrid.tsx 90.90% <100.00%> (+81.81%) ⬆️
.../workspace/connections/ExactOnlineWaitlistCard.tsx 100.00% <100.00%> (ø)
...workspace/connections/WorkspaceConnectionsPage.tsx 93.22% <ø> (ø)
...ace/connections/useAccountingConnectionListings.ts 85.96% <100.00%> (+0.25%) ⬆️
... and 2 more
... and 32 files with indirect coverage changes

@inimaga

inimaga commented Oct 14, 2026

Copy link
Copy Markdown
Contributor Author

@claude review

Comment thread src/pages/workspace/connections/types.ts Outdated
@inimaga
inimaga requested review from rayane-d and removed request for jayeshmangwani October 14, 2026 15:05
@dubielzyk-expensify

Copy link
Copy Markdown
Contributor

This looks weird because there's space on the left on the badge:

CleanShot 2026-10-15 at 10 08 20 AM@2x

It should be more like the badge above on Xero:

CleanShot 2026-10-15 at 10 08 49 AM@2x

@JmillsExpensify JmillsExpensify left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@OSBotify

This comment has been minimized.

@rayane-d rayane-d left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I think the issues I found are NAB.

Comment thread src/pages/workspace/accounting/ExactOnlineWaitlistButton.tsx Outdated
@inimaga
inimaga requested a review from rayane-d October 20, 2026 16:49

@rayane-d rayane-d left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and tests well 🚀
Thanks!

Screen.Recording.2026-10-20.at.5.57.32.PM.mov

@inimaga
inimaga requested a review from a team October 20, 2026 18:59
@melvin-bot
melvin-bot Bot requested review from carlosmiceli and removed request for a team October 20, 2026 18:59
@melvin-bot

melvin-bot Bot commented Oct 20, 2026

Copy link
Copy Markdown

@carlosmiceli Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@carlosmiceli
carlosmiceli merged commit 69aaf74 into main Oct 20, 2026
47 of 49 checks passed
@carlosmiceli
carlosmiceli deleted the codex/691056-exact-online-waitlist branch October 20, 2026 20:01
@github-actions

Copy link
Copy Markdown
Contributor

🚧 carlosmiceli has triggered a test Expensify/App build. You can view the workflow run here.

@OSBotify

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/carlosmiceli in version: 9.5.16-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@MelvinBot

Copy link
Copy Markdown
Contributor

No help site update needed. Exact Online can't be connected yet, so no existing article sentence is now wrong. The new Coming soon / Join waitlist row is a temporary placeholder that explains itself in the app. Document Exact Online when the connector launches.


view run

@mitarachim

Copy link
Copy Markdown

Deploy Blocker #104660 was identified to be related to this PR.

@jponikarchuk

Copy link
Copy Markdown

Deploy Blocker #104674 was identified to be related to this PR.

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/carlosmiceli in version: 9.5.18-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 cancelled 🔪

@MelvinBot

Copy link
Copy Markdown
Contributor

No help site update needed. This PR adds a self-explanatory Exact Online "Coming soon" row with a Join waitlist button, but you still can't connect Exact Online, so no existing article sentence is now wrong. Document Exact Online when the connection flow ships.


view run

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/grgia in version: 9.5.18-1 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants