Add Zoho Books accounting settings pages and organization selector by nkdengineer · Pull Request #104685 · Expensify/App

nkdengineer · 2026-10-22T06:55:41Z

Explanation of Change

Add Zoho Books accounting settings pages and organization selector

Fixed Issues

$ #103232
PROPOSAL:

Tests

Precondition: Account has zohoBooks beta enabled

Create a WS
Enable Accounting
Connect to Zoho Books account with multiple organizations
Click on Zoho Books org row
Verify that the organization selector page appears
Select another org
Verify that the connection's org is updated
Create a new WS
Enable Accounting
Click to connect Zoho Books
Verify that the existing connection page appears
Verify existing connection
Verify that the WS is connected to Zoho Books successfully

Verify that no errors appear in the JS console

Offline tests

QA Steps

Same as test

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2026-10-22.at.13.45.22.mov

Android: mWeb Chrome

Screen.Recording.2026-10-22.at.13.48.01.mov

iOS: Native

Screen.Recording.2026-10-22.at.13.46.46.mov

iOS: mWeb Safari

Screen.Recording.2026-10-22.at.13.48.56.mov

MacOS: Chrome / Safari

Screen.Recording.2026-10-22.at.13.44.40.mov

melvin-bot · 2026-10-22T06:55:50Z

Hey, I noticed you changed src/languages/en.ts in a PR from a fork. For security reasons, translations are not generated automatically for PRs from forks.

If you want to automatically generate translations for other locales, an Expensify employee will have to:

Look at the code and make sure there are no malicious changes.
Run the Generate static translations GitHub workflow. If you have write access and the K2 extension, you can simply click: [this button]

Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running:

npx bun ./scripts/generateTranslations.ts --help

Typically, you'd want to translate only what you changed by running npx bun ./scripts/generateTranslations.ts --compare-ref main

melvin-bot · 2026-10-22T07:01:54Z

@truph01 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

chatgpt-codex-connector · 2026-10-22T07:01:59Z

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	🔄 Running since 2026-10-22T07:01:56.522289Z	`dded440`	Draft marked ready

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

codecov · 2026-10-22T07:02:47Z

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
src/CONST/index.ts	`95.90% <ø> (ø)`
src/SCREENS.ts	`100.00% <ø> (ø)`
...gation/linkingConfig/RELATIONS/WORKSPACE_TO_RHP.ts	`100.00% <ø> (ø)`
src/libs/Navigation/linkingConfig/config.ts	`68.75% <ø> (ø)`
src/ROUTES.ts	`34.61% <50.00%> (-0.01%)`	⬇️
src/selectors/Policy.ts	`87.72% <50.00%> (-0.35%)`	⬇️
...gation/AppNavigator/ModalStackNavigators/index.tsx	`7.56% <0.00%> (-0.04%)`	⬇️
...g/zohoBooks/useStartZohoBooksOAuth/index.native.ts	`0.00% <0.00%> (ø)`
src/libs/actions/connections/index.ts	`19.85% <0.00%> (-0.44%)`	⬇️
...counting/zohoBooks/useStartZohoBooksOAuth/index.ts	`0.00% <0.00%> (ø)`
... and 4 more
... and 24 files with indirect coverage changes

nkdengineer · 2026-10-23T06:29:04Z

@truph01 This is ready for review.

truph01 · 2026-10-26T09:28:09Z

@nkdengineer Could you resolve conflicts?

nkdengineer · 2026-10-26T09:35:36Z

@truph01 I've done.

lakchote · 2026-10-26T14:13:09Z

@truph01 can you review this one too? It's been ready since Thursday, a day before #104817.

truph01 · 2026-10-26T14:14:28Z

@truph01 can you review this one too? It's been ready since Thursday, a day before #104817.

I am on it now

truph01 · 2026-10-26T15:18:20Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained """"why"""" the code was doing something instead of only explaining """"what"""" the code was doing.
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Screen.Recording.2026-10-26.at.22.17.19.mov

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

MacOS: Chrome / Safari

Screen.Recording.2026-10-26.at.22.09.50.mov

nkdengineer · 2026-10-26T15:24:33Z

@truph01 I updated.

garrettmknight

Zoho looks good, but why is the Exact join the waitlist always showing in the 'Other' connections page? cc @dylanexpensify

truph01 · 2026-10-28T03:06:36Z

@dylanexpensify Could you take a look into #104685 (review)?

lakchote

Looks good. Left 2 NABs on the multi-location state, the second one is a backend follow-up on our side.

lakchote · 2026-10-28T17:17:48Z

-                          interactive: false,
+                          interactive: canWriteAccounting && zohoBooksOrganizationList.length > 1,
+                          // Multi-location organizations are not supported yet, so explain why the connection doesn't work.
+                          errorText: currentZohoBooksOrganization?.isMultiLocation ? translate('workspace.zohoBooks.multiLocationNotSupported') : undefined,


NAB: I don't think this error text can show. A multi-location org always fails its sync on the backend, and we drop the whole org row while there's a sync error (

App/src/pages/workspace/accounting/useConnectedAccountingIntegration.tsx

Line 567 in 3847aba

...(isEmptyObject(integrationSpecificMenuItems) || shouldShowSynchronizationError || !hasAccountingConnection ? [] : [integrationSpecificMenuItems]),

).

So if an admin switches to a multi-location org, the row goes away and they can't switch back without disconnecting. Could we keep the Zoho org row visible when the last sync failed, and drop this errorText since the sync error already says why?

lakchote · 2026-10-28T17:17:48Z

+              alternateText: organization.isMultiLocation ? translate('workspace.zohoBooks.multiLocationNotSupported') : undefined,
+              keyForList: organization.id,
+              isSelected: organization.id === currentOrganizationID,
+              isDisabled: !!organization.isMultiLocation,


NAB: nothing to change here, but the backend doesn't fill isMultiLocation yet, so every org shows as selectable for now. We'll do the backend follow-up.

lakchote · 2026-10-28T17:18:33Z

@garrettmknight that's from main, not this PR. #103997 added the Exact Online waitlist row for all workspace admins, and #104706 moved it under Other when the workspace already has a connection. @inimaga can confirm, but it looks intended until the Exact connection ships.

OSBotify · 2026-10-28T17:26:44Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2026-10-28T18:24:30Z

🚧 lakchote has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-10-28T18:32:50Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #104685 with the pinned Mobile-Expensify submodule.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-05bd2750-e2e4554-288dafb072c4fd6074f40dead7debfc43f997ed3/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-05bd2750-e2e4554-4f8f6ec5c1c89e332255971faad395b5f749b77d/index.html

Web 🕸️
https://104685.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-10-29T01:14:00Z

🚀 Deployed to staging by https://github.com/lakchote in version: 9.5.25-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

MelvinBot · 2026-10-29T01:17:18Z

No help site update is needed: the Zoho Books integration, including the new organization selector and existing-connection pages, is still behind the zohoBooks beta (useAccountingConnectionListings.ts:65), and no article under docs/articles mentions Zoho Books yet.

view run

kavimuru · 2026-10-29T01:19:29Z

@garrettmknight @lakchote we don't have accounts for Zoho

Add Zoho Books accounting settings pages and organization selector

8b09222

melvin-bot Bot assigned nkdengineer Oct 22, 2026

revert hard code

dded440

nkdengineer marked this pull request as ready for review October 22, 2026 07:01

nkdengineer requested review from a team as code owners October 22, 2026 07:01

melvin-bot Bot requested review from truph01 and removed request for a team October 22, 2026 07:01

melvin-bot Bot requested review from garrettmknight and removed request for a team October 22, 2026 07:01

nkdengineer added 3 commits October 26, 2026 16:29

Merge branch 'main' into fix/103232

24eb735

resolve conflict

3e7ecdd

update zoho organization to allow collect plan

7384cbe

truph01 reviewed Oct 26, 2026

View reviewed changes

Comment thread src/pages/workspace/accounting/zohoBooks/ZohoBooksExistingConnectionsPage.tsx

Comment thread src/pages/workspace/accounting/useConnectedAccountingIntegration.tsx Outdated

nkdengineer added 2 commits October 26, 2026 22:22

update review comment

28cf36c

make the row non-interactive when can't edit

851724b

truph01 approved these changes Oct 26, 2026

View reviewed changes

melvin-bot Bot requested a review from lakchote October 26, 2026 17:21

garrettmknight approved these changes Oct 26, 2026

View reviewed changes

Merge branch 'main' into fix/103232

3847aba

Merge branch 'main' into fix/103232

12823af

lakchote approved these changes Oct 28, 2026

View reviewed changes

lakchote merged commit 05bd275 into Expensify:main Oct 28, 2026
38 checks passed

OSBotify mentioned this pull request Oct 29, 2026

Deploy Checklist: New Expensify 2026-10-29 #105309

Open

20 of 66 tasks

Conversation

nkdengineer commented Oct 22, 2026

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Oct 22, 2026

Uh oh!

melvin-bot Bot commented Oct 22, 2026

Uh oh!

chatgpt-codex-connector Bot commented Oct 22, 2026

Codex Review Summary

Uh oh!

codecov Bot commented Oct 22, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

nkdengineer commented Oct 23, 2026

Uh oh!

truph01 commented Oct 26, 2026

Uh oh!

nkdengineer commented Oct 26, 2026

Uh oh!

lakchote commented Oct 26, 2026

Uh oh!

truph01 commented Oct 26, 2026

Uh oh!

Uh oh!

Uh oh!

truph01 commented Oct 26, 2026

Reviewer Checklist

Screenshots/Videos

Uh oh!

nkdengineer commented Oct 26, 2026

Uh oh!

garrettmknight left a comment

Choose a reason for hiding this comment

Uh oh!

truph01 commented Oct 28, 2026

Uh oh!

lakchote left a comment

Choose a reason for hiding this comment

Uh oh!

lakchote Oct 28, 2026

Choose a reason for hiding this comment

Uh oh!

lakchote Oct 28, 2026

Choose a reason for hiding this comment

Uh oh!

lakchote commented Oct 28, 2026

Uh oh!

Uh oh!

OSBotify commented Oct 28, 2026

Uh oh!

github-actions Bot commented Oct 28, 2026

Uh oh!

github-actions Bot commented Oct 28, 2026

Uh oh!

OSBotify commented Oct 29, 2026

Uh oh!

MelvinBot commented Oct 29, 2026

Uh oh!

kavimuru commented Oct 29, 2026

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

codecov Bot commented Oct 22, 2026 •

edited by github-actions Bot

Loading