You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[$175] Accounting - Exact Online integration still shows as connectable when another accounting app is already connected; spacing issue when expanded #104844
Version Number: 9.5.18-1 Reproducible in staging?: Y Reproducible in production?: N (Feature not available in Production) If this was caught during regression testing, add the test name, ID and link from BrowserStack: Email or phone of affected tester (no customers): Logs:https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by:@heyjennahay Slack conversation (hyperlinked to channel name): #Convert
Action Performed:
Go to a workspace's Accounting page.
Connect to any accounting integration.
Observe the list of available accounting integrations.
Expand the Exact Online integration entry.
Expected Result:
Once an accounting integration is connected, all other integration options — including Exact Online — should be hidden consistent with the rest of the accounting integrations list.
Actual Result:
Exact Online still displays as an Join waitlist option even though another accounting app is already connected, while all other integrations are correctly hidden.
When expanding the Other accounting, the spacing appears off for Entry Online option
Workaround:
Unknown
Platforms:
Select the officially supported platforms where the issue was reproduced:
Still visible: Collapsing the section hides only its children, so Exact Online stays on screen.
Spacing off: The section wrapper adds pr3 and pv3 to its children (CollapsibleSection/index.tsx:45). Exact Online misses that padding. Its button sits 12px further right than the "Setup" buttons, and a 12px gap appears above it.
Fix (in PR 104706): The PR renders the row as the last child of the CollapsibleSection when a connection exists, and on its own otherwise.
Investigation details
The row's own sizing matches the sibling rows on wide layouts. MenuItem.Root and the legacy MenuItem share popoverMenuItem padding, avatar size, 12px icon gap, and 40px min-height (MenuItemRoot.tsx:161-166). Placement is the only cause of the spacing difference.
On narrow layouts, the title and full-size badge stack in a column (ExactOnlineWaitlistRow.tsx:67-73). That likely makes the row about 8px taller than its siblings. I calculated this from style values and did not measure it in a render. If it matters, pass isBadgeCondensed={shouldUseNarrowLayout} from PolicyAccountingPage. That change doesn't affect ExactOnlineWaitlistCard, which already passes isBadgeCondensed.
Next Steps: Reply with @MelvinBot <your feedback> to refine this analysis.
changed the title [-]Accounting - Exact Online integration still shows as connectable when another accounting app is already connected; spacing issue when expanded[/-][+][$175] Accounting - Exact Online integration still shows as connectable when another accounting app is already connected; spacing issue when expanded[/+]on Oct 23, 2026
Activity
MelvinBot commentedon Oct 23, 2026
Issue Analysis
This duplicates Accounting - Exact Online is shown when all accountings are collapsed. The open PR Fix Exact Online waitlist placement and narrow layouts already fixes both symptoms reported here. I recommend closing this issue, or holding it on that PR.
Root cause: Add Exact Online waitlist renders
ExactOnlineWaitlistRowafter the "Other"CollapsibleSectioninstead of inside it (PolicyAccountingPage.tsx:409-426). That causes both symptoms:pr3andpv3to its children (CollapsibleSection/index.tsx:45). Exact Online misses that padding. Its button sits 12px further right than the "Setup" buttons, and a 12px gap appears above it.Fix (in PR 104706): The PR renders the row as the last child of the
CollapsibleSectionwhen a connection exists, and on its own otherwise.Investigation details
MenuItem.Rootand the legacyMenuItemsharepopoverMenuItempadding, avatar size, 12px icon gap, and 40px min-height (MenuItemRoot.tsx:161-166). Placement is the only cause of the spacing difference.isBadgeCondensed={shouldUseNarrowLayout}fromPolicyAccountingPage. That change doesn't affectExactOnlineWaitlistCard, which already passesisBadgeCondensed.Next Steps: Reply with
@MelvinBot <your feedback>to refine this analysis.j3ffffff commentedon Oct 23, 2026
melvin-bot commentedon Oct 23, 2026
Triggered auto assignment to Contributor-plus team member for initial proposal review - @mkhutornyi (
External)[-]Accounting - Exact Online integration still shows as connectable when another accounting app is already connected; spacing issue when expanded[/-][+][$175] Accounting - Exact Online integration still shows as connectable when another accounting app is already connected; spacing issue when expanded[/+]melvin-bot commentedon Oct 23, 2026
Job added to Upwork: https://www.upwork.com/jobs/~022113616728860939154
inimaga commentedon Nov 2, 2026
This should be resolved now.