Skip to content

[$175] Accounting - Exact Online integration still shows as connectable when another accounting app is already connected; spacing issue when expanded #104844

Closed

Description

@m-natarajan

If you haven’t already, check out our contributing guidelines for onboarding. To join our Slack channel, fill out this form.


Version Number: 9.5.18-1
Reproducible in staging?: Y
Reproducible in production?: N (Feature not available in Production)
If this was caught during regression testing, add the test name, ID and link from BrowserStack:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @heyjennahay
Slack conversation (hyperlinked to channel name): #Convert

Action Performed:

  1. Go to a workspace's Accounting page.
  2. Connect to any accounting integration.
  3. Observe the list of available accounting integrations.
  4. Expand the Exact Online integration entry.

Expected Result:

Once an accounting integration is connected, all other integration options — including Exact Online — should be hidden consistent with the rest of the accounting integrations list.

Actual Result:

Exact Online still displays as an Join waitlist option even though another accounting app is already connected, while all other integrations are correctly hidden.
When expanding the Other accounting, the spacing appears off for Entry Online option

Workaround:

Unknown

Platforms:

Select the officially supported platforms where the issue was reproduced:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari

Screenshots/Videos

Recording.3735.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
Issue OwnerCurrent Issue Owner: @rayane-d

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Oct 23, 2026
  2. MelvinBot commented on Oct 23, 2026

    @MelvinBot
    Contributor

    Issue Analysis

    This duplicates Accounting - Exact Online is shown when all accountings are collapsed. The open PR Fix Exact Online waitlist placement and narrow layouts already fixes both symptoms reported here. I recommend closing this issue, or holding it on that PR.

    Root cause: Add Exact Online waitlist renders ExactOnlineWaitlistRow after the "Other" CollapsibleSection instead of inside it (PolicyAccountingPage.tsx:409-426). That causes both symptoms:

    • Still visible: Collapsing the section hides only its children, so Exact Online stays on screen.
    • Spacing off: The section wrapper adds pr3 and pv3 to its children (CollapsibleSection/index.tsx:45). Exact Online misses that padding. Its button sits 12px further right than the "Setup" buttons, and a 12px gap appears above it.

    Fix (in PR 104706): The PR renders the row as the last child of the CollapsibleSection when a connection exists, and on its own otherwise.

    Investigation details
    • The row's own sizing matches the sibling rows on wide layouts. MenuItem.Root and the legacy MenuItem share popoverMenuItem padding, avatar size, 12px icon gap, and 40px min-height (MenuItemRoot.tsx:161-166). Placement is the only cause of the spacing difference.
    • On narrow layouts, the title and full-size badge stack in a column (ExactOnlineWaitlistRow.tsx:67-73). That likely makes the row about 8px taller than its siblings. I calculated this from style values and did not measure it in a render. If it matters, pass isBadgeCondensed={shouldUseNarrowLayout} from PolicyAccountingPage. That change doesn't affect ExactOnlineWaitlistCard, which already passes isBadgeCondensed.

    Next Steps: Reply with @MelvinBot <your feedback> to refine this analysis.

  3. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Oct 23, 2026
  4. j3ffffff commented on Oct 23, 2026

    @j3ffffff
  5. melvin-bot commented on Oct 23, 2026

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @mkhutornyi (External)

  6. changed the title [-]Accounting - Exact Online integration still shows as connectable when another accounting app is already connected; spacing issue when expanded[/-] [+][$175] Accounting - Exact Online integration still shows as connectable when another accounting app is already connected; spacing issue when expanded[/+] on Oct 23, 2026
  7. melvin-bot commented on Oct 23, 2026

    @melvin-bot
  8. removed
    ExternalAdded to denote the issue can be worked on by a contributor
    on Oct 23, 2026
  9. self-assigned this
    on Oct 24, 2026
  10. inimaga commented on Nov 2, 2026

    @inimaga
    Contributor

    This should be resolved now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ReviewingHas a PR in review

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions