Skip to content

iOS Safari-Exact Online- "You’re on the waitlist" overlaps with "Coming soon" in Polski&Greek #104674

Closed

Description

@applause-bot

If you haven’t already, check out our contributing guidelines for onboarding. To join our Slack channel, fill out this form.


Version Number: 9.5.16-0
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #103997
Email or phone of affected tester (no customers): jsoidjndoiniodnsjojd@gmail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: iPhone 17 Pro Max / iOS 27.0.1
App Component: Workspace Settings

Action Performed:

Precondition:

  • Enable Accounting.
  • Use smaller iPhone device or increase page zoom on Safari.
  1. Go to staging.new.expensify.com
  2. Go to workspace settings > Accounting.
  3. Tap Join waitlist on Exact Online.
  4. Change app language to Polski or Greek.

Expected Result:

"You’re on the waitlist" will not overlap with "Coming soon" in Polski & Greek.

Actual Result:

"You’re on the waitlist" overlaps with "Coming soon" in Polski & Greek.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome Safari

Screenshots/Videos

Image

View all open jobs on GitHub

Applause Internal Information
Exported by: Julia Ponikarchuk
Bug ID: 7292628

Issue OwnerCurrent Issue Owner: @inimaga

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Oct 22, 2026
  2. applause-bot commented on Oct 22, 2026

    @applause-bot
    Author

    While Applause doesn't embed attachments for this bug, here are the links for quick view:
    https://platform.applause.com/services/links/v1/external/44e41cbb35e9631c0fc830228ebbf9533df708c76f50b11f773843e5e46f8eba

  3. melvin-bot commented on Oct 22, 2026

    @melvin-bot

    You have been assigned to this deploy blocker because you recently merged this PR: #103997

  4. melvin-bot commented on Oct 22, 2026

    @melvin-bot

    @carlosmiceli @rayane-d you have been assigned to this deploy blocker because you reviewed the offending PR: #103997

  5. melvin-bot commented on Oct 22, 2026

    @melvin-bot

    @inimaga you have been assigned to this deploy blocker because you authored the offending PR: #103997

  6. github-actions commented on Oct 22, 2026

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  7. melvin-bot commented on Oct 22, 2026

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  8. MelvinBot commented on Oct 22, 2026

    @MelvinBot
    Contributor

    Deploy Blocker Analysis

    Causing PR: Add Exact Online waitlist (high confidence). It is the only PR that touched the waitlist row, and the tester linked it.

    Recommendation: demote, don't revert. This is a layout bug in a new feature, not a regression. Production never had this row. The overlap only appears when all three are true: the user already joined the waitlist, the language is Polish or Greek, and the screen is narrow.

    Root cause: On narrow layouts, the "You’re on the waitlist" status sits in MenuItem.Trailing and doesn't shrink. That leaves a narrow content column for the "Coming soon" badge. The badge text is single-line and has no max width, so the long translation spills under the status text.

    Quick fix (if you roll forward):

    1. In ExactOnlineWaitlistRow.tsx:72, add styles.mw100 to badgeStyles so the badge stays inside its column.
    2. In ExactOnlineWaitlistButton.tsx:58, cap the status text's width and right-align it so long translations wrap.
    Investigation details
    • PolicyAccountingPage.tsx:423-427: on narrow layouts titleWrapperStyle is false, so the title and badge stack in a column.
    • ExactOnlineWaitlistRow.tsx:66-78: the badge gets alignSelfStart but no width limit. The waitlist button or status goes in MenuItem.Trailing.
    • ExactOnlineWaitlistButton.tsx:57-59: after signup, the status is a plain Text with no width limit.
    • styles/index.ts:5743-5754: menuItemTrailing (flexRow + mlAuto) takes the full one-line width of the status. menuItemContent (flex1) gets only what is left.
    • Badge.tsx:142: badge text uses numberOfLines={1}, so it can't wrap.
    • ExactOnlineWaitlistCard.tsx:31-35 reuses the same row, so the Connections grid likely has the same issue on narrow screens.
    • The shared MenuItem layout files were last changed in August, so no other PR in this deploy affects this row.
    • This analysis comes from code only. I did not reproduce it on a device.

    Related: Accounting - Exact Online is shown when all accountings are collapsed is another open deploy blocker from the same PR. If you fix forward, consider handling both in one follow-up.


    Next Steps: Reply with @MelvinBot implement this to create a draft PR, or @MelvinBot <your feedback> to refine this analysis.


    view run

  9. 3 remaining items

  10. melvin-bot commented on Oct 29, 2026

    @melvin-bot

    @carlosmiceli / @inimaga @rayane-d

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.5.24-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the Contributor+ Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]

  11. inimaga commented on Oct 29, 2026

    @inimaga
    Contributor

    The PR fixing this is already deployed. Now requested a retest here.

  12. IuliiaHerets commented on Oct 29, 2026

    @IuliiaHerets

    Not repro on iPhone 15/ Safari build 9.5.24-8, but "Chat with your accounting executive" link is cut off in Greek

    trim.604C5BD0-DA5B-4081-9074-590CE7AD84B8.MOV
  13. inimaga commented on Oct 30, 2026

    @inimaga
    Contributor

    Thanks for confirming!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.DailyKSv2Engineering

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions