Skip to content

fix(ci): validate current workspaces and scoped checks - #221

Draft
Sma1lboy wants to merge 1 commit into
mainfrom
fix/ci-current-workspaces
Draft

Sma1lboy wants to merge 1 commit into
mainfrom
fix/ci-current-workspaces

Conversation

@Sma1lboy

@Sma1lboy Sma1lboy commented Oct 1, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

Repair baseline CI independently of the feature audit PRs.

  • Use the declared pnpm 9.1.0 through pnpm/action-setup v4 and Node 22, matching locked AI SDK engine requirements; keep installs frozen
  • Build actual frontend/backend workspaces instead of the deleted codefox-common package and watch shared manifests, lockfile, patches and workflow changes
  • Run every focused frontend jest.*.config.js suite when present
  • Typecheck both real workspace projects instead of running tsc without a root tsconfig
  • Restrict autofix formatting, linting and staging to eligible PR-changed files; preserve filenames with spaces and exclude deleted files; keep actual ESLint/type errors blocking
  • Resolve ESLint plugins relative to backend, where eslint-plugin-prettier is already declared. Root package.json and pnpm-lock.yaml remain unchanged
  • Replace the undeclared frontend fs-extra import with equivalent native node:fs APIs
  • Repair stale lint/notes/quota source checks after prompt assembly extraction and user-ID forwarding; keep caller-to-helper wiring and actual guard behavior covered
  • Add a dependency-free CI contract guard. No workflow permissions, credentials or security policies change

Validation

  • Current bounded branch: 41/41 source checks, versus 37/40 on untouched main; git diff --check passes
  • Nine source-contract mutations fail as expected and pass when restored; reverting the old frontend workflow also fails the new guard
  • Workflow shell fixtures cover all four focused test configs, no-config revisions, failed-suite propagation, changed-file scoping, spaces, deleted files and ESLint error propagation
  • Before publication, unchanged product-source fixes passed both workspace typechecks and production builds, plus all 40 backend suites / 278 tests and coverage under Node 24.19.0 / pnpm 9.1.0
  • Clean GitHub CI on f5ea2bf: frontend build, backend build/tests, autofix/typechecks and coverage all passed, plus the Vercel preview. This verifies backend-relative ESLint plugin resolution with the unchanged manifests/lockfile
  • Root manifests/lockfile and workflow permissions match the baseline exactly

The optional explicit root lint-plugin dependency addition was deferred; this PR uses the existing declared backend plugin and requires no dependency or lockfile change. Screenshot infrastructure is separate in #220. Existing lint warnings remain visible; the dormant llm-server workflow is outside this repair.

@vercel

vercel Bot commented Oct 1, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
codefox Ready Ready Preview Oct 1, 2026 9:48am UTC

Request Review

@codecov-commenter

Copy link
Copy Markdown

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

ℹ️ You can also turn on project coverage checks and project coverage reporting on Pull Request comment

Thanks for integrating Codecov - We've got you covered ☂️

This branch was successfully deployed

1 active deployment
Preview — f5ea2bfd Deployed Oct 1, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants