Skip to content

fix: align authentication and recovery copy with behavior - #218

Draft
Sma1lboy wants to merge 1 commit into
mainfrom
fix/auth-recovery-copy
Draft

Sma1lboy wants to merge 1 commit into
mainfrom
fix/auth-recovery-copy

Conversation

@Sma1lboy

@Sma1lboy Sma1lboy commented Oct 1, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

Make authentication, password recovery, and profile copy describe what the app actually does (audit CF16–21).

  • Explain the existing signup rule: 6+ characters and any two character types. Keep the help visible before typing; retain the exact existing validator and all backend password policies
  • Classify existing sign-in outcomes instead of blaming every error on credentials. Preserve unknown/inactive/deleted-account ambiguity. Keep the Login transport error visible while retaining existing stored-token cleanup and refresh/validation redirects
  • Gate reset-email submission on a new public deployment-wide passwordResetEmailAvailable capability, backed solely by the existing mail-enabled flag. Loading, failed checks, and disabled mail cannot submit the reset form. The reset mutation continues to return an account-neutral result
  • Use “Display name,” explain public-project attribution and autosave, and translate existing validation outcomes without altering their rules
  • Keep the reset dialog’s accessible title in sync, replace token jargon with recovery steps, and use “Update password” for the password action
  • Store resend success/error state separately from translated display text so changed copy does not break styling or cooldown cleanup

Before → after

  • “Password must … include uppercase, number, special character” → “Use at least 6 characters and at least two of these …”
  • Every sign-in failure: “Incorrect email or password” → credential, existing verification, transport, or generic recovery copy
  • “We’ll email you a link” even when mail is disabled → explicit unavailable state and disabled submit
  • Signup “Name” → “Display name,” with public-project attribution
  • Reset form announced as “Sign In” → “Reset your password”
  • “No token provided” → “This verification link is incomplete. Open the full link from your CodeFox email.”

Validation

Final head: 94d238c4d8475439a0f569d05590d270f6ac69d9.

  • Strict exact-head integration passed after locally combining this head with CI repair #221 at f5ea2bfdf2037ace6ad50f6c3c7feaa9df0693d9. No integration commit was pushed.
  • Frontend focused Jest: 15/15 passed. Full backend Jest: 280/280 passed, including the capability and existing password/reset suites.
  • Frontend and backend TypeScript and production builds passed. Source guards: 42/42 passed. Changed-file ESLint: 0 errors, 11 warnings.
  • Real stage outcomes and raw logs are retained in the workflow artifacts. No continue-on-error masks acceptance checks. This supersedes the earlier local missing-native-binding, fs-extra, and plugin-resolution limitations.
  • Red → green source regressions cover password requirements and Login transport feedback.
  • Browser evidence: 4 reviewed raw before/after PNGs at the exact baseline dd33611 and this head, showing signup requirements and reset unavailable state. Actual Next pages, synthetic local GraphQL data, no production account or email actions.
  • Vercel preview reports success for this exact head.

The ordinary checks on this independent branch still run the old main workflows and remain red. Review/merge #221 first, then update/recheck the feature branches; the clean integration result is not a claim that those old branch checks are green.

Rollout and review notes

Deploy backend before frontend for the new GraphQL capability. An older/unavailable backend safely disables email recovery and explains that availability could not be checked.

No password length/complexity policy, token format, hashing, account state, session revocation, rate limit, mail configuration, credential storage, or user account was changed. No registration, reset email, real sign-in, or paid generation was submitted during verification.

Production mail configuration was not inferred. The browser evidence uses a deployment-wide mail-disabled fixture; it is not a claim that production reset email is disabled.

@vercel

vercel Bot commented Oct 1, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
codefox Ready Ready Preview Oct 1, 2026 9:09am UTC

Request Review

This branch was successfully deployed

1 active deployment
Preview — 94d238c4 Deployed Oct 1, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant