Skip to content

fix: make editor and deployment feedback truthful - #219

Draft
Sma1lboy wants to merge 1 commit into
mainfrom
fix/editor-state-copy
Draft

Sma1lboy wants to merge 1 commit into
mainfrom
fix/editor-state-copy

Conversation

@Sma1lboy

@Sma1lboy Sma1lboy commented Oct 1, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

Fix the audited editor and deployment feedback so it describes confirmed outcomes and offers a real recovery path (CF02, CF04, CF05, history portion of CF08, preview portion of CF09, deployment-copy portion of CF13, and CF14).

Before → after

  • Fixed six-minute Initializing project (N%) animation and stored completion bypass → indeterminate Preparing your project…, gated by this chat's resolved project/readiness state
  • Restore errors promised files were unchanged → unknown-outcome warning with refreshed files/history; known rejected requests preserve the current draft
  • Failed history requests appeared as No history yet → distinct error state and working retry
  • Timeout claimed Nothing was deployed → check Vercel deployments before retrying; also handles lost network responses and unreadable response bodies
  • Deployment link displayed a copied check before clipboard success → await the write, handle rejection/missing support, provide a selectable complete URL, and ignore stale results after dismissal
  • Reset / Save → Discard changes / Save file, with a wrapping narrow-screen layout and truthful failed-save feedback
  • Unnamed preview icons/path → persistent accessible names

The save path also preserves dirty drafts during background reads, keeps newer edits unsaved when an earlier save completes, ignores obsolete save messages after chat navigation, and prevents editing/saving another file's displayed contents during a delayed file read.

Validation

Final head: b3c1a666b5f9cdcec94be7480ca978e7fa5397a2.

  • Strict exact-head integration passed after locally combining this head with CI repair #221 at f5ea2bfdf2037ace6ad50f6c3c7feaa9df0693d9. No integration commit was pushed.
  • Focused frontend: 24/24 passed. Full backend: 280/280 passed. Both TypeScript checks and both production builds passed.
  • Source guards: 42/42 passed. Changed-file ESLint, including test imports: 0 errors, 30 warnings.
  • Real step outcomes and raw logs are retained; no continue-on-error masks acceptance checks. The final independent production build completed all 15 pages, resolving the earlier shared-workspace cleanup blocker.
  • Red tests: baseline component run had 21 failures / 23 cases; the subsequently added delayed-file-read case passes in the final 24-case suite. All three deployment-uncertainty regressions fail on the original backend.
  • Browser evidence: 10 reviewed raw PNGs, five before/after pairs for preparation, history failure, narrow save controls, deployment feedback, and preview. Exact baseline dd33611 and this head, actual imported components, explicit synthetic context/API/clipboard/Monaco fixtures.
  • Vercel preview reports success for this exact head.

The ordinary checks on this independent branch still use old main workflows and remain red. Review/merge #221 first, then update/recheck feature branches. The clean integration result does not imply those old checks are green.

No real sign-in, paid generation, account action, or deployment was submitted. Mocked service outcomes exercise UI behavior; screenshots do not prove live provider behavior.

Reproduction commands and detailed test boundaries: docs/testing/editor-feedback.md.

@vercel

vercel Bot commented Oct 1, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
codefox Ready Ready Preview Oct 1, 2026 9:33am UTC

Request Review

This branch was successfully deployed

1 active deployment
Preview — b3c1a666 Deployed Oct 1, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant