Skip to content

fix: make project actions and feedback explicit - #217

Draft
Sma1lboy wants to merge 2 commits into
mainfrom
fix/project-feedback
Draft

Sma1lboy wants to merge 2 commits into
mainfrom
fix/project-feedback

Conversation

@Sma1lboy

@Sma1lboy Sma1lboy commented Oct 1, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

Fixes source-audit findings CF01, CF03, CF07, CF08, CF12, CF13 (toolbar), and CF15. No visibility policy, ownership, quota, or backend deletion behavior changes.

Before → after

  • Duplicate reused deletion callbacks and could announce success without a returned ID → one duplication result, success only with a new chat ID, preserved quota/ownership guidance, recoverable generic failure otherwise
  • Visibility controls read “Public” / “Private” but changed access immediately → explicit “Make public” / “Make private” actions, current-state consequences, shared pending guard for desktop/compact views
  • Clear history immediately deleted messages → shared confirmation explains messages removed/project files retained; Cancel and Escape preserve history, repeated submissions are guarded, failures stay retryable, late responses cannot clear a newly selected chat
  • Failed queries looked like empty project lists → visible failure and Retry; cached projects stay visible with a stale-data warning
  • Workbench “Rename project” edited only chat.title → “Rename chat” / “Chat title” and explicit scope description
  • Toolbar clipboard copy announced success before completion → await browser result, catch denied/unavailable clipboard
  • Generic remix failures said “fork” → consistent remix wording, preserving existing quota and ownership errors

Verification

Final head: 2f500ace5aa4de98d9422899f18baa2a16f62e5b.

  • Strict exact-head integration passed after locally combining this head with CI repair #221 at f5ea2bfdf2037ace6ad50f6c3c7feaa9df0693d9. No integration commit was pushed.
  • Focused frontend: 26/26 passed. Full backend: 278/278 passed. Frontend/backend TypeScript and both production builds passed.
  • Source guards: 42/42 passed. Changed-file ESLint, including regression tests: 0 errors, 12 warnings.
  • Behavioral red/green against baseline dd33611e3debb0170b801f42370cda55d6c5caa7: 18 failed / 8 passed before, 26 passed after. New helper/dialog files were supplied only to make baseline test imports compile; baseline application components remained unchanged.
  • Real React/Radix component tests cover missing IDs, duplication errors, true empty states, stale cached lists, retry, both clear-history entry points, Cancel/Escape, repeat clicks, server false/rejection, navigation races, desktop/compact visibility, and denied/unavailable clipboard.
  • Clean build diagnostics found two forbidden test require('react') imports; these are now typed jest.requireActual calls. Raw logs and genuine step outcomes were checked. The final acceptance workflow does not mask errors with continue-on-error.
  • Browser evidence: 16 raw before/after PNGs for rename scope, duplication failure/success, query failure, clear confirmation/failure, desktop and compact visibility. Actual Next UI, exact baseline and feature SHA, explicitly synthetic local API/context.
  • Browser cancellation diagnostics: body pointer events restore to auto immediately after Cancel; the closed dialog finishes its exit animation within roughly 500ms. Reopen and Escape succeed without a clear mutation. Final screenshots wait for observable overlay opacity and bounds to settle. No persistent pointer lock was reproduced.
  • Vercel preview reports success for this exact head.

The ordinary checks on this independent branch still run the old main workflows and remain red. Review/merge #221 first, then update/recheck the feature branches. The clean integration result is not a claim that those old branch checks are green.

Screenshots isolate this PR, so unrelated baseline loading copy remains until #219 is applied. Tests mock network/navigation/clipboard boundaries; no production account, email, paid generation, or deployment action was submitted.

@vercel

vercel Bot commented Oct 1, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
codefox Ready Ready Preview Oct 1, 2026 10:05am UTC

Request Review

This branch was successfully deployed

1 active deployment
Preview — 2f500ace Deployed Oct 1, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant