Skip to content

Scope person-query evidence to decision reads - #1072

Open
zlareb1 wants to merge 1 commit into
mainfrom
fix/scim-person-query-capture
Open

zlareb1 wants to merge 1 commit into
mainfrom
fix/scim-person-query-capture

Conversation

@zlareb1

@zlareb1 zlareb1 commented Nov 20, 2026 •

Copy link
Copy Markdown
Member

Related: #1076

Related: #1077

Changelog category

  • CI Fix or Improvement

Why

The person-decision integration fixture wraps a shared client and records unrelated reads from background tasks. A schema watcher starts with an independent context and can legitimately omit a default read timeout, contaminating the decision-only finite-budget assertion. Select observations by the decision query tag at entry.

Scope and risk

The fixture recorder and its regressions change. Replicated-erasure lease provisioning and its unit regression controls are on main. This branch preserves them unchanged. No production lease or erasure rule changes. Both query methods retain decision reads even when their timeout is absent. The finite-budget assertion remains intact. The failing hosted log does not identify its offending SQL; this change fixes the independently reproduced capture defect without claiming a unique cause for that run.

Compatibility, rollout and rollback

No production code, wire fields, settings, schema or operator steps change. Reverting restores the fixture recorder. No data changes need rollback.

Tests

This head matches the exact three-way composition of the preceding qualified source and current main. The erasure fixture and its canonical unit regression module are inherited from main. On this composed head, all three erasure unit cases, scoped Ruff, Python formatting, committed-range whitespace and public-body prose checks pass. Full required hosted CI and a fresh independent whole review remain required for this exact head.

env LOOM_ENV_FILE= .venv/bin/python -m pytest tests/unit/test_erasure_replicated_fixture.py -q

Earlier feature qualification

The following feature-specific results were recorded before this composition. They are prior-source receipts, not new tests of this composed head.

Ten bounded tests exercise the actual fixture with an inert client. Four concurrent-schema cases fail before the capture correction, then all ten pass with the identical command. Two negative controls retain unbounded person reads, and four cases verify the real person reader and client pass a finite budget to a fake driver. No database or background watcher service starts. The final composition exercises the merged main fixture through all 13 directly related cases.

LOOM_ENV_FILE= .venv/bin/python -m pytest tests/unit/test_scim_person_query_observation.py tests/unit/test_erasure_replicated_fixture.py -q

Full hosted CI, including the original integration assertion, remains required.

AI assistance in the code

  • AI-generated: Codex prepared the fixture correction and checked the independent-context query trace and fail-first controls.

  • I can explain every line of this diff and how it interacts with the rest of Loom.

Checklist

  • Full required hosted checks pass on this head.
  • Production budgets and finite-budget assertions remain unchanged.
  • No generated files or operator steps are required.
  • Commits are signed off.

@vercel

vercel Bot commented Nov 20, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
loom-docs Ready Ready Preview Nov 21, 2026 12:09am UTC

Request Review

Shared client schema reads run with an independent context. Record only decision-tagged statements while retaining unbounded decision reads as failures.

Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
@zlareb1
zlareb1 force-pushed the fix/scim-person-query-capture branch from 479ed8c to a5e73f0 Compare November 21, 2026 00:08

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant