Repository navigation
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This was referenced Nov 20, 2026
zlareb1
force-pushed
the
fix/scim-person-query-capture
branch
from
November 20, 2026 22:17
7cd6fe5 to
7793ec8
Compare
This was referenced Nov 20, 2026
Open
zlareb1
force-pushed
the
fix/scim-person-query-capture
branch
from
November 20, 2026 23:07
7793ec8 to
479ed8c
Compare
Shared client schema reads run with an independent context. Record only decision-tagged statements while retaining unbounded decision reads as failures. Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
zlareb1
force-pushed
the
fix/scim-person-query-capture
branch
from
November 21, 2026 00:08
479ed8c to
a5e73f0
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related: #1076
Related: #1077
Changelog category
Why
The person-decision integration fixture wraps a shared client and records unrelated reads from background tasks. A schema watcher starts with an independent context and can legitimately omit a default read timeout, contaminating the decision-only finite-budget assertion. Select observations by the decision query tag at entry.
Scope and risk
The fixture recorder and its regressions change. Replicated-erasure lease provisioning and its unit regression controls are on main. This branch preserves them unchanged. No production lease or erasure rule changes. Both query methods retain decision reads even when their timeout is absent. The finite-budget assertion remains intact. The failing hosted log does not identify its offending SQL; this change fixes the independently reproduced capture defect without claiming a unique cause for that run.
Compatibility, rollout and rollback
No production code, wire fields, settings, schema or operator steps change. Reverting restores the fixture recorder. No data changes need rollback.
Tests
This head matches the exact three-way composition of the preceding qualified source and current main. The erasure fixture and its canonical unit regression module are inherited from main. On this composed head, all three erasure unit cases, scoped Ruff, Python formatting, committed-range whitespace and public-body prose checks pass. Full required hosted CI and a fresh independent whole review remain required for this exact head.
Earlier feature qualification
The following feature-specific results were recorded before this composition. They are prior-source receipts, not new tests of this composed head.
Ten bounded tests exercise the actual fixture with an inert client. Four concurrent-schema cases fail before the capture correction, then all ten pass with the identical command. Two negative controls retain unbounded person reads, and four cases verify the real person reader and client pass a finite budget to a fake driver. No database or background watcher service starts. The final composition exercises the merged main fixture through all 13 directly related cases.
Full hosted CI, including the original integration assertion, remains required.
AI assistance in the code
AI-generated: Codex prepared the fixture correction and checked the independent-context query trace and fail-first controls.
I can explain every line of this diff and how it interacts with the rest of Loom.
Checklist