This repository was archived by the owner on Oct 21, 2026. It is now read-only.
Repository navigation
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
✅ Deploy Preview for vjs10-site ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
@videojs/cdn
@videojs/cli
@videojs/core
@videojs/element
@videojs/html
@videojs/media
@videojs/react
@videojs/spf
@videojs/store
@videojs/utils
@videojs/cloudflare-video
@videojs/dash-video
@videojs/hlsjs-video
@videojs/mux-audio
@videojs/mux-video
@videojs/native-hls-video
@videojs/shaka-video
@videojs/spotify-audio
@videojs/tiktok-video
@videojs/twitch-video
@videojs/vimeo-video
@videojs/wistia-video
@videojs/youtube-video
@videojs/google-cast
@videojs/mux-data
commit: |
✅ Deploy Preview for vjs-registry ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
📦 Bundle Size Report🎨 @videojs/html — 8 small size changes
Presets (7)
Media (18)
Players (5)
Skins (29)
UI Components (62)
⚛️ @videojs/react — 3 small size changes
Presets (7)
Media (22)
Extensions (2)
Players (5)
Skins (18)
UI Components (39)
🧩 @videojs/core — no changesEntries (76)
🏷️ @videojs/element — no changesEntries (2)
📦 @videojs/store — no changesEntries (3)
🔧 @videojs/utils — no changesEntries (13)
📦 @videojs/cdn — no changes📦 @videojs/cloudflare-video — no changes📦 @videojs/dash-video — no changes📦 @videojs/google-cast — no changes📦 @videojs/hlsjs-video — no changes📦 @videojs/media — no changesEntries (3)
📦 @videojs/mux — no changes📦 @videojs/mux-audio — no changesEntries (2)
📦 @videojs/mux-data — no changes📦 @videojs/mux-video — no changesEntries (2)
📦 @videojs/native-hls-video — no changes📦 @videojs/shaka-video — no changes📦 @videojs/spf — no changesEntries (7)
📦 @videojs/spotify-audio — no changes📦 @videojs/tiktok-video — no changes📦 @videojs/twitch-video — no changes📦 @videojs/other — 1 small size change
Entries (3)
📦 @videojs/vimeo-video — no changes📦 @videojs/wistia-video — no changesEntries (2)
📦 @videojs/youtube-video — no changesℹ️ How to interpretEach entry is independently bundled, minified, and brotli-compressed. Initial size includes its static import graph; lazy dynamic chunks are reported separately. Entries are not additive because their dependency graphs overlap. Preset rows represent realistic combined bundles. Changes of 300 B or less across initial, lazy, and total size are collapsed, not discarded. Run |
The default video skin hid its captions button below 32rem, which covers most phones, and the default live video skin hid its captions menu there too, with no settings menu to fall back on. Hide the video captions button only below 20rem, as the neutral skin does, and always show the live captions menu.
mihar-22
force-pushed
the
fix/3002-captions-button-narrow
branch
from
October 1, 2026 19:49
3dc2e3d to
7ad8a79
Compare
luwes
approved these changes
Oct 6, 2026
Member
Author
|
Moved to videojs/video.js#9473 |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes videojs/video.js#9415
Summary
The default video skin hid its captions button on players narrower than 32rem, which is most phones. There, captions were reachable only from the settings menu. The default live video skin hid its captions menu below 32rem as well, and that skin has no settings menu, so narrow live players had no way to turn on captions at all. This PR settles the decision the issue asks for: the default skin now matches the neutral skin.
Changes
Trade-off for reviewers: with captions available, the time slider group gives up about 36px. On players under about 450px wide, that pushes it below its 16rem threshold, so the current and remaining time readouts hide, as they already do on smaller players. The neutral skin already makes the same trade.
Visual Evidence
Default video skin,
/html-video/?source=mp4-1&skin=default&styling=csswith a subtitles track. Measured in Chromium; "player" is the skin's width:The default live skin's control bar at a 284px player still has a 51px spacer, so the 36px captions menu fits.
Testing
pnpm -F @videojs/skins testpnpm typecheckon the top of the stackStacked on #3106.
🤖 Generated with Claude Code
Note
Low Risk
Responsive UI and CSS breakpoint changes only; no auth, data, or playback logic. Trade-off is slightly tighter control bar on mid-width phones (time readouts may hide earlier when captions show).
Overview
Fixes narrow-player captions access by aligning the default skins with neutral behavior and documenting how to customize breakpoints.
The default video skin now hides the captions control only below 20rem (
media-max-xs) instead of 32rem (media-max-lg), via a simplifiedcaptionsButtonrule in sharedcontrols.styles.ts(variant-specific breakpoints removed). The default live video skin always showsCaptionsMenuby dropping themedia-max-lg:hiddenstyle and thecaptionsMenuclass on the component.The Customize skins guide adds a section on container-query control hiding and how to change the captions breakpoint in Tailwind or vanilla CSS.
Reviewed by Cursor Bugbot for commit 7ad8a79. Bugbot is set up for automated code reviews on this repo. Configure here.