Repository navigation
fix(skin): show captions controls on narrow default players - #9473
Conversation
@videojs/cdn
@videojs/cli
@videojs/core
@videojs/element
@videojs/html
@videojs/media
@videojs/react
@videojs/spf
@videojs/store
@videojs/utils
@videojs/cloudflare-video
@videojs/dash-video
@videojs/hlsjs-video
@videojs/mux-audio
@videojs/mux-video
@videojs/native-hls-video
@videojs/playerjs-video
@videojs/shaka-video
@videojs/spotify-audio
@videojs/tiktok-video
@videojs/twitch-video
@videojs/vimeo-video
@videojs/wistia-video
@videojs/youtube-video
@videojs/google-cast
@videojs/mux-data
commit: |
📦 Bundle Size Report🎨 @videojs/html — 8 small size changes
Presets (7)
Media (19)
Players (5)
Skins (53)
UI Components (62)
⚛️ @videojs/react — 3 small size changes
Presets (7)
Media (23)
Extensions (2)
Players (5)
Skins (34)
UI Components (39)
🧩 @videojs/core — no changesEntries (76)
🏷️ @videojs/element — no changesEntries (2)
📦 @videojs/store — no changesEntries (3)
🔧 @videojs/utils — no changesEntries (13)
📦 @videojs/cdn — no changes📦 @videojs/cloudflare-video — no changes📦 @videojs/dash-video — no changes📦 @videojs/google-cast — no changes📦 @videojs/hlsjs-video — no changes📦 @videojs/media — no changesEntries (3)
📦 @videojs/mux — no changes📦 @videojs/mux-audio — no changesEntries (2)
📦 @videojs/mux-data — no changes📦 @videojs/mux-video — no changesEntries (2)
📦 @videojs/native-hls-video — no changes📦 @videojs/playerjs-video — no changes📦 @videojs/shaka-video — no changes📦 @videojs/spf — no changesEntries (7)
📦 @videojs/spotify-audio — no changes📦 @videojs/tiktok-video — no changes📦 @videojs/twitch-video — no changes📦 @videojs/other — no changesEntries (3)
📦 @videojs/vimeo-video — no changes📦 @videojs/wistia-video — no changesEntries (2)
📦 @videojs/youtube-video — no changesℹ️ How to interpretEach entry is independently bundled, minified, and brotli-compressed. Initial size includes its static import graph; lazy dynamic chunks are reported separately. Entries are not additive because their dependency graphs overlap. Preset rows represent realistic combined bundles. Changes of 300 B or less across initial, lazy, and total size are collapsed, not discarded. Run |
✅ Deploy Preview for vjs10-site ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for vjs-registry ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
sampotts
left a comment
There was a problem hiding this comment.
I can't see the sandbox preview to visually check but it looks fine on the face of it.
The default video skin hid its captions button below 32rem, which covers most phones, and the default live video skin hid its captions menu there too, with no settings menu to fall back on. Hide the video captions button only below 20rem, as the neutral skin does, and always show the live captions menu.
8299fc1 to
bc8e0af
Compare
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Fixes #9415
Summary
The default video skin hid its captions button on players narrower than 32rem, which is most phones. There, captions were reachable only from the settings menu. The default live video skin hid its captions menu below 32rem as well, and that skin has no settings menu, so narrow live players had no way to turn on captions at all. This PR settles the decision the issue asks for: the default skin now matches the neutral skin.
Changes
Trade-off for reviewers: with captions available, the time slider group gives up about 36px. On players under about 450px wide, that pushes it below its 16rem threshold, so the current and remaining time readouts hide, as they already do on smaller players. The neutral skin already makes the same trade.
Visual Evidence
Default video skin,
/html-video/?source=mp4-1&skin=default&styling=csswith a subtitles track. Measured in Chromium; "player" is the skin's width:The default live skin's control bar at a 284px player still has a 51px spacer, so the 36px captions menu fits.
Testing
pnpm -F @videojs/skins testpnpm typecheckon the top of the stackStacked on #9472.
🤖 Generated with Claude Code
Moved from videojs/v10#3107.