Skip to content
This repository was archived by the owner on Oct 21, 2026. It is now read-only.

fix(installation): remove current create-vite starter assets from new vite apps - #3102

Closed
mihar-22 wants to merge 1 commit into
mainfrom
fix/3001-vite-starter-files
Closed

mihar-22 wants to merge 1 commit into
mainfrom
fix/3001-vite-starter-files

Conversation

@mihar-22

@mihar-22 mihar-22 commented Oct 1, 2026 •

Copy link
Copy Markdown
Member

Fixes videojs/video.js#9411

Summary

create-vite 9.2 moved its demo images into src/assets/ and added a public/icons.svg sprite. The agents init plan for a new Vite app still deleted the old src/typescript.svg, so the new starter assets stayed behind, unused, once the player replaced the demo page. The same happened in React, Vue, and Svelte Vite apps, not only plain HTML.

Changes

  • The starter files a new Vite app deletes match create-vite 9.2.1's vanilla-ts, react-ts, vue-ts, and svelte-ts templates: the demo page and its images (src/assets/hero.png, src/assets/vite.svg, the framework logo) and public/icons.svg.
  • public/favicon.svg stays, because the starter index.html still links to it.

Testing

  • pnpm -F @videojs/installation test
  • I listed the files in the create-vite@9.2.1 template package and checked which ones the replaced demo pages import. The stylesheets that remain import no assets.

This is the base of a stack: #3102 → #3103 → #3104 → #3106 → #3107. The Video.js 8 skill change is in videojs/skills#14.

🤖 Generated with Claude Code


Note

Low Risk
Scoped to Vite new-app file cleanup lists and test expectations; no auth, runtime player, or install command behavior changes beyond which starter files get deleted.

Overview
Updates installationStarterFiles so agents init removes the unused create-vite 9.2 demo leftovers when it replaces the starter page in new Vite apps (HTML, React, Vue, Svelte).

Besides the existing demo scripts/styles/components, the removal list now includes shared assets (src/assets/hero.png, src/assets/vite.svg, public/icons.svg) and each template’s framework logo under src/assets/. Plain HTML also drops src/typescript.svg in favor of src/assets/typescript.svg. public/favicon.svg is intentionally not removed because the generated index.html still references it.

Tests assert the full per-framework lists, the favicon exclusion, and wire integration expectations to installationStarterFiles instead of hard-coded paths.

Reviewed by Cursor Bugbot for commit 973d53c. Bugbot is set up for automated code reviews on this repo. Configure here.

@vercel

vercel Bot commented Oct 1, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
v10-sandbox Ready Ready Preview Oct 1, 2026 7:50pm UTC

Request Review

@netlify

netlify Bot commented Oct 1, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for vjs10-site ready!

Name Link
🔨 Latest commit 973d53c
🔍 Latest deploy log https://app.netlify.com/projects/vjs10-site/deploys/6abeb93093e93b0008cfdfdf
😎 Deploy Preview https://deploy-preview-3102--vjs10-site.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify

netlify Bot commented Oct 1, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for vjs-registry canceled.

Name Link
🔨 Latest commit 973d53c
🔍 Latest deploy log https://app.netlify.com/projects/vjs-registry/deploys/6abeb930862cd00008474327

@pkg-pr-new

pkg-pr-new Bot commented Oct 1, 2026 •

Copy link
Copy Markdown
@videojs/cdn

pnpm add https://pkg.pr.new/@videojs/cdn@3102

@videojs/cli

pnpm add https://pkg.pr.new/@videojs/cli@3102

@videojs/core

pnpm add https://pkg.pr.new/@videojs/core@3102

@videojs/element

pnpm add https://pkg.pr.new/@videojs/element@3102

@videojs/html

pnpm add https://pkg.pr.new/@videojs/html@3102

@videojs/media

pnpm add https://pkg.pr.new/@videojs/media@3102

@videojs/react

pnpm add https://pkg.pr.new/@videojs/react@3102

@videojs/spf

pnpm add https://pkg.pr.new/@videojs/spf@3102

@videojs/store

pnpm add https://pkg.pr.new/@videojs/store@3102

@videojs/utils

pnpm add https://pkg.pr.new/@videojs/utils@3102

@videojs/cloudflare-video

pnpm add https://pkg.pr.new/@videojs/cloudflare-video@3102

@videojs/dash-video

pnpm add https://pkg.pr.new/@videojs/dash-video@3102

@videojs/hlsjs-video

pnpm add https://pkg.pr.new/@videojs/hlsjs-video@3102

@videojs/mux-audio

pnpm add https://pkg.pr.new/@videojs/mux-audio@3102

@videojs/mux-video

pnpm add https://pkg.pr.new/@videojs/mux-video@3102

@videojs/native-hls-video

pnpm add https://pkg.pr.new/@videojs/native-hls-video@3102

@videojs/shaka-video

pnpm add https://pkg.pr.new/@videojs/shaka-video@3102

@videojs/spotify-audio

pnpm add https://pkg.pr.new/@videojs/spotify-audio@3102

@videojs/tiktok-video

pnpm add https://pkg.pr.new/@videojs/tiktok-video@3102

@videojs/twitch-video

pnpm add https://pkg.pr.new/@videojs/twitch-video@3102

@videojs/vimeo-video

pnpm add https://pkg.pr.new/@videojs/vimeo-video@3102

@videojs/wistia-video

pnpm add https://pkg.pr.new/@videojs/wistia-video@3102

@videojs/youtube-video

pnpm add https://pkg.pr.new/@videojs/youtube-video@3102

@videojs/google-cast

pnpm add https://pkg.pr.new/@videojs/google-cast@3102

@videojs/mux-data

pnpm add https://pkg.pr.new/@videojs/mux-data@3102

commit: 973d53c

@github-actions

github-actions Bot commented Oct 1, 2026 •

Copy link
Copy Markdown
Contributor

📦 Bundle Size Report

🎨 @videojs/html — no changes
Presets (7)
Entry Initial Lazy
/video (default) 65.00 kB 56.03 kB
/video (default + hls) 66.73 kB 56.03 kB
/video (neutral) 65.44 kB 56.03 kB
/video (neutral + hls) 67.25 kB 56.03 kB
/audio (default) 48.90 kB 56.03 kB
/audio (neutral) 49.21 kB 56.03 kB
/background 12.53 kB 56.03 kB
Media (18)
Entry Initial
/media/mux-video 3.04 kB
/media/mux-audio 2.70 kB
/media/background-video 1.17 kB
/media/cloudflare-video 2.92 kB
/media/dash-video 2.63 kB
/media/hls-audio 23.51 kB
/media/hls-background-video 17.56 kB
/media/hls-video 33.85 kB
/media/hlsjs-video 2.63 kB
/media/mux-background-video 17.58 kB
/media/native-hls-video 7.53 kB
/media/shaka-video 2.64 kB
/media/spotify-audio 3.03 kB
/media/tiktok-video 3.14 kB
/media/twitch-video 2.94 kB
/media/vimeo-video 2.91 kB
/media/wistia-video 614 B
/media/youtube-video 2.91 kB
Players (5)
Entry Initial Lazy
/video/player 10.62 kB 56.03 kB
/audio/player 6.83 kB 56.03 kB
/background/player 5.12 kB 56.03 kB
/live-video/player 9.99 kB 56.03 kB
/live-audio/player 6.84 kB 56.03 kB
Skins (29)
Entry Type Initial Lazy
/video/neutral-skin.css css 8.28 kB —
/video/skin.css css 8.00 kB —
/video/neutral-skin js 63.42 kB 56.03 kB
/video/neutral-skin2 js 8.28 kB —
/video/skin js 62.90 kB 56.03 kB
/video/skin2 js 7.98 kB —
/audio/neutral-skin.css css 6.07 kB —
/audio/skin.css css 5.80 kB —
/audio/neutral-skin js 47.12 kB 56.03 kB
/audio/neutral-skin2 js 6.05 kB —
/audio/skin js 46.83 kB 56.03 kB
/audio/skin2 js 5.78 kB —
/background/skin.css css 141 B —
/background/skin js 10.17 kB 56.03 kB
/background/skin2 js 159 B —
/live-video/neutral-skin.css css 6.78 kB —
/live-video/skin.css css 6.69 kB —
/live-video/neutral-skin js 50.89 kB 56.03 kB
/live-video/neutral-skin2 js 6.77 kB —
/live-video/skin js 50.83 kB 56.03 kB
/live-video/skin2 js 6.68 kB —
/live-audio/neutral-skin.css css 4.77 kB —
/live-audio/skin.css css 4.67 kB —
/live-audio/neutral-skin js 36.30 kB 56.03 kB
/live-audio/neutral-skin2 js 4.77 kB —
/live-audio/skin js 36.20 kB 56.03 kB
/live-audio/skin2 js 4.66 kB —
/global.css css 239 B —
/shadow.css css 78 B —
UI Components (62)
Entry Initial Lazy
/ui/airplay-button 11.58 kB 56.03 kB
/ui/alert-dialog 8.99 kB 56.03 kB
/ui/audio-track-radio-group 11.67 kB 56.03 kB
/ui/buffering-indicator 8.91 kB 56.03 kB
/ui/captions-button 11.82 kB 56.03 kB
/ui/captions-radio-group 11.73 kB 56.03 kB
/ui/cast-button 11.56 kB 56.03 kB
/ui/container 9.80 kB 56.03 kB
/ui/controls 9.08 kB 56.03 kB
/ui/controls-backdrop 1.69 kB 56.03 kB
/ui/controls-content 1.67 kB 56.03 kB
/ui/dialog 8.93 kB 56.03 kB
/ui/dialog-backdrop 1.70 kB 56.03 kB
/ui/dialog-close 2.06 kB 56.03 kB
/ui/dialog-description 1.69 kB 56.03 kB
/ui/dialog-popup 1.90 kB 56.03 kB
/ui/dialog-title 1.69 kB 56.03 kB
/ui/error-dialog 12.71 kB 56.03 kB
/ui/fullscreen-button 11.56 kB 56.03 kB
/ui/gesture 10.01 kB 56.03 kB
/ui/hotkey 10.42 kB 56.03 kB
/ui/live-button 10.09 kB 56.03 kB
/ui/menu 19.26 kB 56.03 kB
/ui/menu-checkbox-item 1.97 kB 56.03 kB
/ui/menu-content 7.66 kB 56.03 kB
/ui/menu-group 2.09 kB 56.03 kB
/ui/menu-group-label 1.64 kB —
/ui/menu-item 2.29 kB 56.03 kB
/ui/menu-item-indicator 1.38 kB 56.03 kB
/ui/menu-radio-group 3.02 kB 56.03 kB
/ui/menu-radio-item 2.14 kB 56.03 kB
/ui/menu-separator 1.30 kB 56.03 kB
/ui/mute-button 11.59 kB 56.03 kB
/ui/pip-button 11.54 kB 56.03 kB
/ui/play-button 11.52 kB 56.03 kB
/ui/playback-rate-button 11.61 kB 56.03 kB
/ui/playback-rate-radio-group 11.68 kB 56.03 kB
/ui/popover 8.78 kB 56.03 kB
/ui/poster 9.20 kB 56.03 kB
/ui/quality-radio-group 12.19 kB 56.03 kB
/ui/seek-button 11.57 kB 56.03 kB
/ui/seek-indicator 13.40 kB 56.03 kB
/ui/seek-indicator-value 1.10 kB —
/ui/slider 11.92 kB 56.03 kB
/ui/slider-preview 2.01 kB 56.03 kB
/ui/status-announcer 10.93 kB 56.03 kB
/ui/status-indicator 13.35 kB 56.03 kB
/ui/status-indicator-value 1.10 kB —
/ui/thumbnail 10.63 kB 56.03 kB
/ui/time 11.36 kB 56.03 kB
/ui/time-slider 13.45 kB 56.03 kB
/ui/time-slider-chapter-title 9.10 kB 56.03 kB
/ui/time-slider-chapters 9.92 kB 56.03 kB
/ui/title 8.49 kB 56.03 kB
/ui/tooltip 10.15 kB 56.03 kB
/ui/tooltip-label 1.21 kB —
/ui/tooltip-shortcut 1.18 kB —
/ui/volume-indicator 13.31 kB 56.03 kB
/ui/volume-indicator-fill 1.11 kB —
/ui/volume-indicator-value 1.10 kB —
/ui/volume-popover 15.21 kB 56.03 kB
/ui/volume-slider 12.64 kB 56.03 kB
⚛️ @videojs/react — no changes
Presets (7)
Entry Initial Lazy
/video (default) 58.86 kB 56.03 kB
/video (default + hls) 59.50 kB 56.03 kB
/video (neutral) 59.04 kB 56.03 kB
/video (neutral + hls) 59.57 kB 56.03 kB
/audio (default) 45.76 kB 56.03 kB
/audio (neutral) 45.77 kB 56.03 kB
/background 910 B 56.03 kB
Media (22)
Entry Initial
/media/mux-video/hls-js 1.46 kB
/media/mux-video/spf 1.46 kB
/media/mux-audio/hls-js 1.12 kB
/media/mux-audio/spf 1.13 kB
/media/background-video 513 B
/media/cloudflare-video 1.81 kB
/media/dash-video 1.12 kB
/media/hls-audio 22.17 kB
/media/hls-background-video 17.61 kB
/media/hls-video 32.62 kB
/media/hlsjs-video 1.12 kB
/media/mux-audio 1.12 kB
/media/mux-background-video 17.63 kB
/media/mux-video 1.45 kB
/media/native-hls-video 6.18 kB
/media/shaka-video 1.12 kB
/media/spotify-audio 1.88 kB
/media/tiktok-video 1.81 kB
/media/twitch-video 1.83 kB
/media/vimeo-video 1.79 kB
/media/wistia-video 1.42 kB
/media/youtube-video 1.80 kB
Extensions (2)
Entry Initial
/extensions/google-cast 613 B
/extensions/mux-data 665 B
Players (5)
Entry Initial Lazy
/video/player 8.68 kB 56.03 kB
/audio/player 4.90 kB 56.03 kB
/background/player 3.16 kB 56.03 kB
/live-video/player 8.07 kB 56.03 kB
/live-audio/player 4.91 kB 56.03 kB
Skins (18)
Entry Type Initial Lazy
/video/neutral-skin.css css 8.11 kB —
/video/skin.css css 7.81 kB —
/video/neutral-skin js 58.92 kB 56.03 kB
/video/skin js 58.79 kB 56.03 kB
/audio/neutral-skin.css css 5.89 kB —
/audio/skin.css css 5.60 kB —
/audio/neutral-skin js 45.66 kB 56.03 kB
/audio/skin js 45.66 kB 56.03 kB
/background/skin.css css 97 B —
/background/skin js 516 B —
/live-video/neutral-skin.css css 6.60 kB —
/live-video/skin.css css 6.52 kB —
/live-video/neutral-skin js 48.64 kB 56.03 kB
/live-video/skin js 48.68 kB 56.03 kB
/live-audio/neutral-skin.css css 4.58 kB —
/live-audio/skin.css css 4.47 kB —
/live-audio/neutral-skin js 33.86 kB 56.03 kB
/live-audio/skin js 33.86 kB 56.03 kB
UI Components (39)
Entry Initial Lazy
/ui/airplay-button 11.28 kB 56.03 kB
/ui/alert-dialog 5.21 kB 56.03 kB
/ui/audio-track 8.40 kB 56.03 kB
/ui/audio-track-radio-group 10.82 kB 56.03 kB
/ui/buffering-indicator 8.45 kB 56.03 kB
/ui/captions-button 11.26 kB 56.03 kB
/ui/captions-radio-group 10.91 kB 56.03 kB
/ui/cast-button 11.27 kB 56.03 kB
/ui/controls 8.34 kB 56.03 kB
/ui/dialog 5.20 kB 56.03 kB
/ui/error-dialog 12.66 kB 56.03 kB
/ui/fullscreen-button 11.24 kB 56.03 kB
/ui/gesture 8.61 kB 56.03 kB
/ui/hotkey 9.03 kB 56.03 kB
/ui/live-button 9.58 kB 56.03 kB
/ui/menu 22.05 kB 56.03 kB
/ui/mute-button 11.28 kB 56.03 kB
/ui/pip-button 11.24 kB 56.03 kB
/ui/play-button 11.20 kB 56.03 kB
/ui/playback-rate 8.45 kB 56.03 kB
/ui/playback-rate-button 11.20 kB 56.03 kB
/ui/playback-rate-radio-group 10.88 kB 56.03 kB
/ui/popover 9.12 kB 56.03 kB
/ui/poster 8.65 kB 56.03 kB
/ui/quality 8.82 kB 56.03 kB
/ui/quality-radio-group 11.22 kB 56.03 kB
/ui/seek-button 11.24 kB 56.03 kB
/ui/seek-indicator 13.12 kB 56.03 kB
/ui/slider 14.43 kB 56.03 kB
/ui/status-announcer 10.86 kB 56.03 kB
/ui/status-indicator 13.40 kB 56.03 kB
/ui/thumbnail 9.82 kB 56.03 kB
/ui/time 10.66 kB 56.03 kB
/ui/time-slider 16.18 kB 56.03 kB
/ui/title 7.93 kB 56.03 kB
/ui/tooltip 9.98 kB 56.03 kB
/ui/volume-indicator 13.43 kB 56.03 kB
/ui/volume-popover 15.58 kB 56.03 kB
/ui/volume-slider 13.02 kB 56.03 kB
🧩 @videojs/core — no changes
Entries (76)
Entry Initial Lazy
. 13.48 kB —
/dom 23.92 kB 56.03 kB
/vjsc 1.90 kB —
/i18n 3.21 kB 56.03 kB
/i18n/locales/all 33.91 kB —
/i18n/locales/ar 1.16 kB —
/i18n/locales/az 1.08 kB —
/i18n/locales/bg 1.29 kB —
/i18n/locales/bn 1.25 kB —
/i18n/locales/bs 1.02 kB —
/i18n/locales/ca 1.04 kB —
/i18n/locales/cs 1.10 kB —
/i18n/locales/cy 1.02 kB —
/i18n/locales/da 984 B —
/i18n/locales/de 1.06 kB —
/i18n/locales/el 1.42 kB —
/i18n/locales/en 801 B —
/i18n/locales/es 999 B —
/i18n/locales/et 1.02 kB —
/i18n/locales/eu 1.04 kB —
/i18n/locales/fa 1.21 kB —
/i18n/locales/fi 1.05 kB —
/i18n/locales/fr 1.01 kB —
/i18n/locales/gd 1.09 kB —
/i18n/locales/gl 1017 B —
/i18n/locales/he 1.10 kB —
/i18n/locales/hi 1.25 kB —
/i18n/locales/hr 1.05 kB —
/i18n/locales/hu 1.10 kB —
/i18n/locales/id 953 B —
/i18n/locales/it 1.01 kB —
/i18n/locales/ja 1.16 kB —
/i18n/locales/ko 1.08 kB —
/i18n/locales/lt 1.04 kB —
/i18n/locales/lv 1.09 kB —
/i18n/locales/mr 1.23 kB —
/i18n/locales/nb 990 B —
/i18n/locales/ne 1.23 kB —
/i18n/locales/nl 1.01 kB —
/i18n/locales/nn 983 B —
/i18n/locales/oc 1.05 kB —
/i18n/locales/pl 1.11 kB —
/i18n/locales/pt 1.02 kB —
/i18n/locales/pt-BR 1.02 kB —
/i18n/locales/pt-PT 1.02 kB —
/i18n/locales/ro 1.04 kB —
/i18n/locales/ru 1.36 kB —
/i18n/locales/sk 1.10 kB —
/i18n/locales/sl 1.04 kB —
/i18n/locales/sr 1.05 kB —
/i18n/locales/sv 1.01 kB —
/i18n/locales/te 1.29 kB —
/i18n/locales/th 1.20 kB —
/i18n/locales/tr 1.00 kB —
/i18n/locales/uk 1.37 kB —
/i18n/locales/vi 1.10 kB —
/i18n/locales/zh 1.01 kB —
/i18n/locales/zh-CN 1.01 kB —
/i18n/locales/zh-TW 1.02 kB —
/i18n/text/airplay 101 B —
/i18n/text/buttons 137 B —
/i18n/text/captions 93 B —
/i18n/text/cast 114 B —
/i18n/text/common 90 B —
/i18n/text/container 75 B —
/i18n/text/errors 285 B —
/i18n/text/fullscreen 98 B —
/i18n/text/live 126 B —
/i18n/text/menu 249 B —
/i18n/text/pip 101 B —
/i18n/text/playback 80 B —
/i18n/text/seek 105 B —
/i18n/text/slider 65 B —
/i18n/text/status 222 B —
/i18n/text/time 322 B —
/i18n/text/volume 133 B —
🏷️ @videojs/element — no changes
Entries (2)
Entry Initial
. 1.05 kB
/context 943 B
📦 @videojs/store — no changes
Entries (3)
Entry Initial
. 1.85 kB
/html 703 B
/react 511 B
🔧 @videojs/utils — no changes
Entries (13)
Entry Initial
/array 271 B
/dom 5.25 kB
/events 320 B
/function 414 B
/i18n 249 B
/jwt 176 B
/object 535 B
/predicate 297 B
/percent 281 B
/string 239 B
/style 212 B
/time 1018 B
/number 199 B
📦 @videojs/cdn — no changes
📦 @videojs/cloudflare-video — no changes
📦 @videojs/dash-video — no changes
📦 @videojs/google-cast — no changes
📦 @videojs/hlsjs-video — no changes
📦 @videojs/media — no changes
Entries (3)
Entry Initial
. 3.22 kB
/dom 4.00 kB
/media-tracks 2.05 kB
📦 @videojs/mux — no changes
📦 @videojs/mux-audio — no changes
Entries (2)
Entry Initial
. 136.01 kB
/spf 22.76 kB
📦 @videojs/mux-data — no changes
📦 @videojs/mux-video — no changes
Entries (2)
Entry Initial
. 135.92 kB
/spf 32.99 kB
📦 @videojs/native-hls-video — no changes
📦 @videojs/shaka-video — no changes
📦 @videojs/spf — no changes
Entries (7)
Entry Initial
. 4.56 kB
/dom 7.85 kB
/hls 28.40 kB
/media-tracks 507 B
/hls-background-video 16.60 kB
/hls-audio 21.28 kB
/hls-video 31.73 kB
📦 @videojs/spotify-audio — no changes
📦 @videojs/tiktok-video — no changes
📦 @videojs/twitch-video — no changes
📦 @videojs/other — no changes
Entries (3)
Entry Initial Lazy
video.js 74.07 kB 56.03 kB
video.js/package.json 608 B —
video.js/errors 1.03 kB —
📦 @videojs/vimeo-video — no changes
📦 @videojs/wistia-video — no changes
Entries (2)
Entry Initial
. 1.91 kB
/helpers 1.76 kB
📦 @videojs/youtube-video — no changes

ℹ️ How to interpret

Each entry is independently bundled, minified, and brotli-compressed. Initial size includes its static import graph; lazy dynamic chunks are reported separately.

Entries are not additive because their dependency graphs overlap. Preset rows represent realistic combined bundles.

Changes of 300 B or less across initial, lazy, and total size are collapsed, not discarded.

Run pnpm size locally to check current initial sizes.

… vite apps

create-vite 9.2 moved its demo images into src/assets and added a
public/icons.svg sprite, so new Vite apps kept unused starter files after
the player replaced the demo page. List the current files for every Vite
framework.
@mihar-22

Copy link
Copy Markdown
Member Author

Moved to videojs/video.js#9469

@mihar-22 mihar-22 closed this Oct 12, 2026

This branch was successfully deployed

1 active deployment
Preview — 973d53c9 Deployed Oct 1, 2026 by vercel[bot]
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: Agents Init Leaves Create-Vite 9.2 Starter Files Behind in New Vite HTML Apps

1 participant