This repository was archived by the owner on Oct 21, 2026. It is now read-only.
Repository navigation
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
✅ Deploy Preview for vjs10-site ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for vjs-registry canceled.
|
@videojs/cdn
@videojs/cli
@videojs/core
@videojs/element
@videojs/html
@videojs/media
@videojs/react
@videojs/spf
@videojs/store
@videojs/utils
@videojs/cloudflare-video
@videojs/dash-video
@videojs/hlsjs-video
@videojs/mux-audio
@videojs/mux-video
@videojs/native-hls-video
@videojs/shaka-video
@videojs/spotify-audio
@videojs/tiktok-video
@videojs/twitch-video
@videojs/vimeo-video
@videojs/wistia-video
@videojs/youtube-video
@videojs/google-cast
@videojs/mux-data
commit: |
Contributor
📦 Bundle Size Report🎨 @videojs/html — no changesPresets (7)
Media (18)
Players (5)
Skins (29)
UI Components (62)
⚛️ @videojs/react — no changesPresets (7)
Media (22)
Extensions (2)
Players (5)
Skins (18)
UI Components (39)
🧩 @videojs/core — no changesEntries (76)
🏷️ @videojs/element — no changesEntries (2)
📦 @videojs/store — no changesEntries (3)
🔧 @videojs/utils — no changesEntries (13)
📦 @videojs/cdn — no changes📦 @videojs/cloudflare-video — no changes📦 @videojs/dash-video — no changes📦 @videojs/google-cast — no changes📦 @videojs/hlsjs-video — no changes📦 @videojs/media — no changesEntries (3)
📦 @videojs/mux — no changes📦 @videojs/mux-audio — no changesEntries (2)
📦 @videojs/mux-data — no changes📦 @videojs/mux-video — no changesEntries (2)
📦 @videojs/native-hls-video — no changes📦 @videojs/shaka-video — no changes📦 @videojs/spf — no changesEntries (7)
📦 @videojs/spotify-audio — no changes📦 @videojs/tiktok-video — no changes📦 @videojs/twitch-video — no changes📦 @videojs/other — no changesEntries (3)
📦 @videojs/vimeo-video — no changes📦 @videojs/wistia-video — no changesEntries (2)
📦 @videojs/youtube-video — no changesℹ️ How to interpretEach entry is independently bundled, minified, and brotli-compressed. Initial size includes its static import graph; lazy dynamic chunks are reported separately. Entries are not additive because their dependency graphs overlap. Preset rows represent realistic combined bundles. Changes of 300 B or less across initial, lazy, and total size are collapsed, not discarded. Run |
… vite apps create-vite 9.2 moved its demo images into src/assets and added a public/icons.svg sprite, so new Vite apps kept unused starter files after the player replaced the demo page. List the current files for every Vite framework.
mihar-22
force-pushed
the
fix/3001-vite-starter-files
branch
from
October 1, 2026 19:49
023cb4f to
973d53c
Compare
Member
Author
|
Moved to videojs/video.js#9469 |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes videojs/video.js#9411
Summary
create-vite 9.2 moved its demo images into
src/assets/and added apublic/icons.svgsprite. Theagents initplan for a new Vite app still deleted the oldsrc/typescript.svg, so the new starter assets stayed behind, unused, once the player replaced the demo page. The same happened in React, Vue, and Svelte Vite apps, not only plain HTML.Changes
vanilla-ts,react-ts,vue-ts, andsvelte-tstemplates: the demo page and its images (src/assets/hero.png,src/assets/vite.svg, the framework logo) andpublic/icons.svg.public/favicon.svgstays, because the starterindex.htmlstill links to it.Testing
pnpm -F @videojs/installation testcreate-vite@9.2.1template package and checked which ones the replaced demo pages import. The stylesheets that remain import no assets.This is the base of a stack: #3102 → #3103 → #3104 → #3106 → #3107. The Video.js 8 skill change is in videojs/skills#14.
🤖 Generated with Claude Code
Note
Low Risk
Scoped to Vite new-app file cleanup lists and test expectations; no auth, runtime player, or install command behavior changes beyond which starter files get deleted.
Overview
Updates
installationStarterFilessoagents initremoves the unused create-vite 9.2 demo leftovers when it replaces the starter page in new Vite apps (HTML, React, Vue, Svelte).Besides the existing demo scripts/styles/components, the removal list now includes shared assets (
src/assets/hero.png,src/assets/vite.svg,public/icons.svg) and each template’s framework logo undersrc/assets/. Plain HTML also dropssrc/typescript.svgin favor ofsrc/assets/typescript.svg.public/favicon.svgis intentionally not removed because the generatedindex.htmlstill references it.Tests assert the full per-framework lists, the favicon exclusion, and wire integration expectations to
installationStarterFilesinstead of hard-coded paths.Reviewed by Cursor Bugbot for commit 973d53c. Bugbot is set up for automated code reviews on this repo. Configure here.