This repository was archived by the owner on Oct 21, 2026. It is now read-only.
Repository navigation
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This was referenced Oct 1, 2026
@videojs/cdn
@videojs/cli
@videojs/core
@videojs/element
@videojs/html
@videojs/media
@videojs/react
@videojs/spf
@videojs/store
@videojs/utils
@videojs/cloudflare-video
@videojs/dash-video
@videojs/hlsjs-video
@videojs/mux-audio
@videojs/mux-video
@videojs/native-hls-video
@videojs/shaka-video
@videojs/spotify-audio
@videojs/tiktok-video
@videojs/twitch-video
@videojs/vimeo-video
@videojs/wistia-video
@videojs/youtube-video
@videojs/google-cast
@videojs/mux-data
commit: |
✅ Deploy Preview for vjs10-site ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
📦 Bundle Size Report🎨 @videojs/html — no changesPresets (7)
Media (18)
Players (5)
Skins (29)
UI Components (62)
⚛️ @videojs/react — no changesPresets (7)
Media (22)
Extensions (2)
Players (5)
Skins (18)
UI Components (39)
🧩 @videojs/core — no changesEntries (76)
🏷️ @videojs/element — no changesEntries (2)
📦 @videojs/store — no changesEntries (3)
🔧 @videojs/utils — no changesEntries (13)
📦 @videojs/cdn — no changes📦 @videojs/cloudflare-video — no changes📦 @videojs/dash-video — no changes📦 @videojs/google-cast — no changes📦 @videojs/hlsjs-video — no changes📦 @videojs/media — no changesEntries (3)
📦 @videojs/mux — no changes📦 @videojs/mux-audio — no changesEntries (2)
📦 @videojs/mux-data — no changes📦 @videojs/mux-video — no changesEntries (2)
📦 @videojs/native-hls-video — no changes📦 @videojs/shaka-video — no changes📦 @videojs/spf — no changesEntries (7)
📦 @videojs/spotify-audio — no changes📦 @videojs/tiktok-video — no changes📦 @videojs/twitch-video — no changes📦 @videojs/other — no changesEntries (3)
📦 @videojs/vimeo-video — no changes📦 @videojs/wistia-video — no changesEntries (2)
📦 @videojs/youtube-video — no changesℹ️ How to interpretEach entry is independently bundled, minified, and brotli-compressed. Initial size includes its static import graph; lazy dynamic chunks are reported separately. Entries are not additive because their dependency graphs overlap. Preset rows represent realistic combined bundles. Changes of 300 B or less across initial, lazy, and total size are collapsed, not discarded. Run |
✅ Deploy Preview for vjs-registry ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
The SvelteKit starter compiles every component in Svelte 5 runes mode,
which deprecates `<slot />`. Render the media passed to the player
component with `{@render children?.()}`, which also works in the
create-vite and Astro Svelte setups.
mihar-22
force-pushed
the
fix/3000-svelte-runes-children
branch
from
October 1, 2026 19:49
8f4c71f to
a101b7a
Compare
luwes
approved these changes
Oct 6, 2026
Member
Author
|
Moved to videojs/video.js#9470 |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes videojs/video.js#9412
Summary
The Svelte player component that
agents initand the Svelte installation guide generate rendered its media with<slot />. The SvelteKit starter compiles every component in Svelte 5 runes mode, where<slot />is deprecated and triggers a compiler warning. The component now takes achildrensnippet and renders it with{@render children?.()}.Changes
let { children }: { children?: Snippet } = $props();and renders{@render children?.()}where the media goes.childrentoo (@astrojs/svelte9).Testing
pnpm -F @videojs/installation test+page.sveltefor all five presets withsvelte@5.57.1, in forced runes mode and default mode. There were no warnings. The previous output reportsslot_element_deprecatedin runes mode.Stacked on #3102.
🤖 Generated with Claude Code
Note
Low Risk
Codegen-only change for Svelte starter output; no runtime library or auth/data paths affected.
Overview
Updates generated Svelte player output from the installation package (
agents init, Svelte guide) so it compiles cleanly under Svelte 5 runes mode, where<slot />is deprecated.Instead of a default slot, the generated component declares an optional
childrenSnippet via$props()and places media with{@render children?.()}. Usage examples are unchanged—callers still nest the media element between the player tags; SvelteKit/Astro pass that content aschildren.Tests now assert the Snippet/
$props/{@render}pattern and that no<slotremains in generated player code.Reviewed by Cursor Bugbot for commit a101b7a. Bugbot is set up for automated code reviews on this repo. Configure here.