Skip to content
This repository was archived by the owner on Oct 21, 2026. It is now read-only.

refactor(react)!: export compound radio groups from the package root - #3073

Merged
decepulis merged 10 commits into
mainfrom
claude/keen-mccarthy-7ams8m-radio-groups
Oct 1, 2026
Merged

decepulis merged 10 commits into
mainfrom
claude/keen-mccarthy-7ams8m-radio-groups

Conversation

@decepulis

@decepulis decepulis commented Sep 30, 2026 •

Copy link
Copy Markdown
Collaborator

Part 1 of the API stability stack: this PR → #3063 (checker) → #3066 (docs rewrites) → #3067 (reference pages) → #3082 (exports) → #3068 (tags and CI) → #3083 (store). It's at the bottom so it merges first; the later PRs are tagged against it.

Summary

The four menu radio groups have two different APIs under the same name:

  • @videojs/react/ui/<name> exports the compound component (AudioTrackRadioGroup.Root, .Options, .Value). The docs and skins use this one.
  • The @videojs/react root exports *RadioGroupLegacy, an @internal single-component shim. Its comment says it's a "compatibility adapter for the existing preset sources".

This PR removes the shims so the root exports the same compound namespaces as the subpaths, like every other compound component.

  • Deletes AudioTrackRadioGroupLegacy, CaptionsRadioGroupLegacy, PlaybackRateRadioGroupLegacy and QualityRadioGroupLegacy, and their *LegacyProps types.
  • packages/react/src/index.ts now exports the namespaces. This matches the Menu/Dialog family, which exports no flat *Props types from the root.
  • The four reference pages drop the "compatibility component" note, and their Import sections and React demos now import from @videojs/react instead of the ui/* subpath.
  • A test checks that the root namespaces expose the same parts as the subpaths.

Found while working on the checker in #3063, where a documented name was being published through an @internal declaration.

Preview pages

The changes are on the React versions (the Import section, the removed note and the demo):

  • Audio track radio group: React
  • Captions radio group: React
  • Playback rate radio group: React
  • Quality radio group: React

Breaking change

Importing AudioTrackRadioGroup, CaptionsRadioGroup, PlaybackRateRadioGroup or QualityRadioGroup from @videojs/react now gives the compound namespace. The shim split its props between two parts, so migrate them the same way:

  • label, the format* props and disabled go on .Root, which renders no element.
  • Everything else, including className, style, render, aria-*, renderItem and ref, goes on .Options.
// Before
<CaptionsRadioGroup label="Captions" disabled={disabled} className="menu" ref={ref} renderItem={renderItem} />

// After
<CaptionsRadioGroup.Root label="Captions" disabled={disabled}>
  <CaptionsRadioGroup.Options className="menu" ref={ref} renderItem={renderItem} />
</CaptionsRadioGroup.Root>

To let a menu trigger read the group's state, wrap the Menu.Trigger and Menu.Content in .Root too.

Nothing in the repo used the shims. Skins, demos, sandbox templates, e2e and installation already use the parts. The hook tests that render components with these names define their own local helpers. HTML has no equivalent shim.

Testing

  • pnpm build:packages
  • pnpm -F @videojs/react test: 599 passed, plus the new root export test
  • pnpm typecheck
  • pnpm lint
  • Skins tests: 76 of 77 passed. build/tests/vite.test.ts times out, and it also times out on unmodified main.

🤖 Generated with Claude Code

https://claude.ai/code/session_01WLkDiofiR86hzNgRopBotH


Note

Medium Risk
Public breaking API change for root imports; behavior of the compound parts is unchanged, but downstream apps using the removed legacy shims must migrate.

Overview
Breaking: @videojs/react now exports the compound AudioTrackRadioGroup, CaptionsRadioGroup, PlaybackRateRadioGroup, and QualityRadioGroup namespaces (.Root, .Options, .Value) from the package root, aligned with Menu/Dialog and the ui/* subpaths.

The internal single-component *Legacy adapters and *LegacyProps types are removed. Consumers who imported the flat components from the root must split props onto .Root (e.g. label, format*, disabled) and .Options (e.g. renderItem, className, ref).

Docs and React demos import from @videojs/react instead of deep ui/* paths, compatibility notes are dropped, and a test asserts root exports match the subpath parts.

Reviewed by Cursor Bugbot for commit cd3b8dd. Bugbot is set up for automated code reviews on this repo. Configure here.

Remove the single-component compatibility shims (`AudioTrackRadioGroupLegacy`,
`CaptionsRadioGroupLegacy`, `PlaybackRateRadioGroupLegacy`,
`QualityRadioGroupLegacy`) and their props types. The `@videojs/react` root now
exports the same compound namespaces as the `@videojs/react/ui/*` subpaths, and
the reference pages drop the compatibility note.

BREAKING CHANGE: `AudioTrackRadioGroup`, `CaptionsRadioGroup`,
`PlaybackRateRadioGroup`, and `QualityRadioGroup` imported from `@videojs/react`
are now compound namespaces instead of single components. Replace
`<XRadioGroup {...options} renderItem={...} />` with
`<XRadioGroup.Root {...options}><XRadioGroup.Options renderItem={...} /></XRadioGroup.Root>`.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01WLkDiofiR86hzNgRopBotH
@netlify

netlify Bot commented Sep 30, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for vjs10-site ready!

Name Link
🔨 Latest commit cd3b8dd
🔍 Latest deploy log https://app.netlify.com/projects/vjs10-site/deploys/6abecd02503e2a000804a4a6
😎 Deploy Preview https://deploy-preview-3073--vjs10-site.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@vercel

vercel Bot commented Sep 30, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
v10-sandbox Ready Ready Preview Oct 1, 2026 9:15pm UTC

Request Review

@netlify

netlify Bot commented Sep 30, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for vjs-registry ready!

Name Link
🔨 Latest commit cd3b8dd
🔍 Latest deploy log https://app.netlify.com/projects/vjs-registry/deploys/6abecd02f4fba400089993f1
😎 Deploy Preview https://deploy-preview-3073--vjs-registry.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@pkg-pr-new

pkg-pr-new Bot commented Sep 30, 2026 •

Copy link
Copy Markdown
@videojs/cdn

pnpm add https://pkg.pr.new/@videojs/cdn@3073

@videojs/cli

pnpm add https://pkg.pr.new/@videojs/cli@3073

@videojs/core

pnpm add https://pkg.pr.new/@videojs/core@3073

@videojs/element

pnpm add https://pkg.pr.new/@videojs/element@3073

@videojs/html

pnpm add https://pkg.pr.new/@videojs/html@3073

@videojs/media

pnpm add https://pkg.pr.new/@videojs/media@3073

@videojs/react

pnpm add https://pkg.pr.new/@videojs/react@3073

@videojs/spf

pnpm add https://pkg.pr.new/@videojs/spf@3073

@videojs/store

pnpm add https://pkg.pr.new/@videojs/store@3073

@videojs/utils

pnpm add https://pkg.pr.new/@videojs/utils@3073

@videojs/cloudflare-video

pnpm add https://pkg.pr.new/@videojs/cloudflare-video@3073

@videojs/dash-video

pnpm add https://pkg.pr.new/@videojs/dash-video@3073

@videojs/hlsjs-video

pnpm add https://pkg.pr.new/@videojs/hlsjs-video@3073

@videojs/mux-audio

pnpm add https://pkg.pr.new/@videojs/mux-audio@3073

@videojs/mux-video

pnpm add https://pkg.pr.new/@videojs/mux-video@3073

@videojs/native-hls-video

pnpm add https://pkg.pr.new/@videojs/native-hls-video@3073

@videojs/shaka-video

pnpm add https://pkg.pr.new/@videojs/shaka-video@3073

@videojs/spotify-audio

pnpm add https://pkg.pr.new/@videojs/spotify-audio@3073

@videojs/tiktok-video

pnpm add https://pkg.pr.new/@videojs/tiktok-video@3073

@videojs/twitch-video

pnpm add https://pkg.pr.new/@videojs/twitch-video@3073

@videojs/vimeo-video

pnpm add https://pkg.pr.new/@videojs/vimeo-video@3073

@videojs/wistia-video

pnpm add https://pkg.pr.new/@videojs/wistia-video@3073

@videojs/youtube-video

pnpm add https://pkg.pr.new/@videojs/youtube-video@3073

@videojs/google-cast

pnpm add https://pkg.pr.new/@videojs/google-cast@3073

@videojs/mux-data

pnpm add https://pkg.pr.new/@videojs/mux-data@3073

commit: 7127458

@github-actions

github-actions Bot commented Sep 30, 2026 •

Copy link
Copy Markdown
Contributor

📦 Bundle Size Report

🎨 @videojs/html — no changes
Presets (7)
Entry Initial Lazy
/video (default) 65.26 kB 56.03 kB
/video (default + hls) 67.12 kB 56.03 kB
/video (neutral) 65.75 kB 56.03 kB
/video (neutral + hls) 67.52 kB 56.03 kB
/audio (default) 49.09 kB 56.03 kB
/audio (neutral) 49.45 kB 56.03 kB
/background 12.76 kB 56.03 kB
Media (18)
Entry Initial
/media/mux-video 3.03 kB
/media/mux-audio 2.71 kB
/media/background-video 1.17 kB
/media/cloudflare-video 2.91 kB
/media/dash-video 2.63 kB
/media/hls-audio 23.54 kB
/media/hls-background-video 17.56 kB
/media/hls-video 33.95 kB
/media/hlsjs-video 2.64 kB
/media/mux-background-video 17.58 kB
/media/native-hls-video 7.54 kB
/media/shaka-video 2.64 kB
/media/spotify-audio 3.03 kB
/media/tiktok-video 3.14 kB
/media/twitch-video 2.94 kB
/media/vimeo-video 2.92 kB
/media/wistia-video 615 B
/media/youtube-video 2.91 kB
Players (5)
Entry Initial Lazy
/video/player 10.85 kB 56.03 kB
/audio/player 7.05 kB 56.03 kB
/background/player 5.34 kB 56.03 kB
/live-video/player 10.23 kB 56.03 kB
/live-audio/player 7.06 kB 56.03 kB
Skins (41)
Entry Type Initial Lazy
/video/compat-skin.css css 7.48 kB —
/video/neutral-skin.css css 8.33 kB —
/video/skin.css css 8.05 kB —
/video/compat-skin js 62.40 kB 56.03 kB
/video/compat-skin2 js 7.45 kB —
/video/neutral-skin js 63.28 kB 56.03 kB
/video/neutral-skin2 js 8.32 kB —
/video/skin js 62.92 kB 56.03 kB
/video/skin2 js 8.02 kB —
/audio/compat-skin.css css 6.13 kB —
/audio/neutral-skin.css css 6.07 kB —
/audio/skin.css css 5.80 kB —
/audio/compat-skin js 53.92 kB 56.03 kB
/audio/compat-skin2 js 6.13 kB —
/audio/neutral-skin js 47.06 kB 56.03 kB
/audio/neutral-skin2 js 6.05 kB —
/audio/skin js 46.78 kB 56.03 kB
/audio/skin2 js 5.78 kB —
/background/skin.css css 141 B —
/background/skin js 10.18 kB 56.03 kB
/background/skin2 js 159 B —
/live-video/compat-skin.css css 6.92 kB —
/live-video/neutral-skin.css css 6.82 kB —
/live-video/skin.css css 6.72 kB —
/live-video/compat-skin js 53.70 kB 56.03 kB
/live-video/compat-skin2 js 6.91 kB —
/live-video/neutral-skin js 50.90 kB 56.03 kB
/live-video/neutral-skin2 js 6.82 kB —
/live-video/skin js 50.90 kB 56.03 kB
/live-video/skin2 js 6.72 kB —
/live-audio/compat-skin.css css 5.63 kB —
/live-audio/neutral-skin.css css 4.77 kB —
/live-audio/skin.css css 4.67 kB —
/live-audio/compat-skin js 40.87 kB 56.03 kB
/live-audio/compat-skin2 js 5.64 kB —
/live-audio/neutral-skin js 36.28 kB 56.03 kB
/live-audio/neutral-skin2 js 4.77 kB —
/live-audio/skin js 36.21 kB 56.03 kB
/live-audio/skin2 js 4.66 kB —
/global.css css 239 B —
/shadow.css css 78 B —
UI Components (62)
Entry Initial Lazy
/ui/airplay-button 11.57 kB 56.03 kB
/ui/alert-dialog 8.99 kB 56.03 kB
/ui/audio-track-radio-group 11.68 kB 56.03 kB
/ui/buffering-indicator 8.91 kB 56.03 kB
/ui/captions-button 11.83 kB 56.03 kB
/ui/captions-radio-group 11.73 kB 56.03 kB
/ui/cast-button 11.56 kB 56.03 kB
/ui/container 9.79 kB 56.03 kB
/ui/controls 9.10 kB 56.03 kB
/ui/controls-backdrop 1.69 kB 56.03 kB
/ui/controls-content 1.67 kB 56.03 kB
/ui/dialog 8.92 kB 56.03 kB
/ui/dialog-backdrop 1.70 kB 56.03 kB
/ui/dialog-close 2.06 kB 56.03 kB
/ui/dialog-description 1.69 kB 56.03 kB
/ui/dialog-popup 1.90 kB 56.03 kB
/ui/dialog-title 1.69 kB 56.03 kB
/ui/error-dialog 12.69 kB 56.03 kB
/ui/fullscreen-button 11.57 kB 56.03 kB
/ui/gesture 10.01 kB 56.03 kB
/ui/hotkey 10.40 kB 56.03 kB
/ui/live-button 10.09 kB 56.03 kB
/ui/menu 19.25 kB 56.03 kB
/ui/menu-checkbox-item 1.97 kB 56.03 kB
/ui/menu-content 7.65 kB 56.03 kB
/ui/menu-group 2.09 kB 56.03 kB
/ui/menu-group-label 1.64 kB —
/ui/menu-item 2.29 kB 56.03 kB
/ui/menu-item-indicator 1.38 kB 56.03 kB
/ui/menu-radio-group 3.03 kB 56.03 kB
/ui/menu-radio-item 2.14 kB 56.03 kB
/ui/menu-separator 1.30 kB 56.03 kB
/ui/mute-button 11.59 kB 56.03 kB
/ui/pip-button 11.54 kB 56.03 kB
/ui/play-button 11.53 kB 56.03 kB
/ui/playback-rate-button 11.63 kB 56.03 kB
/ui/playback-rate-radio-group 11.69 kB 56.03 kB
/ui/popover 8.77 kB 56.03 kB
/ui/poster 9.21 kB 56.03 kB
/ui/quality-radio-group 12.18 kB 56.03 kB
/ui/seek-button 11.58 kB 56.03 kB
/ui/seek-indicator 13.39 kB 56.03 kB
/ui/seek-indicator-value 1.10 kB —
/ui/slider 11.94 kB 56.03 kB
/ui/slider-preview 2.01 kB 56.03 kB
/ui/status-announcer 10.94 kB 56.03 kB
/ui/status-indicator 13.34 kB 56.03 kB
/ui/status-indicator-value 1.10 kB —
/ui/thumbnail 10.64 kB 56.03 kB
/ui/time 11.36 kB 56.03 kB
/ui/time-slider 13.44 kB 56.03 kB
/ui/time-slider-chapter-title 9.10 kB 56.03 kB
/ui/time-slider-chapters 9.92 kB 56.03 kB
/ui/title 8.48 kB 56.03 kB
/ui/tooltip 10.15 kB 56.03 kB
/ui/tooltip-label 1.21 kB —
/ui/tooltip-shortcut 1.18 kB —
/ui/volume-indicator 13.31 kB 56.03 kB
/ui/volume-indicator-fill 1.11 kB —
/ui/volume-indicator-value 1.10 kB —
/ui/volume-popover 15.21 kB 56.03 kB
/ui/volume-slider 12.65 kB 56.03 kB
⚛️ @videojs/react — 19 small size changes
Path Base initial PR initial Initial diff Lazy diff
/video/compat-skin 59.69 kB 59.66 kB -34 B (-0.1%) 0 B
/video/neutral-skin 58.92 kB 58.66 kB -270 B (-0.4%) 0 B
/video/skin 58.79 kB 58.72 kB -73 B (-0.1%) 0 B
/audio/compat-skin 50.73 kB 50.66 kB -79 B (-0.2%) 0 B
/audio/neutral-skin 45.64 kB 45.57 kB -70 B (-0.1%) 0 B
/audio/skin 45.61 kB 45.58 kB -34 B (-0.1%) 0 B
/live-video/compat-skin 55.61 kB 55.54 kB -80 B (-0.1%) 0 B
/live-video/neutral-skin 48.68 kB 48.55 kB -137 B (-0.3%) 0 B
/live-video/skin 48.76 kB 48.59 kB -173 B (-0.3%) 0 B
/ui/audio-track-radio-group 10.82 kB 10.74 kB -91 B (-0.8%) 0 B
/ui/captions-radio-group 10.91 kB 10.81 kB -101 B (-0.9%) 0 B
/ui/playback-rate-radio-group 10.88 kB 10.81 kB -76 B (-0.7%) 0 B
/ui/quality-radio-group 11.22 kB 11.15 kB -68 B (-0.6%) 0 B
/video (default) 58.92 kB 58.75 kB -182 B (-0.3%) 0 B
/video (default + hls) 59.36 kB 59.36 kB -3 B (-0.0%) 0 B
/video (neutral) 59.05 kB 58.80 kB -253 B (-0.4%) 0 B
/video (neutral + hls) 59.55 kB 59.38 kB -165 B (-0.3%) 0 B
/audio (default) 45.75 kB 45.78 kB +24 B (+0.1%) 0 B
/audio (neutral) 45.83 kB 45.67 kB -159 B (-0.3%) 0 B
Presets (7)
Entry Initial Lazy
/video (default) 58.75 kB 56.03 kB
/video (default + hls) 59.36 kB 56.03 kB
/video (neutral) 58.80 kB 56.03 kB
/video (neutral + hls) 59.38 kB 56.03 kB
/audio (default) 45.78 kB 56.03 kB
/audio (neutral) 45.67 kB 56.03 kB
/background 921 B 56.03 kB
Media (22)
Entry Initial
/media/mux-video/hls-js 1.47 kB
/media/mux-video/spf 1.47 kB
/media/mux-audio/hls-js 1.15 kB
/media/mux-audio/spf 1.14 kB
/media/background-video 532 B
/media/cloudflare-video 1.88 kB
/media/dash-video 1.13 kB
/media/hls-audio 22.20 kB
/media/hls-background-video 17.60 kB
/media/hls-video 32.64 kB
/media/hlsjs-video 1.13 kB
/media/mux-audio 1.13 kB
/media/mux-background-video 17.63 kB
/media/mux-video 1.46 kB
/media/native-hls-video 6.19 kB
/media/shaka-video 1.13 kB
/media/spotify-audio 1.94 kB
/media/tiktok-video 1.88 kB
/media/twitch-video 1.89 kB
/media/vimeo-video 1.85 kB
/media/wistia-video 1.42 kB
/media/youtube-video 1.86 kB
Extensions (2)
Entry Initial
/extensions/google-cast 613 B
/extensions/mux-data 665 B
Players (5)
Entry Initial Lazy
/video/player 8.68 kB 56.03 kB
/audio/player 4.90 kB 56.03 kB
/background/player 3.16 kB 56.03 kB
/live-video/player 8.07 kB 56.03 kB
/live-audio/player 4.91 kB 56.03 kB
Skins (26)
Entry Type Initial Lazy
/video/compat-skin.css css 7.35 kB —
/video/neutral-skin.css css 8.16 kB —
/video/skin.css css 7.86 kB —
/video/compat-skin js 59.66 kB 56.03 kB
/video/neutral-skin js 58.66 kB 56.03 kB
/video/skin js 58.72 kB 56.03 kB
/audio/compat-skin.css css 5.97 kB —
/audio/neutral-skin.css css 5.89 kB —
/audio/skin.css css 5.60 kB —
/audio/compat-skin js 50.66 kB 56.03 kB
/audio/neutral-skin js 45.57 kB 56.03 kB
/audio/skin js 45.58 kB 56.03 kB
/background/skin.css css 97 B —
/background/skin js 516 B —
/live-video/compat-skin.css css 6.81 kB —
/live-video/neutral-skin.css css 6.65 kB —
/live-video/skin.css css 6.55 kB —
/live-video/compat-skin js 55.54 kB 56.03 kB
/live-video/neutral-skin js 48.55 kB 56.03 kB
/live-video/skin js 48.59 kB 56.03 kB
/live-audio/compat-skin.css css 5.48 kB —
/live-audio/neutral-skin.css css 4.58 kB —
/live-audio/skin.css css 4.47 kB —
/live-audio/compat-skin js 41.85 kB 56.03 kB
/live-audio/neutral-skin js 33.86 kB 56.03 kB
/live-audio/skin js 33.86 kB 56.03 kB
UI Components (39)
Entry Initial Lazy
/ui/airplay-button 11.28 kB 56.03 kB
/ui/alert-dialog 5.21 kB 56.03 kB
/ui/audio-track 8.40 kB 56.03 kB
/ui/audio-track-radio-group 10.74 kB 56.03 kB
/ui/buffering-indicator 8.45 kB 56.03 kB
/ui/captions-button 11.26 kB 56.03 kB
/ui/captions-radio-group 10.81 kB 56.03 kB
/ui/cast-button 11.27 kB 56.03 kB
/ui/controls 8.34 kB 56.03 kB
/ui/dialog 5.20 kB 56.03 kB
/ui/error-dialog 12.66 kB 56.03 kB
/ui/fullscreen-button 11.24 kB 56.03 kB
/ui/gesture 8.61 kB 56.03 kB
/ui/hotkey 9.03 kB 56.03 kB
/ui/live-button 9.58 kB 56.03 kB
/ui/menu 22.05 kB 56.03 kB
/ui/mute-button 11.28 kB 56.03 kB
/ui/pip-button 11.24 kB 56.03 kB
/ui/play-button 11.20 kB 56.03 kB
/ui/playback-rate 8.45 kB 56.03 kB
/ui/playback-rate-button 11.20 kB 56.03 kB
/ui/playback-rate-radio-group 10.81 kB 56.03 kB
/ui/popover 9.12 kB 56.03 kB
/ui/poster 8.65 kB 56.03 kB
/ui/quality 8.82 kB 56.03 kB
/ui/quality-radio-group 11.15 kB 56.03 kB
/ui/seek-button 11.24 kB 56.03 kB
/ui/seek-indicator 13.12 kB 56.03 kB
/ui/slider 14.43 kB 56.03 kB
/ui/status-announcer 10.86 kB 56.03 kB
/ui/status-indicator 13.40 kB 56.03 kB
/ui/thumbnail 9.82 kB 56.03 kB
/ui/time 10.66 kB 56.03 kB
/ui/time-slider 16.18 kB 56.03 kB
/ui/title 7.93 kB 56.03 kB
/ui/tooltip 9.98 kB 56.03 kB
/ui/volume-indicator 13.43 kB 56.03 kB
/ui/volume-popover 15.58 kB 56.03 kB
/ui/volume-slider 13.02 kB 56.03 kB
🧩 @videojs/core — no changes
Entries (76)
Entry Initial Lazy
. 13.48 kB —
/dom 23.92 kB 56.03 kB
/vjsc 1.90 kB —
/i18n 3.21 kB 56.03 kB
/i18n/locales/all 33.91 kB —
/i18n/locales/ar 1.16 kB —
/i18n/locales/az 1.08 kB —
/i18n/locales/bg 1.29 kB —
/i18n/locales/bn 1.25 kB —
/i18n/locales/bs 1.02 kB —
/i18n/locales/ca 1.04 kB —
/i18n/locales/cs 1.10 kB —
/i18n/locales/cy 1.02 kB —
/i18n/locales/da 984 B —
/i18n/locales/de 1.06 kB —
/i18n/locales/el 1.42 kB —
/i18n/locales/en 801 B —
/i18n/locales/es 999 B —
/i18n/locales/et 1.02 kB —
/i18n/locales/eu 1.04 kB —
/i18n/locales/fa 1.21 kB —
/i18n/locales/fi 1.05 kB —
/i18n/locales/fr 1.01 kB —
/i18n/locales/gd 1.09 kB —
/i18n/locales/gl 1017 B —
/i18n/locales/he 1.10 kB —
/i18n/locales/hi 1.25 kB —
/i18n/locales/hr 1.05 kB —
/i18n/locales/hu 1.10 kB —
/i18n/locales/id 953 B —
/i18n/locales/it 1.01 kB —
/i18n/locales/ja 1.16 kB —
/i18n/locales/ko 1.08 kB —
/i18n/locales/lt 1.04 kB —
/i18n/locales/lv 1.09 kB —
/i18n/locales/mr 1.23 kB —
/i18n/locales/nb 990 B —
/i18n/locales/ne 1.23 kB —
/i18n/locales/nl 1.01 kB —
/i18n/locales/nn 983 B —
/i18n/locales/oc 1.05 kB —
/i18n/locales/pl 1.11 kB —
/i18n/locales/pt 1.02 kB —
/i18n/locales/pt-BR 1.02 kB —
/i18n/locales/pt-PT 1.02 kB —
/i18n/locales/ro 1.04 kB —
/i18n/locales/ru 1.36 kB —
/i18n/locales/sk 1.10 kB —
/i18n/locales/sl 1.04 kB —
/i18n/locales/sr 1.05 kB —
/i18n/locales/sv 1.01 kB —
/i18n/locales/te 1.29 kB —
/i18n/locales/th 1.20 kB —
/i18n/locales/tr 1.00 kB —
/i18n/locales/uk 1.37 kB —
/i18n/locales/vi 1.10 kB —
/i18n/locales/zh 1.01 kB —
/i18n/locales/zh-CN 1.01 kB —
/i18n/locales/zh-TW 1.02 kB —
/i18n/text/airplay 101 B —
/i18n/text/buttons 137 B —
/i18n/text/captions 93 B —
/i18n/text/cast 114 B —
/i18n/text/common 90 B —
/i18n/text/container 75 B —
/i18n/text/errors 285 B —
/i18n/text/fullscreen 98 B —
/i18n/text/live 126 B —
/i18n/text/menu 249 B —
/i18n/text/pip 101 B —
/i18n/text/playback 80 B —
/i18n/text/seek 105 B —
/i18n/text/slider 65 B —
/i18n/text/status 222 B —
/i18n/text/time 322 B —
/i18n/text/volume 133 B —
🏷️ @videojs/element — no changes
Entries (2)
Entry Initial
. 1.05 kB
/context 1.15 kB
📦 @videojs/store — no changes
Entries (3)
Entry Initial
. 1.85 kB
/html 703 B
/react 511 B
🔧 @videojs/utils — no changes
Entries (13)
Entry Initial
/array 271 B
/dom 5.25 kB
/events 320 B
/function 414 B
/i18n 249 B
/jwt 176 B
/object 535 B
/predicate 297 B
/percent 281 B
/string 239 B
/style 212 B
/time 1018 B
/number 199 B
📦 @videojs/cdn — no changes
📦 @videojs/cloudflare-video — no changes
📦 @videojs/dash-video — no changes
📦 @videojs/google-cast — no changes
📦 @videojs/hlsjs-video — no changes
📦 @videojs/media — no changes
Entries (3)
Entry Initial
. 3.22 kB
/dom 4.00 kB
/media-tracks 2.05 kB
📦 @videojs/mux — no changes
📦 @videojs/mux-audio — no changes
Entries (2)
Entry Initial
. 136.01 kB
/spf 22.76 kB
📦 @videojs/mux-data — no changes
📦 @videojs/mux-video — no changes
Entries (2)
Entry Initial
. 135.92 kB
/spf 32.99 kB
📦 @videojs/native-hls-video — no changes
📦 @videojs/shaka-video — no changes
📦 @videojs/spf — no changes
Entries (7)
Entry Initial
. 4.56 kB
/dom 7.85 kB
/hls 28.40 kB
/media-tracks 507 B
/hls-background-video 16.60 kB
/hls-audio 21.28 kB
/hls-video 31.73 kB
📦 @videojs/spotify-audio — no changes
📦 @videojs/tiktok-video — no changes
📦 @videojs/twitch-video — no changes
📦 @videojs/other — no changes
Entries (3)
Entry Initial Lazy
video.js 74.33 kB 56.03 kB
video.js/package.json 608 B —
video.js/errors 1.03 kB —
📦 @videojs/vimeo-video — no changes
📦 @videojs/wistia-video — no changes
Entries (2)
Entry Initial
. 1.91 kB
/helpers 1.76 kB
📦 @videojs/youtube-video — no changes

ℹ️ How to interpret

Each entry is independently bundled, minified, and brotli-compressed. Initial size includes its static import graph; lazy dynamic chunks are reported separately.

Entries are not additive because their dependency graphs overlap. Preset rows represent realistic combined bundles.

Changes of 300 B or less across initial, lazy, and total size are collapsed, not discarded.

Run pnpm size locally to check current initial sizes.

The reference pages and demos no longer route around the root export, and a
test covers the four root namespaces.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01WLkDiofiR86hzNgRopBotH

@decepulis decepulis left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agent review (same method as the stack review on #3063). This does what rahim asked in answer 3 and the diff is clean: no *RadioGroupLegacy / *LegacyProps reference survives anywhere in the repo (git grep over the head, including skins, sandbox, e2e, installation and docs), ComponentImports already defaults reactFrom to @videojs/react so dropping the prop is correct, the root now exports the same export * as namespaces as the subpaths with the part props reachable as CaptionsRadioGroup.OptionsProps etc. (matching the Menu/Dialog family), and the new test pins the root parts to the component module. CI is fully green on this head, including compatibility.

Nothing to change. One sequencing note for whoever merges: the API stability stack was tagged against main without this PR, so #3068 currently removes @internal from the four *RadioGroupLegacy shims (page wins over tag), and a trial merge of this branch into the top of the stack reports 4 conflicts in those component.tsx files. Merge this PR first and let the stack re-run --fix on top of it; merging the stack first and this PR second produces trivial but avoidable conflicts.


Generated by Claude Code

Copy link
Copy Markdown
Collaborator Author

Follow-up on the sequencing note: rather than relying on merge order, fold this PR into the API stability stack as its new bottom. Concretely: keep this PR's base on main, retarget #3063's base to claude/keen-mccarthy-7ams8m-radio-groups, merge this branch into #3063's branch and propagate the merge up through #3066 → #3067 → #3082 → #3068 → #3083. Then re-run pnpm -F site check:api-stability --fix in #3068 so it stops un-tagging the removed *RadioGroupLegacy shims, and update the "Part N of the stack" lines in each description. That guarantees this lands first and removes the 4 conflicts.


Generated by Claude Code

Copy link
Copy Markdown
Collaborator Author

The Website Tests test failure here is the one described in #3066 (comment). Three of main's new analytics tests from #3087 expect installation_skin: "minimal-video" and get "video". This PR's only change from main is deleting the radio-group shims, so the failure comes from main, not this PR. There's no fix on main yet. I re-ran it once on #3066, and I'll merge in the fix when one lands.


Generated by Claude Code

claude and others added 2 commits October 1, 2026 18:51
The analytics context tests from #3087 still use the `minimal` skin
that #3092 renamed to `neutral`, so they fail on main. Use the renamed
skin parameter and id.

(cherry picked from commit 51f15cc)

Copy link
Copy Markdown
Collaborator Author

Update on the test failure: it's main's. #3092 renamed the minimal skin flag to neutral, and the analytics tests that #3087 added still used skin=minimal. I've ported the fix from #3080 (51f15cc) into this PR as 9ed503e. It will become a no-op once main gets the fix. I also merged #3092 up the whole stack and renamed the minimal-skin references in #3067's new pages.


Generated by Claude Code

@decepulis
decepulis merged commit 3f7a926 into main Oct 1, 2026
15 of 16 checks passed
@decepulis
decepulis deleted the claude/keen-mccarthy-7ams8m-radio-groups branch October 1, 2026 21:17

This branch was successfully deployed

1 active deployment
Preview — cd3b8ddc Deployed Oct 1, 2026 by vercel[bot]
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants