Skip to content
This repository was archived by the owner on Oct 21, 2026. It is now read-only.

chore: tag undocumented public exports @internal and enforce it in CI - #3068

Merged
decepulis merged 29 commits into
claude/keen-mccarthy-7ams8m-exportsfrom
claude/keen-mccarthy-7ams8m-tags
Oct 1, 2026
Merged

decepulis merged 29 commits into
claude/keen-mccarthy-7ams8m-exportsfrom
claude/keen-mccarthy-7ams8m-tags

Conversation

@decepulis

@decepulis decepulis commented Sep 29, 2026 •

Copy link
Copy Markdown
Collaborator

Part 6 of the API stability stack: #3073 → #3063 → #3066 → #3067 → #3082 → this PR → #3083.

Summary

  • Runs pnpm -F site check:api-stability --fix across the packages, using the rules from feat(site): check that undocumented public exports are tagged internal #3063:
    • A reference page documents it → stable.
    • A stable export's public types reference it, including through protected members, local helpers and mixin bases → stable, with no tag needed.
    • A stability: unstable page documents it, or only experimental exports reference it → @experimental.
    • Everything else → @internal.
    • These tag changes are JSDoc only.
  • Result on this branch: 1,901 checked exports: 1,196 stable, 19 experimental, 686 internal. chore(store): check and tag store's public exports #3083 adds store, for 1,966 in total. Every stable export is importable from @videojs/react, @videojs/html, an extension package or @videojs/store.
  • i18n building blocks are public, as Rahim asked in review:
    • The 71 text descriptors (playText, forwardText, …) can be imported from new @videojs/react/i18n/text/* and @videojs/html/i18n/text/* entry points, which re-export core's modules. Translation phrases documents them and lists the 17 modules in apis.
    • getCanonicalLocaleKey is renamed getLocaleKey. This is a breaking rename for anyone importing it from @videojs/core/i18n.
    • getLocaleKey, findLocaleKeys, loadLocale, isText, translateText and resolveTranslation are re-exported from both /i18n entries, and each gets a reference page. Text and TextParams are stable by reference.
  • refactor(packages)!: attach extensions at the player #2880's player extension contract stays internal.
    • PlayerExtension, ExtensionPlayer, MediaOverride and MediaOverrideSource were coming out stable because GoogleCastExtension and MuxDataExtension implemented PlayerExtension and exposed its lifecycle.
    • Their player-driven members (connect, disconnect, attach, detach, mediaOverride) are now @internal, and the implements clause is gone.
    • PlayerExtensionElement and usePlayerExtension still check at compile time that an extension conforms.
    • destroy and the props stay public.
  • main's new exports are tagged:
  • Generators emit matching tags, so a rebuild doesn't undo them:
    • core's i18n generators: locales/all stays @internal, and the text descriptors and loadLocale come out untagged (stable). TranslationParams is stable, because stable translation APIs reference it. The locale generator also writes the platform i18n/text/* re-exports.
    • the VJSC component-schema generator (@videojs/core/vjsc)
    • Core's build cache now lists scripts/** as an input. Without it, a cache hit after a generator change restored outdated generated sources.
  • CI: adds a Check public API stability tags step to the website-tests astro-check job, after pnpm build:packages and site content generation. The main ruleset has no required status checks yet, so the step reports but doesn't block merging until a maintainer makes astro-check required.

Preview pages

Six new i18n reference pages:

  • reference/api/get-locale-key
  • reference/api/find-locale-keys
  • reference/api/load-locale
  • reference/api/is-text
  • reference/api/translate-text
  • reference/api/resolve-translation

Translation phrases also gains a "Text descriptors" section. Apart from those, the tags don't change any rendered page.

Reviewer notes

  • Most of this diff is mechanical. The manual changes are:
  • Expected warnings remain:
    • A migration guide and the DASH and Shaka demos import DashVideo and ShakaVideo, which are @experimental.
    • @videojs/mux-data's MuxDataOptions and MuxDataSdk resolve to no declaration, because that package's build doesn't emit types.d.ts. That's a separate build bug.

Testing

  • pnpm build:packages, pnpm typecheck
  • pnpm -F site check:api-stability: all 1,901 checked exports are documented, referenced or tagged.
  • Tests:
    • core: 1,623; after the i18n change, its i18n and store-feature suites were re-run (288)
    • html: 486
    • react: 616; after merging feat(react): add mediaRef prop to media components #3098, the media and utils suites were re-run (164)
    • media: 292
    • google-cast: 43
    • mux-data: 32
    • site scripts (checker and API docs builder) plus the media reference model: 354
    • site: all pass except markdown-negotiation, which fails only on local Node 22 because URLPattern is missing
  • pnpm -F site api-docs produces reference data for the six new pages.
  • pnpm lint, pnpm check:workspace, astro check --minimumSeverity warning (0 errors, 0 warnings)
  • Re-running the i18n generators reproduces the committed files exactly.

🤖 Generated with Claude Code

https://claude.ai/code/session_01WLkDiofiR86hzNgRopBotH

Runs `pnpm -F site check:api-stability --fix` across the packages: every
public export that no reference page documents is now tagged @internal,
and the DASH and Shaka media, whose pages are marked unstable, are
tagged @experimental. The i18n and VJSC schema generators emit the tag
in their output, so rebuilding keeps it.

The website-tests astro-check job now runs the check after generating
site content.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01WLkDiofiR86hzNgRopBotH
@vercel

vercel Bot commented Sep 29, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
v10-sandbox Ready Ready Preview Oct 1, 2026 9:15pm UTC

Request Review

@pkg-pr-new

pkg-pr-new Bot commented Sep 29, 2026 •

Copy link
Copy Markdown
@videojs/cdn

pnpm add https://pkg.pr.new/@videojs/cdn@3068

@videojs/cli

pnpm add https://pkg.pr.new/@videojs/cli@3068

@videojs/core

pnpm add https://pkg.pr.new/@videojs/core@3068

@videojs/element

pnpm add https://pkg.pr.new/@videojs/element@3068

@videojs/html

pnpm add https://pkg.pr.new/@videojs/html@3068

@videojs/media

pnpm add https://pkg.pr.new/@videojs/media@3068

@videojs/react

pnpm add https://pkg.pr.new/@videojs/react@3068

@videojs/spf

pnpm add https://pkg.pr.new/@videojs/spf@3068

@videojs/store

pnpm add https://pkg.pr.new/@videojs/store@3068

@videojs/utils

pnpm add https://pkg.pr.new/@videojs/utils@3068

@videojs/cloudflare-video

pnpm add https://pkg.pr.new/@videojs/cloudflare-video@3068

@videojs/dash-video

pnpm add https://pkg.pr.new/@videojs/dash-video@3068

@videojs/hlsjs-video

pnpm add https://pkg.pr.new/@videojs/hlsjs-video@3068

@videojs/mux-audio

pnpm add https://pkg.pr.new/@videojs/mux-audio@3068

@videojs/mux-video

pnpm add https://pkg.pr.new/@videojs/mux-video@3068

@videojs/native-hls-video

pnpm add https://pkg.pr.new/@videojs/native-hls-video@3068

@videojs/shaka-video

pnpm add https://pkg.pr.new/@videojs/shaka-video@3068

@videojs/spotify-audio

pnpm add https://pkg.pr.new/@videojs/spotify-audio@3068

@videojs/tiktok-video

pnpm add https://pkg.pr.new/@videojs/tiktok-video@3068

@videojs/twitch-video

pnpm add https://pkg.pr.new/@videojs/twitch-video@3068

@videojs/vimeo-video

pnpm add https://pkg.pr.new/@videojs/vimeo-video@3068

@videojs/wistia-video

pnpm add https://pkg.pr.new/@videojs/wistia-video@3068

@videojs/youtube-video

pnpm add https://pkg.pr.new/@videojs/youtube-video@3068

@videojs/google-cast

pnpm add https://pkg.pr.new/@videojs/google-cast@3068

@videojs/mux-data

pnpm add https://pkg.pr.new/@videojs/mux-data@3068

commit: 607b2bf

@github-actions

github-actions Bot commented Sep 29, 2026 •

Copy link
Copy Markdown
Contributor

📦 Bundle Size Report

🎨 @videojs/html — 1 small size change
Path Base initial PR initial Initial diff Lazy diff
/ui/title 8.48 kB 8.50 kB +19 B (+0.2%) 0 B
Presets (7)
Entry Initial Lazy
/video (default) 65.17 kB 56.03 kB
/video (default + hls) 67.02 kB 56.03 kB
/video (neutral) 65.64 kB 56.03 kB
/video (neutral + hls) 67.39 kB 56.03 kB
/audio (default) 49.10 kB 56.03 kB
/audio (neutral) 49.41 kB 56.03 kB
/background 12.76 kB 56.03 kB
Media (18)
Entry Initial
/media/mux-video 3.03 kB
/media/mux-audio 2.71 kB
/media/background-video 1.17 kB
/media/cloudflare-video 2.91 kB
/media/dash-video 2.63 kB
/media/hls-audio 23.54 kB
/media/hls-background-video 17.56 kB
/media/hls-video 33.95 kB
/media/hlsjs-video 2.64 kB
/media/mux-background-video 17.58 kB
/media/native-hls-video 7.54 kB
/media/shaka-video 2.64 kB
/media/spotify-audio 3.03 kB
/media/tiktok-video 3.14 kB
/media/twitch-video 2.94 kB
/media/vimeo-video 2.92 kB
/media/wistia-video 615 B
/media/youtube-video 2.91 kB
Players (5)
Entry Initial Lazy
/video/player 10.85 kB 56.03 kB
/audio/player 7.05 kB 56.03 kB
/background/player 5.34 kB 56.03 kB
/live-video/player 10.23 kB 56.03 kB
/live-audio/player 7.06 kB 56.03 kB
Skins (41)
Entry Type Initial Lazy
/video/compat-skin.css css 7.48 kB —
/video/neutral-skin.css css 8.33 kB —
/video/skin.css css 8.05 kB —
/video/compat-skin js 62.38 kB 56.03 kB
/video/compat-skin2 js 7.45 kB —
/video/neutral-skin js 63.35 kB 56.03 kB
/video/neutral-skin2 js 8.32 kB —
/video/skin js 62.96 kB 56.03 kB
/video/skin2 js 8.02 kB —
/audio/compat-skin.css css 6.13 kB —
/audio/neutral-skin.css css 6.07 kB —
/audio/skin.css css 5.80 kB —
/audio/compat-skin js 53.99 kB 56.03 kB
/audio/compat-skin2 js 6.13 kB —
/audio/neutral-skin js 47.08 kB 56.03 kB
/audio/neutral-skin2 js 6.05 kB —
/audio/skin js 46.80 kB 56.03 kB
/audio/skin2 js 5.78 kB —
/background/skin.css css 141 B —
/background/skin js 10.18 kB 56.03 kB
/background/skin2 js 159 B —
/live-video/compat-skin.css css 6.92 kB —
/live-video/neutral-skin.css css 6.82 kB —
/live-video/skin.css css 6.72 kB —
/live-video/compat-skin js 53.71 kB 56.03 kB
/live-video/compat-skin2 js 6.91 kB —
/live-video/neutral-skin js 50.96 kB 56.03 kB
/live-video/neutral-skin2 js 6.82 kB —
/live-video/skin js 50.87 kB 56.03 kB
/live-video/skin2 js 6.72 kB —
/live-audio/compat-skin.css css 5.63 kB —
/live-audio/neutral-skin.css css 4.77 kB —
/live-audio/skin.css css 4.67 kB —
/live-audio/compat-skin js 40.92 kB 56.03 kB
/live-audio/compat-skin2 js 5.64 kB —
/live-audio/neutral-skin js 36.30 kB 56.03 kB
/live-audio/neutral-skin2 js 4.77 kB —
/live-audio/skin js 36.20 kB 56.03 kB
/live-audio/skin2 js 4.66 kB —
/global.css css 239 B —
/shadow.css css 78 B —
UI Components (62)
Entry Initial Lazy
/ui/airplay-button 11.57 kB 56.03 kB
/ui/alert-dialog 8.99 kB 56.03 kB
/ui/audio-track-radio-group 11.68 kB 56.03 kB
/ui/buffering-indicator 8.91 kB 56.03 kB
/ui/captions-button 11.80 kB 56.03 kB
/ui/captions-radio-group 11.73 kB 56.03 kB
/ui/cast-button 11.54 kB 56.03 kB
/ui/container 9.79 kB 56.03 kB
/ui/controls 9.10 kB 56.03 kB
/ui/controls-backdrop 1.69 kB 56.03 kB
/ui/controls-content 1.67 kB 56.03 kB
/ui/dialog 8.92 kB 56.03 kB
/ui/dialog-backdrop 1.70 kB 56.03 kB
/ui/dialog-close 2.06 kB 56.03 kB
/ui/dialog-description 1.69 kB 56.03 kB
/ui/dialog-popup 1.90 kB 56.03 kB
/ui/dialog-title 1.69 kB 56.03 kB
/ui/error-dialog 12.69 kB 56.03 kB
/ui/fullscreen-button 11.55 kB 56.03 kB
/ui/gesture 10.01 kB 56.03 kB
/ui/hotkey 10.40 kB 56.03 kB
/ui/live-button 10.09 kB 56.03 kB
/ui/menu 19.25 kB 56.03 kB
/ui/menu-checkbox-item 1.97 kB 56.03 kB
/ui/menu-content 7.65 kB 56.03 kB
/ui/menu-group 2.09 kB 56.03 kB
/ui/menu-group-label 1.64 kB —
/ui/menu-item 2.29 kB 56.03 kB
/ui/menu-item-indicator 1.38 kB 56.03 kB
/ui/menu-radio-group 3.03 kB 56.03 kB
/ui/menu-radio-item 2.14 kB 56.03 kB
/ui/menu-separator 1.30 kB 56.03 kB
/ui/mute-button 11.58 kB 56.03 kB
/ui/pip-button 11.53 kB 56.03 kB
/ui/play-button 11.51 kB 56.03 kB
/ui/playback-rate-button 11.62 kB 56.03 kB
/ui/playback-rate-radio-group 11.69 kB 56.03 kB
/ui/popover 8.77 kB 56.03 kB
/ui/poster 9.21 kB 56.03 kB
/ui/quality-radio-group 12.18 kB 56.03 kB
/ui/seek-button 11.55 kB 56.03 kB
/ui/seek-indicator 13.39 kB 56.03 kB
/ui/seek-indicator-value 1.10 kB —
/ui/slider 11.94 kB 56.03 kB
/ui/slider-preview 2.01 kB 56.03 kB
/ui/status-announcer 10.94 kB 56.03 kB
/ui/status-indicator 13.34 kB 56.03 kB
/ui/status-indicator-value 1.10 kB —
/ui/thumbnail 10.64 kB 56.03 kB
/ui/time 11.36 kB 56.03 kB
/ui/time-slider 13.44 kB 56.03 kB
/ui/time-slider-chapter-title 9.10 kB 56.03 kB
/ui/time-slider-chapters 9.92 kB 56.03 kB
/ui/title 8.50 kB 56.03 kB
/ui/tooltip 10.15 kB 56.03 kB
/ui/tooltip-label 1.21 kB —
/ui/tooltip-shortcut 1.18 kB —
/ui/volume-indicator 13.31 kB 56.03 kB
/ui/volume-indicator-fill 1.11 kB —
/ui/volume-indicator-value 1.10 kB —
/ui/volume-popover 15.21 kB 56.03 kB
/ui/volume-slider 12.65 kB 56.03 kB
⚛️ @videojs/react — 12 small size changes
Path Base initial PR initial Initial diff Lazy diff
/video/compat-skin 59.66 kB 59.56 kB -95 B (-0.2%) 0 B
/video/neutral-skin 58.66 kB 58.72 kB +63 B (+0.1%) 0 B
/audio/neutral-skin 45.57 kB 45.57 kB +3 B (+0.0%) 0 B
/audio/skin 45.58 kB 45.53 kB -49 B (-0.1%) 0 B
/live-video/skin 48.59 kB 48.57 kB -22 B (-0.0%) 0 B
/ui/live-button 9.58 kB 9.58 kB +4 B (+0.0%) 0 B
/ui/quality-radio-group 11.15 kB 11.15 kB -3 B (-0.0%) 0 B
/ui/status-announcer 10.86 kB 10.88 kB +14 B (+0.1%) 0 B
/ui/thumbnail 9.82 kB 9.82 kB -2 B (-0.0%) 0 B
/ui/volume-popover 15.58 kB 15.58 kB -1 B (-0.0%) 0 B
/audio (default) 45.78 kB 45.66 kB -122 B (-0.3%) 0 B
/audio (neutral) 45.67 kB 45.74 kB +72 B (+0.2%) 0 B
Presets (7)
Entry Initial Lazy
/video (default) 58.75 kB 56.03 kB
/video (default + hls) 59.36 kB 56.03 kB
/video (neutral) 58.80 kB 56.03 kB
/video (neutral + hls) 59.38 kB 56.03 kB
/audio (default) 45.66 kB 56.03 kB
/audio (neutral) 45.74 kB 56.03 kB
/background 921 B 56.03 kB
Media (22)
Entry Initial
/media/mux-video/hls-js 1.47 kB
/media/mux-video/spf 1.47 kB
/media/mux-audio/hls-js 1.15 kB
/media/mux-audio/spf 1.14 kB
/media/background-video 532 B
/media/cloudflare-video 1.88 kB
/media/dash-video 1.13 kB
/media/hls-audio 22.20 kB
/media/hls-background-video 17.60 kB
/media/hls-video 32.64 kB
/media/hlsjs-video 1.13 kB
/media/mux-audio 1.13 kB
/media/mux-background-video 17.63 kB
/media/mux-video 1.46 kB
/media/native-hls-video 6.19 kB
/media/shaka-video 1.13 kB
/media/spotify-audio 1.94 kB
/media/tiktok-video 1.88 kB
/media/twitch-video 1.89 kB
/media/vimeo-video 1.85 kB
/media/wistia-video 1.42 kB
/media/youtube-video 1.86 kB
Extensions (2)
Entry Initial
/extensions/google-cast 613 B
/extensions/mux-data 665 B
Players (5)
Entry Initial Lazy
/video/player 8.68 kB 56.03 kB
/audio/player 4.90 kB 56.03 kB
/background/player 3.16 kB 56.03 kB
/live-video/player 8.07 kB 56.03 kB
/live-audio/player 4.91 kB 56.03 kB
Skins (26)
Entry Type Initial Lazy
/video/compat-skin.css css 7.35 kB —
/video/neutral-skin.css css 8.16 kB —
/video/skin.css css 7.86 kB —
/video/compat-skin js 59.56 kB 56.03 kB
/video/neutral-skin js 58.72 kB 56.03 kB
/video/skin js 58.72 kB 56.03 kB
/audio/compat-skin.css css 5.97 kB —
/audio/neutral-skin.css css 5.89 kB —
/audio/skin.css css 5.60 kB —
/audio/compat-skin js 50.66 kB 56.03 kB
/audio/neutral-skin js 45.57 kB 56.03 kB
/audio/skin js 45.53 kB 56.03 kB
/background/skin.css css 97 B —
/background/skin js 516 B —
/live-video/compat-skin.css css 6.81 kB —
/live-video/neutral-skin.css css 6.65 kB —
/live-video/skin.css css 6.55 kB —
/live-video/compat-skin js 55.54 kB 56.03 kB
/live-video/neutral-skin js 48.55 kB 56.03 kB
/live-video/skin js 48.57 kB 56.03 kB
/live-audio/compat-skin.css css 5.48 kB —
/live-audio/neutral-skin.css css 4.58 kB —
/live-audio/skin.css css 4.47 kB —
/live-audio/compat-skin js 41.85 kB 56.03 kB
/live-audio/neutral-skin js 33.86 kB 56.03 kB
/live-audio/skin js 33.86 kB 56.03 kB
UI Components (39)
Entry Initial Lazy
/ui/airplay-button 11.28 kB 56.03 kB
/ui/alert-dialog 5.21 kB 56.03 kB
/ui/audio-track 8.40 kB 56.03 kB
/ui/audio-track-radio-group 10.74 kB 56.03 kB
/ui/buffering-indicator 8.45 kB 56.03 kB
/ui/captions-button 11.26 kB 56.03 kB
/ui/captions-radio-group 10.81 kB 56.03 kB
/ui/cast-button 11.27 kB 56.03 kB
/ui/controls 8.34 kB 56.03 kB
/ui/dialog 5.20 kB 56.03 kB
/ui/error-dialog 12.66 kB 56.03 kB
/ui/fullscreen-button 11.24 kB 56.03 kB
/ui/gesture 8.61 kB 56.03 kB
/ui/hotkey 9.03 kB 56.03 kB
/ui/live-button 9.58 kB 56.03 kB
/ui/menu 22.05 kB 56.03 kB
/ui/mute-button 11.28 kB 56.03 kB
/ui/pip-button 11.24 kB 56.03 kB
/ui/play-button 11.20 kB 56.03 kB
/ui/playback-rate 8.45 kB 56.03 kB
/ui/playback-rate-button 11.20 kB 56.03 kB
/ui/playback-rate-radio-group 10.81 kB 56.03 kB
/ui/popover 9.12 kB 56.03 kB
/ui/poster 8.65 kB 56.03 kB
/ui/quality 8.82 kB 56.03 kB
/ui/quality-radio-group 11.15 kB 56.03 kB
/ui/seek-button 11.24 kB 56.03 kB
/ui/seek-indicator 13.12 kB 56.03 kB
/ui/slider 14.43 kB 56.03 kB
/ui/status-announcer 10.88 kB 56.03 kB
/ui/status-indicator 13.40 kB 56.03 kB
/ui/thumbnail 9.82 kB 56.03 kB
/ui/time 10.66 kB 56.03 kB
/ui/time-slider 16.18 kB 56.03 kB
/ui/title 7.93 kB 56.03 kB
/ui/tooltip 9.98 kB 56.03 kB
/ui/volume-indicator 13.43 kB 56.03 kB
/ui/volume-popover 15.58 kB 56.03 kB
/ui/volume-slider 13.02 kB 56.03 kB
🧩 @videojs/core — 1 small size change
Path Base initial PR initial Initial diff Lazy diff
/i18n 3.21 kB 3.20 kB -4 B (-0.1%) 0 B
Entries (76)
Entry Initial Lazy
. 13.48 kB —
/dom 23.92 kB 56.03 kB
/vjsc 1.90 kB —
/i18n 3.20 kB 56.03 kB
/i18n/locales/all 33.91 kB —
/i18n/locales/ar 1.16 kB —
/i18n/locales/az 1.08 kB —
/i18n/locales/bg 1.29 kB —
/i18n/locales/bn 1.25 kB —
/i18n/locales/bs 1.02 kB —
/i18n/locales/ca 1.04 kB —
/i18n/locales/cs 1.10 kB —
/i18n/locales/cy 1.02 kB —
/i18n/locales/da 984 B —
/i18n/locales/de 1.06 kB —
/i18n/locales/el 1.42 kB —
/i18n/locales/en 801 B —
/i18n/locales/es 999 B —
/i18n/locales/et 1.02 kB —
/i18n/locales/eu 1.04 kB —
/i18n/locales/fa 1.21 kB —
/i18n/locales/fi 1.05 kB —
/i18n/locales/fr 1.01 kB —
/i18n/locales/gd 1.09 kB —
/i18n/locales/gl 1017 B —
/i18n/locales/he 1.10 kB —
/i18n/locales/hi 1.25 kB —
/i18n/locales/hr 1.05 kB —
/i18n/locales/hu 1.10 kB —
/i18n/locales/id 953 B —
/i18n/locales/it 1.01 kB —
/i18n/locales/ja 1.16 kB —
/i18n/locales/ko 1.08 kB —
/i18n/locales/lt 1.04 kB —
/i18n/locales/lv 1.09 kB —
/i18n/locales/mr 1.23 kB —
/i18n/locales/nb 990 B —
/i18n/locales/ne 1.23 kB —
/i18n/locales/nl 1.01 kB —
/i18n/locales/nn 983 B —
/i18n/locales/oc 1.05 kB —
/i18n/locales/pl 1.11 kB —
/i18n/locales/pt 1.02 kB —
/i18n/locales/pt-BR 1.02 kB —
/i18n/locales/pt-PT 1.02 kB —
/i18n/locales/ro 1.04 kB —
/i18n/locales/ru 1.36 kB —
/i18n/locales/sk 1.10 kB —
/i18n/locales/sl 1.04 kB —
/i18n/locales/sr 1.05 kB —
/i18n/locales/sv 1.01 kB —
/i18n/locales/te 1.29 kB —
/i18n/locales/th 1.20 kB —
/i18n/locales/tr 1.00 kB —
/i18n/locales/uk 1.37 kB —
/i18n/locales/vi 1.10 kB —
/i18n/locales/zh 1.01 kB —
/i18n/locales/zh-CN 1.01 kB —
/i18n/locales/zh-TW 1.02 kB —
/i18n/text/airplay 101 B —
/i18n/text/buttons 137 B —
/i18n/text/captions 93 B —
/i18n/text/cast 114 B —
/i18n/text/common 90 B —
/i18n/text/container 75 B —
/i18n/text/errors 285 B —
/i18n/text/fullscreen 98 B —
/i18n/text/live 126 B —
/i18n/text/menu 249 B —
/i18n/text/pip 101 B —
/i18n/text/playback 80 B —
/i18n/text/seek 105 B —
/i18n/text/slider 65 B —
/i18n/text/status 222 B —
/i18n/text/time 322 B —
/i18n/text/volume 133 B —
🏷️ @videojs/element — no changes
Entries (2)
Entry Initial
. 1.05 kB
/context 1.15 kB
📦 @videojs/store — no changes
Entries (3)
Entry Initial
. 1.85 kB
/html 703 B
/react 511 B
🔧 @videojs/utils — no changes
Entries (13)
Entry Initial
/array 271 B
/dom 5.25 kB
/events 320 B
/function 414 B
/i18n 249 B
/jwt 176 B
/object 535 B
/predicate 297 B
/percent 281 B
/string 239 B
/style 212 B
/time 1018 B
/number 199 B
📦 @videojs/cdn — no changes
📦 @videojs/cloudflare-video — no changes
📦 @videojs/dash-video — no changes
📦 @videojs/google-cast — no changes
📦 @videojs/hlsjs-video — no changes
📦 @videojs/media — no changes
Entries (3)
Entry Initial
. 3.22 kB
/dom 4.00 kB
/media-tracks 2.05 kB
📦 @videojs/mux — no changes
📦 @videojs/mux-audio — no changes
Entries (2)
Entry Initial
. 136.01 kB
/spf 22.76 kB
📦 @videojs/mux-data — no changes
📦 @videojs/mux-video — no changes
Entries (2)
Entry Initial
. 135.92 kB
/spf 32.99 kB
📦 @videojs/native-hls-video — no changes
📦 @videojs/shaka-video — no changes
📦 @videojs/spf — no changes
Entries (7)
Entry Initial
. 4.56 kB
/dom 7.85 kB
/hls 28.40 kB
/media-tracks 507 B
/hls-background-video 16.60 kB
/hls-audio 21.28 kB
/hls-video 31.73 kB
📦 @videojs/spotify-audio — no changes
📦 @videojs/tiktok-video — no changes
📦 @videojs/twitch-video — no changes
📦 @videojs/other — 1 small size change
Path Base initial PR initial Initial diff Lazy diff
video.js 74.29 kB 74.32 kB +21 B (+0.0%) 0 B
Entries (3)
Entry Initial Lazy
video.js 74.32 kB 56.03 kB
video.js/package.json 608 B —
video.js/errors 1.03 kB —
📦 @videojs/vimeo-video — no changes
📦 @videojs/wistia-video — no changes
Entries (2)
Entry Initial
. 1.91 kB
/helpers 1.76 kB
📦 @videojs/youtube-video — no changes

ℹ️ How to interpret

Each entry is independently bundled, minified, and brotli-compressed. Initial size includes its static import graph; lazy dynamic chunks are reported separately.

Entries are not additive because their dependency graphs overlap. Preset rows represent realistic combined bundles.

Changes of 300 B or less across initial, lazy, and total size are collapsed, not discarded.

Run pnpm size locally to check current initial sizes.

@decepulis
decepulis added this pull request to stack #3069 September 29, 2026 23:41
@netlify

netlify Bot commented Sep 29, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for vjs-registry ready!

Name Link
🔨 Latest commit 21412c0
🔍 Latest deploy log https://app.netlify.com/projects/vjs-registry/deploys/6abecd0c676e0f0008f21186
😎 Deploy Preview https://deploy-preview-3068--vjs-registry.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify

netlify Bot commented Sep 29, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for vjs10-site ready!

Name Link
🔨 Latest commit 21412c0
🔍 Latest deploy log https://app.netlify.com/projects/vjs10-site/deploys/6abecd0c2e0eea00083f2cde
😎 Deploy Preview https://deploy-preview-3068--vjs10-site.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

…ccarthy-7ams8m-tags

# Conflicts:
#	packages/core/src/dom/player.ts
#	packages/html/src/define/media/dash-video.ts
#	packages/html/src/define/media/shaka-video.ts
#	packages/html/src/store/types.ts
#	packages/html/src/ui/media-button-element.ts
#	packages/html/src/ui/media-ui-element.ts
#	packages/media/src/dom/html-media-adapter/html-media-adapter.ts
#	packages/react/src/ui/time-slider/chapters.tsx
#	packages/utils/src/dom/types.ts
Re-run `pnpm -F site check:api-stability --fix` on top of the exports
branch. Types that stable exports reference lose their `@internal`
tag, the Core classes that no longer appear in public signatures gain
it, and types referenced only by the DASH and Shaka media become
`@experimental`. The i18n types generator no longer marks
`TranslationParams` internal, because stable translation APIs
reference it.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01WLkDiofiR86hzNgRopBotH
…ccarthy-7ams8m-tags

# Conflicts:
#	packages/core/src/core/ui/status-indicator/status.ts
…ental rule

Adapter classes, media track contracts, and other types reached through mixin
bases and local helpers lose @internal (or move to @experimental behind the DASH
and Shaka pages); the constants the literal-union types no longer name gain it.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01WLkDiofiR86hzNgRopBotH
@decepulis
decepulis removed this pull request from stack #3069 September 30, 2026 23:38
@decepulis
decepulis changed the base branch from claude/keen-mccarthy-7ams8m-pages to claude/keen-mccarthy-7ams8m-exports September 30, 2026 23:39
@decepulis
decepulis added this pull request to stack #3089 September 30, 2026 23:40
@decepulis
decepulis marked this pull request as ready for review September 30, 2026 23:42

@decepulis decepulis left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agent review (part of the stack review; see #3063 for method). I scripted every added tag in the diff (786: 765 @internal, 21 @experimental) to the declaration it lands on: all land on an export declaration (none on imports, directives or re-export statements), every overload set is fully tagged, the generated i18n/vjsc outputs match their generators, TranslationParams/LOCALES/ReactiveController/ReactiveControllerHost/MediaButtonElement/ContextPartElement/UIElement/ReactiveElement are stable as rahim decided, the create* controllers and use*Context hooks are internal (answer 6), status-indicator/status.ts equals main plus two tags, the api-docs builder doesn't filter on top-level @internal and no tsconfig sets stripInternal, so no page or consumer .d.ts loses content.

Inline: 🔴 PropertyValues, 🟡 PartContextValue, 🟡 DestroyMixin. All three are the same shape: subclassing surface of base classes B(a) made stable, which the checker can't see because it skips protected members or inline-code mentions.

Follow-ups from #3063's heuristic comments that will change this diff once fixed: React i18n Text/TextProps currently stay untagged only because media-text.mdx documents a subject named Text; core's *Options controller contracts need @internal once the companion match is narrowed.

🟣 Decision for rahim: useMediaInstance, useMediaExtension, useAttachMedia, composeRefs (@videojs/react) become @internal. That follows rule 1 and answer 6, but the 10.0.0-beta.11 changelog announced them as the exported "media component building blocks … so you can build custom media components without reaching into internal module paths". Worth a conscious yes rather than a mechanical one.

Housekeeping: GitHub reports this PR as un-mergeable ("dirty"), but git merge-tree of the base into the head is clean and the head already contains the base; the flag looks stale. The description's "branch protection needs astro-check" is right and currently unmet: the main ruleset has no required status checks, so the new CI step reports but doesn't block until a maintainer adds it. The counts in the description (1,829 / 1,072 / 738) are from before #3083 was stacked; the top of the stack now reports 1,894 / 1,113 / 762.


Generated by Claude Code

Comment thread packages/element/src/types.ts Resolved
Comment thread packages/element/src/destroy-mixin.ts Resolved
…ccarthy-7ams8m-tags

# Conflicts:
#	packages/react/src/ui/audio-track-radio-group/component.tsx
#	packages/react/src/ui/captions-radio-group/component.tsx
#	packages/react/src/ui/playback-rate-radio-group/component.tsx
#	packages/react/src/ui/quality-radio-group/component.tsx
claude added 2 commits October 1, 2026 18:28
…ccarthy-7ams8m-tags

# Conflicts:
#	packages/media/src/dom/html-media-adapter/html-media-adapter.ts
#	packages/media/src/dom/utils/media-extensions.ts
#	packages/react/src/utils/use-media-extension.ts
Main's #2880 tags `PlayerExtension`, `ExtensionPlayer`, and
`MediaOverride*` internal, but the documented Cast and Mux Data
classes implemented `PlayerExtension` and exposed its lifecycle, which
made the contract stable by reference. Tag those lifecycle members
internal and drop the `implements` clause; the element and hook that
register an extension still check that it conforms. Also tags main's
new `VERSION` exports, extension context, and `AnyHTMLMediaAdapter`.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01WLkDiofiR86hzNgRopBotH
…ccarthy-7ams8m-tags

# Conflicts:
#	packages/core/src/core/ui/seek-indicator/status.ts
#	packages/core/src/dom/ui/popover/positioning.ts

@mihar-22 mihar-22 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great, i think let's re-review what should be considered public from core/i18n

Comment thread packages/core/src/core/i18n/registry.ts Resolved
Comment thread packages/core/src/core/i18n/registry.ts Resolved
Comment thread packages/core/src/core/i18n/text.ts Resolved
Per review, the text descriptors and the i18n helpers readers build custom UI
with are public API:

- `@videojs/{react,html}/i18n/text/*` re-export core's text descriptor modules;
  the locale generator writes them alongside the locale re-exports.
- `getCanonicalLocaleKey` is renamed `getLocaleKey`.
- `getLocaleKey`, `findLocaleKeys`, `loadLocale`, `isText`, `translateText`,
  and `resolveTranslation` drop `@internal`, are re-exported from both
  `/i18n` entries, and get reference pages.
- Core's build cache tracks its generator scripts, so a generator change no
  longer restores stale generated sources.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01WLkDiofiR86hzNgRopBotH
claude added 2 commits October 1, 2026 20:08
…ccarthy-7ams8m-tags

# Conflicts:
#	packages/react/src/media/dash-video/adapter.tsx
#3098 exported it from @videojs/react without a reference page; like
useMediaInstance and useAttachMedia, it is a custom-media building block.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01WLkDiofiR86hzNgRopBotH

This branch was successfully deployed

1 active deployment
Preview — 21412c02 Deployed Oct 1, 2026 by vercel[bot]
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants