Skip to content
This repository was archived by the owner on Oct 21, 2026. It is now read-only.

chore(store): check and tag store's public exports - #3083

Merged
decepulis merged 24 commits into
claude/keen-mccarthy-7ams8m-tagsfrom
claude/keen-mccarthy-7ams8m-store
Oct 1, 2026
Merged

decepulis merged 24 commits into
claude/keen-mccarthy-7ams8m-tagsfrom
claude/keen-mccarthy-7ams8m-store

Conversation

@decepulis

@decepulis decepulis commented Sep 30, 2026 •

Copy link
Copy Markdown
Collaborator

Part 7 of the API stability stack: #3073 → #3063 → #3066 → #3067 → #3082 → #3068 → this PR. It's the last PR so the store decision can be reviewed, or dropped, by itself.

Summary

Store now follows the same stability rule as the rest of Video.js. Exports that a reference page documents, or that a stable export's types reference, are stable; everything else is @internal. Store's authoring APIs stay internal for now, as the maintainers decided, and that includes the slice contracts they take.

  • Checker: packages/store/ is no longer skipped (site/scripts/check-api-stability.ts). AGENTS.md now says only SPF is unchecked.
  • Opaque slices: Slice is now a branded interface whose members are all @internal. That way, documenting createSelector no longer makes the slice authoring contract stable (Rahim chose option (b) in Slack).
    • SliceConfig is the internal, unbranded input that defineSlice brands. combine and definePlayerFeature brand their results the same way, and the internal createStore also accepts a plain config.
    • Type-only; nothing changes at runtime.
    • createSelector no longer accepts a literal with slice members. A type test in selector.test.ts covers that.
  • --fix tagged store exports @internal:
    • @videojs/store:
      • createStore, isStore, StoreFactory, InferStoreTarget
      • StoreOptions and the types it reaches: StoreCallbacks, StoreSetupContext, StoreAttachContext, StoreErrorContext
      • defineSlice, SliceFactory, SliceConfig, Attach, and the InferSlice*/UnionSlice* helpers that no stable signature names
      • the contexts a slice receives: StateContext, AttachContext, AttachStore, DerivedContext, DerivedDefinition, AbortControllerRegistry, SignalKey
      • createState, isState, WritableState, flush, combine
      • the StoreError/isStoreError/throw*Error helpers
    • @videojs/store/html: StoreAccessor, StoreAccessorHost
  • README: a note says the authoring APIs it describes, and the state primitives, are internal and may change. It points readers to usePlayer and PlayerController, and lists the store APIs that stay stable.

What stays stable

  • The documented controllers and hooks: useStore, useSelector, useSnapshot, createSelector, shallowEqual, StoreController, SnapshotController, SubscriptionController.
  • Every type their signatures name, including Store, State and UnknownStore.
  • The inference helpers player types use: InferSliceSourceState, InferSliceState, UnionSliceState.
  • Slice and AnySlice, only as opaque names you pass to createSelector.

Store's stable-by-reference list drops from 30 exports to 19.

If the authoring APIs should become public later, the fix is a reference page plus removing the member tags on Slice. The check then treats the contexts as stable automatically.

Preview pages

None. This PR changes no site pages; its preview matches #3068's. The one reader-facing change is the store README note.

Testing

🤖 Generated with Claude Code

https://claude.ai/code/session_01WLkDiofiR86hzNgRopBotH

Remove `@videojs/store` from the stability checker's unchecked packages
and run `--fix`, so store follows the same rule as the rest of
Video.js: exports documented on a reference page or referenced by a
stable export's types are stable, and the rest are `@internal`.
`InferSliceState` uses a local `Simplify` so the internal utils type
stays out of store's public types.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01WLkDiofiR86hzNgRopBotH
@vercel

vercel Bot commented Sep 30, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
v10-sandbox Ready Ready Preview Oct 1, 2026 9:16pm UTC

Request Review

@pkg-pr-new

pkg-pr-new Bot commented Sep 30, 2026 •

Copy link
Copy Markdown
@videojs/cdn

pnpm add https://pkg.pr.new/@videojs/cdn@3083

@videojs/cli

pnpm add https://pkg.pr.new/@videojs/cli@3083

@videojs/core

pnpm add https://pkg.pr.new/@videojs/core@3083

@videojs/element

pnpm add https://pkg.pr.new/@videojs/element@3083

@videojs/html

pnpm add https://pkg.pr.new/@videojs/html@3083

@videojs/media

pnpm add https://pkg.pr.new/@videojs/media@3083

@videojs/react

pnpm add https://pkg.pr.new/@videojs/react@3083

@videojs/spf

pnpm add https://pkg.pr.new/@videojs/spf@3083

@videojs/store

pnpm add https://pkg.pr.new/@videojs/store@3083

@videojs/utils

pnpm add https://pkg.pr.new/@videojs/utils@3083

@videojs/cloudflare-video

pnpm add https://pkg.pr.new/@videojs/cloudflare-video@3083

@videojs/dash-video

pnpm add https://pkg.pr.new/@videojs/dash-video@3083

@videojs/hlsjs-video

pnpm add https://pkg.pr.new/@videojs/hlsjs-video@3083

@videojs/mux-audio

pnpm add https://pkg.pr.new/@videojs/mux-audio@3083

@videojs/mux-video

pnpm add https://pkg.pr.new/@videojs/mux-video@3083

@videojs/native-hls-video

pnpm add https://pkg.pr.new/@videojs/native-hls-video@3083

@videojs/shaka-video

pnpm add https://pkg.pr.new/@videojs/shaka-video@3083

@videojs/spotify-audio

pnpm add https://pkg.pr.new/@videojs/spotify-audio@3083

@videojs/tiktok-video

pnpm add https://pkg.pr.new/@videojs/tiktok-video@3083

@videojs/twitch-video

pnpm add https://pkg.pr.new/@videojs/twitch-video@3083

@videojs/vimeo-video

pnpm add https://pkg.pr.new/@videojs/vimeo-video@3083

@videojs/wistia-video

pnpm add https://pkg.pr.new/@videojs/wistia-video@3083

@videojs/youtube-video

pnpm add https://pkg.pr.new/@videojs/youtube-video@3083

@videojs/google-cast

pnpm add https://pkg.pr.new/@videojs/google-cast@3083

@videojs/mux-data

pnpm add https://pkg.pr.new/@videojs/mux-data@3083

commit: 78acfcf

@github-actions

github-actions Bot commented Sep 30, 2026 •

Copy link
Copy Markdown
Contributor

📦 Bundle Size Report

🎨 @videojs/html — no changes
Presets (7)
Entry Initial Lazy
/video (default) 65.17 kB 56.03 kB
/video (default + hls) 67.02 kB 56.03 kB
/video (neutral) 65.64 kB 56.03 kB
/video (neutral + hls) 67.39 kB 56.03 kB
/audio (default) 49.10 kB 56.03 kB
/audio (neutral) 49.41 kB 56.03 kB
/background 12.76 kB 56.03 kB
Media (18)
Entry Initial
/media/mux-video 3.03 kB
/media/mux-audio 2.71 kB
/media/background-video 1.17 kB
/media/cloudflare-video 2.91 kB
/media/dash-video 2.63 kB
/media/hls-audio 23.54 kB
/media/hls-background-video 17.56 kB
/media/hls-video 33.95 kB
/media/hlsjs-video 2.64 kB
/media/mux-background-video 17.58 kB
/media/native-hls-video 7.54 kB
/media/shaka-video 2.64 kB
/media/spotify-audio 3.03 kB
/media/tiktok-video 3.14 kB
/media/twitch-video 2.94 kB
/media/vimeo-video 2.92 kB
/media/wistia-video 615 B
/media/youtube-video 2.91 kB
Players (5)
Entry Initial Lazy
/video/player 10.85 kB 56.03 kB
/audio/player 7.05 kB 56.03 kB
/background/player 5.34 kB 56.03 kB
/live-video/player 10.23 kB 56.03 kB
/live-audio/player 7.06 kB 56.03 kB
Skins (41)
Entry Type Initial Lazy
/video/compat-skin.css css 7.48 kB —
/video/neutral-skin.css css 8.33 kB —
/video/skin.css css 8.05 kB —
/video/compat-skin js 62.38 kB 56.03 kB
/video/compat-skin2 js 7.45 kB —
/video/neutral-skin js 63.35 kB 56.03 kB
/video/neutral-skin2 js 8.32 kB —
/video/skin js 62.96 kB 56.03 kB
/video/skin2 js 8.02 kB —
/audio/compat-skin.css css 6.13 kB —
/audio/neutral-skin.css css 6.07 kB —
/audio/skin.css css 5.80 kB —
/audio/compat-skin js 53.99 kB 56.03 kB
/audio/compat-skin2 js 6.13 kB —
/audio/neutral-skin js 47.08 kB 56.03 kB
/audio/neutral-skin2 js 6.05 kB —
/audio/skin js 46.80 kB 56.03 kB
/audio/skin2 js 5.78 kB —
/background/skin.css css 141 B —
/background/skin js 10.18 kB 56.03 kB
/background/skin2 js 159 B —
/live-video/compat-skin.css css 6.92 kB —
/live-video/neutral-skin.css css 6.82 kB —
/live-video/skin.css css 6.72 kB —
/live-video/compat-skin js 53.71 kB 56.03 kB
/live-video/compat-skin2 js 6.91 kB —
/live-video/neutral-skin js 50.96 kB 56.03 kB
/live-video/neutral-skin2 js 6.82 kB —
/live-video/skin js 50.87 kB 56.03 kB
/live-video/skin2 js 6.72 kB —
/live-audio/compat-skin.css css 5.63 kB —
/live-audio/neutral-skin.css css 4.77 kB —
/live-audio/skin.css css 4.67 kB —
/live-audio/compat-skin js 40.92 kB 56.03 kB
/live-audio/compat-skin2 js 5.64 kB —
/live-audio/neutral-skin js 36.30 kB 56.03 kB
/live-audio/neutral-skin2 js 4.77 kB —
/live-audio/skin js 36.20 kB 56.03 kB
/live-audio/skin2 js 4.66 kB —
/global.css css 239 B —
/shadow.css css 78 B —
UI Components (62)
Entry Initial Lazy
/ui/airplay-button 11.57 kB 56.03 kB
/ui/alert-dialog 8.99 kB 56.03 kB
/ui/audio-track-radio-group 11.68 kB 56.03 kB
/ui/buffering-indicator 8.91 kB 56.03 kB
/ui/captions-button 11.80 kB 56.03 kB
/ui/captions-radio-group 11.73 kB 56.03 kB
/ui/cast-button 11.54 kB 56.03 kB
/ui/container 9.79 kB 56.03 kB
/ui/controls 9.10 kB 56.03 kB
/ui/controls-backdrop 1.69 kB 56.03 kB
/ui/controls-content 1.67 kB 56.03 kB
/ui/dialog 8.92 kB 56.03 kB
/ui/dialog-backdrop 1.70 kB 56.03 kB
/ui/dialog-close 2.06 kB 56.03 kB
/ui/dialog-description 1.69 kB 56.03 kB
/ui/dialog-popup 1.90 kB 56.03 kB
/ui/dialog-title 1.69 kB 56.03 kB
/ui/error-dialog 12.69 kB 56.03 kB
/ui/fullscreen-button 11.55 kB 56.03 kB
/ui/gesture 10.01 kB 56.03 kB
/ui/hotkey 10.40 kB 56.03 kB
/ui/live-button 10.09 kB 56.03 kB
/ui/menu 19.25 kB 56.03 kB
/ui/menu-checkbox-item 1.97 kB 56.03 kB
/ui/menu-content 7.65 kB 56.03 kB
/ui/menu-group 2.09 kB 56.03 kB
/ui/menu-group-label 1.64 kB —
/ui/menu-item 2.29 kB 56.03 kB
/ui/menu-item-indicator 1.38 kB 56.03 kB
/ui/menu-radio-group 3.03 kB 56.03 kB
/ui/menu-radio-item 2.14 kB 56.03 kB
/ui/menu-separator 1.30 kB 56.03 kB
/ui/mute-button 11.58 kB 56.03 kB
/ui/pip-button 11.53 kB 56.03 kB
/ui/play-button 11.51 kB 56.03 kB
/ui/playback-rate-button 11.62 kB 56.03 kB
/ui/playback-rate-radio-group 11.69 kB 56.03 kB
/ui/popover 8.77 kB 56.03 kB
/ui/poster 9.21 kB 56.03 kB
/ui/quality-radio-group 12.18 kB 56.03 kB
/ui/seek-button 11.55 kB 56.03 kB
/ui/seek-indicator 13.39 kB 56.03 kB
/ui/seek-indicator-value 1.10 kB —
/ui/slider 11.94 kB 56.03 kB
/ui/slider-preview 2.01 kB 56.03 kB
/ui/status-announcer 10.94 kB 56.03 kB
/ui/status-indicator 13.34 kB 56.03 kB
/ui/status-indicator-value 1.10 kB —
/ui/thumbnail 10.64 kB 56.03 kB
/ui/time 11.36 kB 56.03 kB
/ui/time-slider 13.44 kB 56.03 kB
/ui/time-slider-chapter-title 9.10 kB 56.03 kB
/ui/time-slider-chapters 9.92 kB 56.03 kB
/ui/title 8.50 kB 56.03 kB
/ui/tooltip 10.15 kB 56.03 kB
/ui/tooltip-label 1.21 kB —
/ui/tooltip-shortcut 1.18 kB —
/ui/volume-indicator 13.31 kB 56.03 kB
/ui/volume-indicator-fill 1.11 kB —
/ui/volume-indicator-value 1.10 kB —
/ui/volume-popover 15.21 kB 56.03 kB
/ui/volume-slider 12.65 kB 56.03 kB
⚛️ @videojs/react — no changes
Presets (7)
Entry Initial Lazy
/video (default) 58.75 kB 56.03 kB
/video (default + hls) 59.36 kB 56.03 kB
/video (neutral) 58.80 kB 56.03 kB
/video (neutral + hls) 59.38 kB 56.03 kB
/audio (default) 45.66 kB 56.03 kB
/audio (neutral) 45.74 kB 56.03 kB
/background 921 B 56.03 kB
Media (22)
Entry Initial
/media/mux-video/hls-js 1.47 kB
/media/mux-video/spf 1.47 kB
/media/mux-audio/hls-js 1.15 kB
/media/mux-audio/spf 1.14 kB
/media/background-video 532 B
/media/cloudflare-video 1.88 kB
/media/dash-video 1.13 kB
/media/hls-audio 22.20 kB
/media/hls-background-video 17.60 kB
/media/hls-video 32.64 kB
/media/hlsjs-video 1.13 kB
/media/mux-audio 1.13 kB
/media/mux-background-video 17.63 kB
/media/mux-video 1.46 kB
/media/native-hls-video 6.19 kB
/media/shaka-video 1.13 kB
/media/spotify-audio 1.94 kB
/media/tiktok-video 1.88 kB
/media/twitch-video 1.89 kB
/media/vimeo-video 1.85 kB
/media/wistia-video 1.42 kB
/media/youtube-video 1.86 kB
Extensions (2)
Entry Initial
/extensions/google-cast 613 B
/extensions/mux-data 665 B
Players (5)
Entry Initial Lazy
/video/player 8.68 kB 56.03 kB
/audio/player 4.90 kB 56.03 kB
/background/player 3.16 kB 56.03 kB
/live-video/player 8.07 kB 56.03 kB
/live-audio/player 4.91 kB 56.03 kB
Skins (26)
Entry Type Initial Lazy
/video/compat-skin.css css 7.35 kB —
/video/neutral-skin.css css 8.16 kB —
/video/skin.css css 7.86 kB —
/video/compat-skin js 59.56 kB 56.03 kB
/video/neutral-skin js 58.72 kB 56.03 kB
/video/skin js 58.72 kB 56.03 kB
/audio/compat-skin.css css 5.97 kB —
/audio/neutral-skin.css css 5.89 kB —
/audio/skin.css css 5.60 kB —
/audio/compat-skin js 50.66 kB 56.03 kB
/audio/neutral-skin js 45.57 kB 56.03 kB
/audio/skin js 45.53 kB 56.03 kB
/background/skin.css css 97 B —
/background/skin js 516 B —
/live-video/compat-skin.css css 6.81 kB —
/live-video/neutral-skin.css css 6.65 kB —
/live-video/skin.css css 6.55 kB —
/live-video/compat-skin js 55.54 kB 56.03 kB
/live-video/neutral-skin js 48.55 kB 56.03 kB
/live-video/skin js 48.57 kB 56.03 kB
/live-audio/compat-skin.css css 5.48 kB —
/live-audio/neutral-skin.css css 4.58 kB —
/live-audio/skin.css css 4.47 kB —
/live-audio/compat-skin js 41.85 kB 56.03 kB
/live-audio/neutral-skin js 33.86 kB 56.03 kB
/live-audio/skin js 33.86 kB 56.03 kB
UI Components (39)
Entry Initial Lazy
/ui/airplay-button 11.28 kB 56.03 kB
/ui/alert-dialog 5.21 kB 56.03 kB
/ui/audio-track 8.40 kB 56.03 kB
/ui/audio-track-radio-group 10.74 kB 56.03 kB
/ui/buffering-indicator 8.45 kB 56.03 kB
/ui/captions-button 11.26 kB 56.03 kB
/ui/captions-radio-group 10.81 kB 56.03 kB
/ui/cast-button 11.27 kB 56.03 kB
/ui/controls 8.34 kB 56.03 kB
/ui/dialog 5.20 kB 56.03 kB
/ui/error-dialog 12.66 kB 56.03 kB
/ui/fullscreen-button 11.24 kB 56.03 kB
/ui/gesture 8.61 kB 56.03 kB
/ui/hotkey 9.03 kB 56.03 kB
/ui/live-button 9.58 kB 56.03 kB
/ui/menu 22.05 kB 56.03 kB
/ui/mute-button 11.28 kB 56.03 kB
/ui/pip-button 11.24 kB 56.03 kB
/ui/play-button 11.20 kB 56.03 kB
/ui/playback-rate 8.45 kB 56.03 kB
/ui/playback-rate-button 11.20 kB 56.03 kB
/ui/playback-rate-radio-group 10.81 kB 56.03 kB
/ui/popover 9.12 kB 56.03 kB
/ui/poster 8.65 kB 56.03 kB
/ui/quality 8.82 kB 56.03 kB
/ui/quality-radio-group 11.15 kB 56.03 kB
/ui/seek-button 11.24 kB 56.03 kB
/ui/seek-indicator 13.12 kB 56.03 kB
/ui/slider 14.43 kB 56.03 kB
/ui/status-announcer 10.88 kB 56.03 kB
/ui/status-indicator 13.40 kB 56.03 kB
/ui/thumbnail 9.82 kB 56.03 kB
/ui/time 10.66 kB 56.03 kB
/ui/time-slider 16.18 kB 56.03 kB
/ui/title 7.93 kB 56.03 kB
/ui/tooltip 9.98 kB 56.03 kB
/ui/volume-indicator 13.43 kB 56.03 kB
/ui/volume-popover 15.58 kB 56.03 kB
/ui/volume-slider 13.02 kB 56.03 kB
🧩 @videojs/core — no changes
Entries (76)
Entry Initial Lazy
. 13.48 kB —
/dom 23.92 kB 56.03 kB
/vjsc 1.90 kB —
/i18n 3.20 kB 56.03 kB
/i18n/locales/all 33.91 kB —
/i18n/locales/ar 1.16 kB —
/i18n/locales/az 1.08 kB —
/i18n/locales/bg 1.29 kB —
/i18n/locales/bn 1.25 kB —
/i18n/locales/bs 1.02 kB —
/i18n/locales/ca 1.04 kB —
/i18n/locales/cs 1.10 kB —
/i18n/locales/cy 1.02 kB —
/i18n/locales/da 984 B —
/i18n/locales/de 1.06 kB —
/i18n/locales/el 1.42 kB —
/i18n/locales/en 801 B —
/i18n/locales/es 999 B —
/i18n/locales/et 1.02 kB —
/i18n/locales/eu 1.04 kB —
/i18n/locales/fa 1.21 kB —
/i18n/locales/fi 1.05 kB —
/i18n/locales/fr 1.01 kB —
/i18n/locales/gd 1.09 kB —
/i18n/locales/gl 1017 B —
/i18n/locales/he 1.10 kB —
/i18n/locales/hi 1.25 kB —
/i18n/locales/hr 1.05 kB —
/i18n/locales/hu 1.10 kB —
/i18n/locales/id 953 B —
/i18n/locales/it 1.01 kB —
/i18n/locales/ja 1.16 kB —
/i18n/locales/ko 1.08 kB —
/i18n/locales/lt 1.04 kB —
/i18n/locales/lv 1.09 kB —
/i18n/locales/mr 1.23 kB —
/i18n/locales/nb 990 B —
/i18n/locales/ne 1.23 kB —
/i18n/locales/nl 1.01 kB —
/i18n/locales/nn 983 B —
/i18n/locales/oc 1.05 kB —
/i18n/locales/pl 1.11 kB —
/i18n/locales/pt 1.02 kB —
/i18n/locales/pt-BR 1.02 kB —
/i18n/locales/pt-PT 1.02 kB —
/i18n/locales/ro 1.04 kB —
/i18n/locales/ru 1.36 kB —
/i18n/locales/sk 1.10 kB —
/i18n/locales/sl 1.04 kB —
/i18n/locales/sr 1.05 kB —
/i18n/locales/sv 1.01 kB —
/i18n/locales/te 1.29 kB —
/i18n/locales/th 1.20 kB —
/i18n/locales/tr 1.00 kB —
/i18n/locales/uk 1.37 kB —
/i18n/locales/vi 1.10 kB —
/i18n/locales/zh 1.01 kB —
/i18n/locales/zh-CN 1.01 kB —
/i18n/locales/zh-TW 1.02 kB —
/i18n/text/airplay 101 B —
/i18n/text/buttons 137 B —
/i18n/text/captions 93 B —
/i18n/text/cast 114 B —
/i18n/text/common 90 B —
/i18n/text/container 75 B —
/i18n/text/errors 285 B —
/i18n/text/fullscreen 98 B —
/i18n/text/live 126 B —
/i18n/text/menu 249 B —
/i18n/text/pip 101 B —
/i18n/text/playback 80 B —
/i18n/text/seek 105 B —
/i18n/text/slider 65 B —
/i18n/text/status 222 B —
/i18n/text/time 322 B —
/i18n/text/volume 133 B —
🏷️ @videojs/element — no changes
Entries (2)
Entry Initial
. 1.05 kB
/context 1.15 kB
📦 @videojs/store — no changes
Entries (3)
Entry Initial
. 1.85 kB
/html 703 B
/react 511 B
🔧 @videojs/utils — no changes
Entries (13)
Entry Initial
/array 271 B
/dom 5.25 kB
/events 320 B
/function 414 B
/i18n 249 B
/jwt 176 B
/object 535 B
/predicate 297 B
/percent 281 B
/string 239 B
/style 212 B
/time 1018 B
/number 199 B
📦 @videojs/cdn — no changes
📦 @videojs/cloudflare-video — no changes
📦 @videojs/dash-video — no changes
📦 @videojs/google-cast — no changes
📦 @videojs/hlsjs-video — no changes
📦 @videojs/media — no changes
Entries (3)
Entry Initial
. 3.22 kB
/dom 4.00 kB
/media-tracks 2.05 kB
📦 @videojs/mux — no changes
📦 @videojs/mux-audio — no changes
Entries (2)
Entry Initial
. 136.01 kB
/spf 22.76 kB
📦 @videojs/mux-data — no changes
📦 @videojs/mux-video — no changes
Entries (2)
Entry Initial
. 135.92 kB
/spf 32.99 kB
📦 @videojs/native-hls-video — no changes
📦 @videojs/shaka-video — no changes
📦 @videojs/spf — no changes
Entries (7)
Entry Initial
. 4.56 kB
/dom 7.85 kB
/hls 28.40 kB
/media-tracks 507 B
/hls-background-video 16.60 kB
/hls-audio 21.28 kB
/hls-video 31.73 kB
📦 @videojs/spotify-audio — no changes
📦 @videojs/tiktok-video — no changes
📦 @videojs/twitch-video — no changes
📦 @videojs/other — no changes
Entries (3)
Entry Initial Lazy
video.js 74.32 kB 56.03 kB
video.js/package.json 608 B —
video.js/errors 1.03 kB —
📦 @videojs/vimeo-video — no changes
📦 @videojs/wistia-video — no changes
Entries (2)
Entry Initial
. 1.91 kB
/helpers 1.76 kB
📦 @videojs/youtube-video — no changes

ℹ️ How to interpret

Each entry is independently bundled, minified, and brotli-compressed. Initial size includes its static import graph; lazy dynamic chunks are reported separately.

Entries are not additive because their dependency graphs overlap. Preset rows represent realistic combined bundles.

Changes of 300 B or less across initial, lazy, and total size are collapsed, not discarded.

Run pnpm size locally to check current initial sizes.

Also explain the local Simplify copy, and drop @internal from
InferSliceSourceState, which player config inference now exposes.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01WLkDiofiR86hzNgRopBotH
@netlify

netlify Bot commented Sep 30, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for vjs10-site ready!

Name Link
🔨 Latest commit 2f6469c
🔍 Latest deploy log https://app.netlify.com/projects/vjs10-site/deploys/6abecd0f19e0330008f6641e
😎 Deploy Preview https://deploy-preview-3083--vjs10-site.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify

netlify Bot commented Sep 30, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for vjs-registry ready!

Name Link
🔨 Latest commit 2f6469c
🔍 Latest deploy log https://app.netlify.com/projects/vjs-registry/deploys/6abecd0f3819e00008b09341
😎 Deploy Preview https://deploy-preview-3083--vjs-registry.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@decepulis decepulis left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agent review (part of the stack review; see #3063 for method). The tags match the claimed list, no docs page, demo, sandbox template or e2e test imports a newly internal store export, the three store entries are enumerated by the checker, and I walked the documented hooks/controllers' signatures by hand: none names an @internal export, and the checker agrees.

Inline: 🔴 StoreOptions and the StoreCallbacks/Store*Context chain stay stable through the useStore companion heuristic (root cause on #3063), so answer H is only half applied for createStore; 🟡 the local Simplify copy is no longer needed and its comment contradicts the file; 🟡 README consistency.

🟣 Decision for rahim on how far H goes: createSelector<S extends AnySlice> is documented, so by answer 1 AnySlice → Slice → SliceConfig → StateContext / AttachContext / DerivedContext / DerivedDefinition / AbortControllerRegistry / SignalKey are all stable by reference (the checker lists 30 store exports as "stable by reference"). Net effect: the authoring functions (defineSlice, createStore, createState, combine, flush) are internal, but the slice/store configuration contracts they take are a stability commitment. If that isn't intended, the documented signatures need to stop naming the slice internals (e.g. an opaque AnySlice with the config details behind @internal members); if it is, the description should say "functions internal, contracts stable" so nobody is surprised later.

Minor: the description's "except InferSliceSourceState" is slightly imprecise; InferSliceState (via createSelector's return type) and UnionSliceState (via html PlayerStore) are also untagged, and correctly so.


Generated by Claude Code

Comment thread packages/store/src/core/store.ts Resolved
Comment thread packages/store/src/core/slice.ts Resolved
Comment thread packages/store/README.md Resolved
claude added 2 commits October 1, 2026 00:35
The check no longer counts `StoreOptions` as a companion of the `useStore` page. Only `createStore` and `StoreFactory` use it, so it and the callback and context types it reaches are internal like the rest of store's authoring API.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01WLkDiofiR86hzNgRopBotH
claude added 2 commits October 1, 2026 00:43
… tags

- The local Simplify copy is gone: the stability check counts @videojs/utils aliases as written out where they're used, as it already does for UnionToIntersection in the same file.
- The README's note lists the primitives this PR tags internal and names the store APIs that stay stable, and the State Primitives section no longer invites direct use.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01WLkDiofiR86hzNgRopBotH
`createSelector` is documented, so the slice it takes was stable by
reference, and with it the whole authoring contract: `SliceConfig`,
`StateContext`, `AttachContext`, `DerivedContext`, and
`AbortControllerRegistry`. Store authoring APIs are internal for now,
so brand `Slice`, tag its members `@internal`, and keep `SliceConfig`
as the internal input `defineSlice` brands. Type-only; runtime is
unchanged.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01WLkDiofiR86hzNgRopBotH
claude added 2 commits October 1, 2026 18:33
The slice brand guards the public `createSelector` boundary; the
internal `createStore` can accept an unbranded config with an explicit
state type, as main's element tests do.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01WLkDiofiR86hzNgRopBotH
Comment thread packages/store/README.md Resolved

@luwes luwes left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

…rthy-7ams8m-store

# Conflicts:
#	packages/html/src/ui/live-button/tests/element.test.ts
#	packages/html/src/ui/time-slider/tests/element.test.ts
@decepulis
decepulis merged commit 8aed7b4 into main Oct 1, 2026
16 checks passed
@decepulis
decepulis deleted the claude/keen-mccarthy-7ams8m-store branch October 1, 2026 21:17

This branch was successfully deployed

1 active deployment
Preview — 2f6469cc Deployed Oct 1, 2026 by vercel[bot]
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants