Repository navigation
Conversation
Remove `@videojs/store` from the stability checker's unchecked packages and run `--fix`, so store follows the same rule as the rest of Video.js: exports documented on a reference page or referenced by a stable export's types are stable, and the rest are `@internal`. `InferSliceState` uses a local `Simplify` so the internal utils type stays out of store's public types. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WLkDiofiR86hzNgRopBotH
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
@videojs/cdn
@videojs/cli
@videojs/core
@videojs/element
@videojs/html
@videojs/media
@videojs/react
@videojs/spf
@videojs/store
@videojs/utils
@videojs/cloudflare-video
@videojs/dash-video
@videojs/hlsjs-video
@videojs/mux-audio
@videojs/mux-video
@videojs/native-hls-video
@videojs/shaka-video
@videojs/spotify-audio
@videojs/tiktok-video
@videojs/twitch-video
@videojs/vimeo-video
@videojs/wistia-video
@videojs/youtube-video
@videojs/google-cast
@videojs/mux-data
commit: |
📦 Bundle Size Report🎨 @videojs/html — no changesPresets (7)
Media (18)
Players (5)
Skins (41)
UI Components (62)
⚛️ @videojs/react — no changesPresets (7)
Media (22)
Extensions (2)
Players (5)
Skins (26)
UI Components (39)
🧩 @videojs/core — no changesEntries (76)
🏷️ @videojs/element — no changesEntries (2)
📦 @videojs/store — no changesEntries (3)
🔧 @videojs/utils — no changesEntries (13)
📦 @videojs/cdn — no changes📦 @videojs/cloudflare-video — no changes📦 @videojs/dash-video — no changes📦 @videojs/google-cast — no changes📦 @videojs/hlsjs-video — no changes📦 @videojs/media — no changesEntries (3)
📦 @videojs/mux — no changes📦 @videojs/mux-audio — no changesEntries (2)
📦 @videojs/mux-data — no changes📦 @videojs/mux-video — no changesEntries (2)
📦 @videojs/native-hls-video — no changes📦 @videojs/shaka-video — no changes📦 @videojs/spf — no changesEntries (7)
📦 @videojs/spotify-audio — no changes📦 @videojs/tiktok-video — no changes📦 @videojs/twitch-video — no changes📦 @videojs/other — no changesEntries (3)
📦 @videojs/vimeo-video — no changes📦 @videojs/wistia-video — no changesEntries (2)
📦 @videojs/youtube-video — no changesℹ️ How to interpretEach entry is independently bundled, minified, and brotli-compressed. Initial size includes its static import graph; lazy dynamic chunks are reported separately. Entries are not additive because their dependency graphs overlap. Preset rows represent realistic combined bundles. Changes of 300 B or less across initial, lazy, and total size are collapsed, not discarded. Run |
…rthy-7ams8m-store
Also explain the local Simplify copy, and drop @internal from InferSliceSourceState, which player config inference now exposes. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WLkDiofiR86hzNgRopBotH
…rthy-7ams8m-store
✅ Deploy Preview for vjs10-site ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for vjs-registry ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
…rthy-7ams8m-store
…rthy-7ams8m-store
decepulis
left a comment
There was a problem hiding this comment.
Agent review (part of the stack review; see #3063 for method). The tags match the claimed list, no docs page, demo, sandbox template or e2e test imports a newly internal store export, the three store entries are enumerated by the checker, and I walked the documented hooks/controllers' signatures by hand: none names an @internal export, and the checker agrees.
Inline: 🔴 StoreOptions and the StoreCallbacks/Store*Context chain stay stable through the useStore companion heuristic (root cause on #3063), so answer H is only half applied for createStore; 🟡 the local Simplify copy is no longer needed and its comment contradicts the file; 🟡 README consistency.
🟣 Decision for rahim on how far H goes: createSelector<S extends AnySlice> is documented, so by answer 1 AnySlice → Slice → SliceConfig → StateContext / AttachContext / DerivedContext / DerivedDefinition / AbortControllerRegistry / SignalKey are all stable by reference (the checker lists 30 store exports as "stable by reference"). Net effect: the authoring functions (defineSlice, createStore, createState, combine, flush) are internal, but the slice/store configuration contracts they take are a stability commitment. If that isn't intended, the documented signatures need to stop naming the slice internals (e.g. an opaque AnySlice with the config details behind @internal members); if it is, the description should say "functions internal, contracts stable" so nobody is surprised later.
Minor: the description's "except InferSliceSourceState" is slightly imprecise; InferSliceState (via createSelector's return type) and UnionSliceState (via html PlayerStore) are also untagged, and correctly so.
Generated by Claude Code
…rthy-7ams8m-store
The check no longer counts `StoreOptions` as a companion of the `useStore` page. Only `createStore` and `StoreFactory` use it, so it and the callback and context types it reaches are internal like the rest of store's authoring API. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WLkDiofiR86hzNgRopBotH
…rthy-7ams8m-store
… tags - The local Simplify copy is gone: the stability check counts @videojs/utils aliases as written out where they're used, as it already does for UnionToIntersection in the same file. - The README's note lists the primitives this PR tags internal and names the store APIs that stay stable, and the State Primitives section no longer invites direct use. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WLkDiofiR86hzNgRopBotH
…rthy-7ams8m-store
…rthy-7ams8m-store
…rthy-7ams8m-store
`createSelector` is documented, so the slice it takes was stable by reference, and with it the whole authoring contract: `SliceConfig`, `StateContext`, `AttachContext`, `DerivedContext`, and `AbortControllerRegistry`. Store authoring APIs are internal for now, so brand `Slice`, tag its members `@internal`, and keep `SliceConfig` as the internal input `defineSlice` brands. Type-only; runtime is unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WLkDiofiR86hzNgRopBotH
…rthy-7ams8m-store
The slice brand guards the public `createSelector` boundary; the internal `createStore` can accept an unbranded config with an explicit state type, as main's element tests do. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WLkDiofiR86hzNgRopBotH
…rthy-7ams8m-store
…rthy-7ams8m-store # Conflicts: # packages/html/src/ui/live-button/tests/element.test.ts # packages/html/src/ui/time-slider/tests/element.test.ts
…rthy-7ams8m-store
…rthy-7ams8m-store
…rthy-7ams8m-store
…rthy-7ams8m-store
Part 7 of the API stability stack: #3073 → #3063 → #3066 → #3067 → #3082 → #3068 → this PR. It's the last PR so the store decision can be reviewed, or dropped, by itself.
Summary
Store now follows the same stability rule as the rest of Video.js. Exports that a reference page documents, or that a stable export's types reference, are stable; everything else is
@internal. Store's authoring APIs stay internal for now, as the maintainers decided, and that includes the slice contracts they take.packages/store/is no longer skipped (site/scripts/check-api-stability.ts).AGENTS.mdnow says only SPF is unchecked.Sliceis now a branded interface whose members are all@internal. That way, documentingcreateSelectorno longer makes the slice authoring contract stable (Rahim chose option (b) in Slack).SliceConfigis the internal, unbranded input thatdefineSlicebrands.combineanddefinePlayerFeaturebrand their results the same way, and the internalcreateStorealso accepts a plain config.createSelectorno longer accepts a literal with slice members. A type test inselector.test.tscovers that.--fixtagged store exports@internal:@videojs/store:createStore,isStore,StoreFactory,InferStoreTargetStoreOptionsand the types it reaches:StoreCallbacks,StoreSetupContext,StoreAttachContext,StoreErrorContextdefineSlice,SliceFactory,SliceConfig,Attach, and theInferSlice*/UnionSlice*helpers that no stable signature namesStateContext,AttachContext,AttachStore,DerivedContext,DerivedDefinition,AbortControllerRegistry,SignalKeycreateState,isState,WritableState,flush,combineStoreError/isStoreError/throw*Errorhelpers@videojs/store/html:StoreAccessor,StoreAccessorHostusePlayerandPlayerController, and lists the store APIs that stay stable.What stays stable
useStore,useSelector,useSnapshot,createSelector,shallowEqual,StoreController,SnapshotController,SubscriptionController.Store,StateandUnknownStore.InferSliceSourceState,InferSliceState,UnionSliceState.SliceandAnySlice, only as opaque names you pass tocreateSelector.Store's stable-by-reference list drops from 30 exports to 19.
If the authoring APIs should become public later, the fix is a reference page plus removing the member tags on
Slice. The check then treats the contexts as stable automatically.Preview pages
None. This PR changes no site pages; its preview matches #3068's. The one reader-facing change is the store README note.
Testing
pnpm -F site check:api-stability: all 1,966 checked exports are documented, referenced or tagged (1,224 stable, 19 experimental, 723 internal). The extra exports since the first run come from chore: tag undocumented public exports @internal and enforce it in CI #3068's public i18n APIs and frommain's feat(react): add mediaRef prop to media components #3098 and feat(skin): add compat skin #3026.pnpm typecheck: pass.pnpm lint,astro check --minimumSeverity warning: pass.🤖 Generated with Claude Code
https://claude.ai/code/session_01WLkDiofiR86hzNgRopBotH