feat(kitchen-sink): add churnDb actor and seed driver for compaction read-hotshard repro - #5398
Conversation
ReviewScope note: this diff (as computed against the current base) also carries roughly 600 lines of unrelated changes: three small Rust edits and a large self-host/dev* to self-host/compose/dev* rename with zero content diff. The rename is almost certainly diff noise from the branch being behind main rather than something this PR intentionally did, so it is worth rebasing before merge so reviewers and CI see only the real diff. The three Rust edits do look intentional, but they are unrelated to the stated "add churnDb actor" purpose:
Recommend splitting these three into a separate PR, or at least calling them out explicitly in the description, so the dedup-window change gets reviewed on its own merits. examples/kitchen-sink/src/actors/testing/churn-db.ts
examples/kitchen-sink/scripts/seed-churn-dbs.ts
No automated test coverage was added for churnDb, but that matches the existing growDb fixture, which also has none. This is consistent with precedent for this kind of manual load-testing actor, not a new gap introduced here. Summary The core feature (churnDb actor plus seed script) is well-structured and consistent with the existing growDb precedent. Main asks: split out or explain the unrelated Rust changes, especially the dedup-window bump, and consider hardening ensureWorkingSet against a shrinking workingSetRows across resumed calls. |
d75b5fc to
4411342
Compare
4411342 to
65314cc
Compare
…read-hotshard repro
65314cc to
74c27c0
Compare
No description provided.