Skip to content

chore: Clean up - #5397

Open
MasterPtato wants to merge 1 commit into
stack/slopfix-docs-self-hosting-correct-postgres-config-format-and-document-single-vs-multi-node-nats-ponuwvymfrom
stack/chore-clean-up-mnloxsnm
Open

chore: Clean up#5397
MasterPtato wants to merge 1 commit into
stack/slopfix-docs-self-hosting-correct-postgres-config-format-and-document-single-vs-multi-node-nats-ponuwvymfrom
stack/chore-clean-up-mnloxsnm

Conversation

@MasterPtato

@MasterPtato MasterPtato commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@MasterPtato

MasterPtato commented Jul 10, 2026

Copy link
Copy Markdown
Contributor Author

Stack for rivet-dev/rivet

Get stack: forklift get 5397
Push local edits: forklift submit
Merge when ready: forklift merge 5397

change mnloxsnm

@claude

claude Bot commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

Review

Small, low-risk cleanup PR reverting what looks like temporary debug instrumentation. One issue to fix before merge.

Issues

engine/packages/gasoline/src/db/kv/mod.rs — leftover dead variable

async fn publish_signal(...) -> WorkflowResult<()> {
    let started_at = Instant::now();
    self.pools
        ...

started_at (line 2607) was only ever read by the tracing::info! block that this PR removes. It's now an unused local — cargo check/clippy will flag it as an unused-variable warning, and depending on CI's warning policy this could fail the build. Please remove the let started_at = Instant::now(); line (and the now-unnecessary Instant import if it becomes unused elsewhere in the file — a quick grep shows Instant is still used by db/kv/system.rs but worth double-checking mod.rs itself doesn't lose its only remaining use).

Other changes

self-host/compose/template/src/docker-compose.ts — drops RIVET_OTEL_SAMPLER_RATIO=1

Without this override, engine/packages/metrics-server/src/providers.rs falls back to its default of 0.001 (0.1% trace sampling) for the local dev compose stack. That's presumably intended here (reverting a temporary 100%-sampling debug aid alongside the log line above), but since the PR has no description, it's worth confirming this is deliberate and not an accidental side effect — dev-environment tracing will become much sparser by default after this change. Per CLAUDE.md, this edit correctly targets the template source (self-host/compose/template/) rather than a generated self-host/compose/dev* file, so no regen step is missing there.

Test coverage

No tests included, but neither change has behavior worth covering with a new test — this is pure debug-logging/config removal with no new logic.

Summary

Straightforward cleanup. Fix the unused started_at variable before merging; the otel sampler ratio removal is likely fine but worth a one-line confirmation in the PR description.

@MasterPtato
MasterPtato changed the base branch from stack/slopfix-docs-self-hosting-correct-postgres-config-format-and-document-single-vs-multi-node-nats-ponuwvym to main August 7, 2026 00:39
@MasterPtato
MasterPtato force-pushed the stack/chore-clean-up-mnloxsnm branch from 07c03c2 to 9ee4cfe Compare August 7, 2026 01:27
@MasterPtato
MasterPtato changed the base branch from main to stack/slopfix-docs-self-hosting-correct-postgres-config-format-and-document-single-vs-multi-node-nats-ponuwvym August 7, 2026 01:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant