You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
started_at (line 2607) was only ever read by the tracing::info! block that this PR removes. It's now an unused local — cargo check/clippy will flag it as an unused-variable warning, and depending on CI's warning policy this could fail the build. Please remove the let started_at = Instant::now(); line (and the now-unnecessary Instant import if it becomes unused elsewhere in the file — a quick grep shows Instant is still used by db/kv/system.rs but worth double-checking mod.rs itself doesn't lose its only remaining use).
Without this override, engine/packages/metrics-server/src/providers.rs falls back to its default of 0.001 (0.1% trace sampling) for the local dev compose stack. That's presumably intended here (reverting a temporary 100%-sampling debug aid alongside the log line above), but since the PR has no description, it's worth confirming this is deliberate and not an accidental side effect — dev-environment tracing will become much sparser by default after this change. Per CLAUDE.md, this edit correctly targets the template source (self-host/compose/template/) rather than a generated self-host/compose/dev* file, so no regen step is missing there.
Test coverage
No tests included, but neither change has behavior worth covering with a new test — this is pure debug-logging/config removal with no new logic.
Summary
Straightforward cleanup. Fix the unused started_at variable before merging; the otel sampler ratio removal is likely fine but worth a one-line confirmation in the PR description.
MasterPtato
changed the base branch from
stack/slopfix-docs-self-hosting-correct-postgres-config-format-and-document-single-vs-multi-node-nats-ponuwvym
to
mainAugust 7, 2026 00:39
MasterPtato
changed the base branch from
main
to
stack/slopfix-docs-self-hosting-correct-postgres-config-format-and-document-single-vs-multi-node-nats-ponuwvymAugust 7, 2026 01:27
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.