Conversation
# Conflicts: # .github/workflows/ci.yml # examples/compile.ts # packages/native/src/custom_elements/anchored.rs # packages/native/src/custom_elements/code.rs # packages/native/src/custom_elements/diff.rs # packages/native/src/custom_elements/img.rs # packages/native/src/custom_elements/input.rs # packages/native/src/custom_elements/markdown.rs # packages/native/src/renderer.rs # packages/react/src/types/host.ts # zed
This was referenced Sep 4, 2026
mateo-m
force-pushed
the
feat/css-values-and-classname
branch
from
September 4, 2026 14:58
d823135 to
26d58a0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this adds
The commits of feat/css-values-and-classname:
widthandheightaccept css lengths.corner-shapeand cursor keywords.heighttoauto, measures the content at the resolved width, and collapses from the height auto reached.rendertakes root options and exposes the renderer.keyworks on a built-in tag, and compiled example apps get signed.What I ran and saw
cargo testin packages/native at this branch: 291 passed, 0 failed.lineHeight: 20read as a multiple. Both fixes are in this branch, with tests.lineHeightnumber is pixels, as upstream reads it. Only a string gets the css multiple reading. A unit test covers each reading.What I did not verify
Moved from the fork
This PR was mateo-m#1.
The branch merged upstream main twice, at 3e2d121 and at 028f70a. The second merge takes the batch-only mutation API, the root key handlers, click through
on_mouse_upand the object form of a gradient background. The object form keeps itscolorSpace:Scope::gradientbuilds the GPUI gradient in sRGB or Oklab. The text form stays sRGB, because lightningcss does not parsein oklab.The history was rewritten once after the first push. It dropped the commits that reworded AGENTS.md, and the zed pin moved to the rewritten mateo-m/zed branches. No code changed in that rewrite.
On the merged head:
cargo test318 passed, 0 failed, the react suite 458 passed, 0 failed, the examples suite 64 passed, 0 failed.bun run buildin packages/native regeneratedindex.d.ts.Bottom of the stack.
The zed submodule points at the mateo-m/zed fork until remorses/zed#5, #6 and #7 merge. Then a follow-up commit restores
.gitmodulesto remorses/zed on thegpuixbranch and pins the merged commit. The same GPUI stack is also open upstream as zed-industries/zed#63771, #63772 and #63773.