feat(native): map filter, backdrop-filter, mask-image and blend modes onto effect layers - #52
Closed
mateo-m wants to merge 66 commits into
Closed
feat(native): map filter, backdrop-filter, mask-image and blend modes onto effect layers#52mateo-m wants to merge 66 commits into
mateo-m wants to merge 66 commits into
Conversation
… onto effect layers
# Conflicts: # packages/native/src/style/resolve.rs
# Conflicts: # .github/workflows/ci.yml # examples/compile.ts # packages/native/src/custom_elements/anchored.rs # packages/native/src/custom_elements/code.rs # packages/native/src/custom_elements/diff.rs # packages/native/src/custom_elements/img.rs # packages/native/src/custom_elements/input.rs # packages/native/src/custom_elements/markdown.rs # packages/native/src/renderer.rs # packages/react/src/types/host.ts # zed
# Conflicts: # zed
This was referenced Sep 4, 2026
mateo-m
force-pushed
the
feat/layer-effects
branch
from
September 4, 2026 14:58
6b3322a to
a91ef51
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contains #51.
What this adds
filter,backdrop-filter,mask-image,mix-blend-mode,background-blend-modeandoverscroll-behavior.An element with any of the first four paints itself and its children into a texture of its own, and the GPU paints that texture over the frame with the effect.
blur()is a two-pass Gaussian on a shrunk texture, so a wide blur costs the same as a narrow one. The other filter functions fold into one colour matrix.mask-imagetakes a gradient and keeps each pixel by its alpha. Over abackdrop-filter: blur()the alpha scales the blur radius instead, so an eased mask gives a progressive blur. All sixteen blend modes of Compositing and Blending 1 plusplus-lighterpaint.background-imagenow paints overbackground-colorinstead of replacing it. A rounded scroll box now clips at its corner arcs, and the scroll range ends at the far edge of the content.The zed bump brings the effect layer render passes in gpui (Metal, wgpu, DirectX) and the per-fragment gradient easing, which replaces the hint approximation of #51.
What I ran and saw
cargo testat this branch: 295 passed, 0 failed.backdropFilter,maskImageandoverscrollBehavior.What I did not verify
Moved from the fork
This PR was mateo-m#3.
The branch merged its parent branch after that one merged upstream main at 028f70a.
The history was rewritten once after the first push. It dropped the commits that reworded AGENTS.md, and the zed pin moved to the rewritten mateo-m/zed branches. No code changed in that rewrite.
On the merged head
cargo checkandtscpass. The full suites ran at the bottom and at the top of the stack.Stacked on #51. The diff here includes #50, #51.
The zed submodule points at the mateo-m/zed fork until remorses/zed#5, #6 and #7 merge. Then a follow-up commit restores
.gitmodulesto remorses/zed on thegpuixbranch and pins the merged commit. The same GPUI stack is also open upstream as zed-industries/zed#63771, #63772 and #63773.