feat(native): ease the mix between two gradient stops - #51
Closed
mateo-m wants to merge 48 commits into
Closed
Conversation
# Conflicts: # .github/workflows/ci.yml # examples/compile.ts # packages/native/src/custom_elements/anchored.rs # packages/native/src/custom_elements/code.rs # packages/native/src/custom_elements/diff.rs # packages/native/src/custom_elements/img.rs # packages/native/src/custom_elements/input.rs # packages/native/src/custom_elements/markdown.rs # packages/native/src/renderer.rs # packages/react/src/types/host.ts # zed
This was referenced Sep 4, 2026
mateo-m
force-pushed
the
feat/eased-gradients
branch
from
September 4, 2026 14:58
41615d0 to
3ecdb80
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contains #50.
What this adds
An
<easing-function>between two colour stops bends the mix, following the CSSWG proposal in csswg-drafts issue 1332:linear-gradient(to top, black, ease-in-out, transparent).ease,ease-in,ease-out,ease-in-outandcubic-bezier()are read.On this branch the easing paints as the GPUI colour hint whose curve crosses one half at the same place. That matches the true curve at both ends and at the midpoint. The next branch bumps the zed pin and solves the curve per fragment in the shader, which replaces the approximation. An explicit hint in the css wins over the easing.
What I ran and saw
cargo testat this branch: 294 passed, 0 failed. Unit tests cover the half-point search and the explicit-hint priority.What I did not verify
Moved from the fork
This PR was mateo-m#2.
The branch merged its parent branch after that one merged upstream main at 028f70a.
The history was rewritten once after the first push. It dropped the commits that reworded AGENTS.md, and the zed pin moved to the rewritten mateo-m/zed branches. No code changed in that rewrite.
On the merged head
cargo checkandtscpass. The full suites ran at the bottom and at the top of the stack.Stacked on #50. The diff here includes #50.
The zed submodule points at the mateo-m/zed fork until remorses/zed#5, #6 and #7 merge. Then a follow-up commit restores
.gitmodulesto remorses/zed on thegpuixbranch and pins the merged commit. The same GPUI stack is also open upstream as zed-industries/zed#63771, #63772 and #63773.