Repository navigation
refactor(billing): remove embedded split-line history - #5356
Merged
Merged
Conversation
Contributor
|
No actionable comments were generated in the recent review.
 |
| Layer / File(s) | Summary |
|---|---|
Invoice-line history contract openmeter/billing/stdinvoiceline.go, openmeter/billing/gatheringinvoice.go, openmeter/billing/lineengine/*, openmeter/billing/rating/*, openmeter/billing/README.md |
Standard and gathering lines no longer store split-line hierarchies. Rating tests provide history separately. The README describes changes to event and public representations. |
Invoice reads and explicit history lookup openmeter/billing/adapter/*, openmeter/billing/service/invoice.go, openmeter/billing/worker/subscriptionsync/*, test/billing/*, test/credits/* |
Invoice read paths no longer expand split-line history. Subscription-sync and test paths retrieve persisted groups by split-group ID when needed. Tests check that ordinary reads do not query history. |
Transient simulation history openmeter/billing/stdinvoice.go, openmeter/billing/service/invoice.go, test/billing/invoice_test.go |
SimulateInvoiceInput accepts hierarchies keyed by split-group ID. Tests verify simulation behavior without persisted-history queries or invoice writes. |
Priority:
Estimated code review effort: 3 (Moderate) | ~25 minutes
Change: Refactor
Possibly related PRs
- openmeterio/openmeter#5333: Changes persisted split-line history records and hierarchy mapping used by explicit history reads.
- openmeterio/openmeter#5341: Adds legacy rating support for supplied split-line history, which this change continues through simulation input.
Suggested reviewers: galexihu, borosr
Merge Risk: 
0ec83
-
No actionable issue is established in the supplied changes; the PR appears mergeable after normal checks.
Pre-merge checks: 
-
Check name Status Explanation Description Check Check skipped - CodeRabbit’s high-level summary is enabled. Title check The title clearly and concisely describes the main change: removing embedded split-line history from billing models and flows. Linked Issues check Check skipped because no linked issues were found for this pull request. Out of Scope Changes check Check skipped because no linked issues were found for this pull request.
Finishing Touches
-
📝 Generate docstrings
-
- Commit to this branch
- Create a new PR
🧪 Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
borosr
approved these changes
Oct 26, 2026
This was referenced Oct 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Ordinary invoice reads still attach split-line history to every line even though the legacy engine resolves that history explicitly. Remove the embedded hierarchy fields, automatic adapter expansion, and the gathering-preview reload that existed solely to obtain history. Lines retain their split-group IDs, and calculation continues to use the engine-owned full-history resolver.
Simulation now accepts supplied transient histories on the Go service input, keyed by split-group ID, so association survives generated line IDs and namespace normalization without group reads or persistence.
Notes for reviewer
Follows #5341. The public HTTP simulation contract is unchanged; complete supplied-history simulation remains an internal Go service capability. Internal invoice event snapshots omit the former optional hierarchy expansions. No schema changes or changes to the documented legacy cancellation-ordering limitation.
Validation: PostgreSQL billing and subscription-sync suites; billing domain, legacy engine, rating, HTTP, and notification-event contract tests; affected-consumer and e2e-module vet; scoped fast Go lint.
Summary by CodeRabbit
The PR appears safe to merge; no actionable issues were found.Summary
Removes embedded split history from invoice lines while keeping
SplitLineGroupID.Review was based on code and tests; no tests were executed.
Diagram
%%{init: {'theme': 'neutral'}}%% flowchart TD A[Ordinary invoice read] --> B[Line snapshots with split-group IDs] C[Persisted calculation or gathering preview] --> D[Legacy engine] D --> E[Load persisted split history] E --> F[Snapshot quantities and rate] G[Go simulation input] --> H[Normalize line IDs and namespaces] H --> I[Find supplied history by split-group ID] I --> J[Rate cloned lines without group reads]Reviews (1) · Last reviewed commit: "refactor(billing): remove embedded split..." · Reviewed by Greptile