feat: restrict which plugin marketplaces Codex can use#21458
feat: restrict which plugin marketplaces Codex can use#21458viyatb-oai wants to merge 2 commits intocodex/viyatb/managed-skill-requirementsfrom
Conversation
There was a problem hiding this comment.
💡 Codex Review
codex/codex-rs/app-server/src/request_processors/plugins.rs
Lines 896 to 897 in 8c02e63
The new allowlist check lives in install_plugin_for_config, but the app-server plugin/install path still calls install_plugin, which resolves and installs without consulting PluginsConfigInput. A user can pass a marketplacePath for a marketplace hidden by managed requirements and still install it, bypassing the allowlist this change is meant to enforce.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
3213007 to
3b863e0
Compare
8c02e63 to
9a5c49d
Compare
3b863e0 to
46d9b7f
Compare
9a5c49d to
c251553
Compare
Co-authored-by: Codex noreply@openai.com
46d9b7f to
5e4c73c
Compare
c251553 to
641f65a
Compare
Co-authored-by: Codex noreply@openai.com
Why
Plugin marketplace requirements need to make disallowed marketplaces inert in the core plugin manager, not merely hide them at one UI edge. Existing config, remote sync state, or cached plugin outcomes should not keep a disallowed marketplace effective after policy changes.
What changed
Example
config.tomlWith the managed requirements stack applied, an approved marketplace can still appear in user
config.tomllike this:There is intentionally no user-writable
allowed_sourceskey inconfig.toml; skill-source restrictions are enforced only from managed requirements.Verification
codex-rs/core-plugins/src/manager_tests.rs.openai-curatedis disallowed.Stack
--> feat: restrict which plugin marketplaces Codex can use #21458: core plugin allowlist enforcement