feat: expose managed artifact requirements#21414
Conversation
There was a problem hiding this comment.
💡 Codex Review
codex/codex-rs/core-plugins/src/manager.rs
Lines 475 to 480 in 2e1d9c6
plugins_for_config reuses a cached outcome using only the effective config TOML and hooks flag. The new marketplace filtering is based on config_layer_stack.requirements(), which effective_config() explicitly excludes, so two configs with identical TOML but different managed allowlists will share a cache entry and can keep disallowed plugins effective until a manual reload.
codex/codex-rs/core-skills/src/manager.rs
Lines 149 to 153 in 2e1d9c6
The cwd cache returns before the new retain_allowed_skill_roots filter runs. Because the key is only input.cwd, loading a cwd once without skill-source restrictions and then applying managed skills.allowed_sources for the same cwd returns the stale unrestricted outcome, leaving user/repo/plugin skills visible despite the new policy.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
f97185c to
50ae2b5
Compare
30b7766 to
5bc2238
Compare
1f2d2da to
0fdfd1b
Compare
51ff359 to
0427128
Compare
9fa68a2 to
f224caa
Compare
9e470f0 to
42e8036
Compare
f224caa to
c5022b1
Compare
c5022b1 to
58cde56
Compare
5285721 to
d6f1e19
Compare
Why
Once the lower stack adds the local contract and enforcement, the same requirements shape also needs to travel through cloud-managed requirements and app-server inspection APIs. Without that propagation layer, local
requirements.tomlwould work but enterprise-managed surfaces would lag behind the runtime capability.This PR is only the management/exposure layer on top of the lower stack. It does not add new enforcement behavior.
What changed
Added cloud-requirements parsing coverage for:
Exposed the new managed requirements through
configRequirements/read.Regenerated the app-server protocol JSON and TypeScript schemas for the new response fields.
Updated the app-server README example to include the managed artifact requirements.
Verification
codex-rs/cloud-requirements/src/lib.rs.codex-rs/app-server-protocol/src/protocol/v2/tests.rs.Stack