Skip to content

feat: let admins configure managed skill and marketplace controls#21413

Open
viyatb-oai wants to merge 1 commit intocodex/viyatb/managed-plugin-entrypointsfrom
codex/viyatb/managed-artifact-requirements
Open

feat: let admins configure managed skill and marketplace controls#21413
viyatb-oai wants to merge 1 commit intocodex/viyatb/managed-plugin-entrypointsfrom
codex/viyatb/managed-artifact-requirements

Conversation

@viyatb-oai
Copy link
Copy Markdown
Collaborator

@viyatb-oai viyatb-oai commented May 6, 2026

Why

Enterprise admins need a managed contract for the extensibility surfaces they may restrict, but that public surface should become usable only after the enforcement path exists. The lower PRs in this stack add the internal model and runtime enforcement first; this final PR activates the managed config surface and exposes it through cloud/app-server APIs.

What changed

  • Made the managed requirement sections parseable from local and cloud-managed requirements:

    [skills]
    allowed_sources = ["system", "admin", "plugin"]
    
    [plugin_marketplaces]
    allowed_names = ["openai-curated", "approved-marketplace"]
    allow_user_additions = false
  • Threaded the new fields through the shared requirements TOML model and exhaustive config fixtures.

  • Exposed the new managed requirements through configRequirements/read.

  • Regenerated the app-server protocol JSON and TypeScript schemas for the new response fields.

  • Updated the app-server README example to include the managed artifact requirements.

Example config.toml

With the managed requirements above, an approved marketplace can still appear in user config.toml like this:

[features]
plugins = true

[marketplaces.approved-marketplace]
source_type = "git"
source = "https://github.com/example/approved-marketplace.git"

There is intentionally no user-writable allowed_sources key in config.toml; skill-source restrictions are enforced only from managed requirements.

Verification

  • Added parsing coverage for the new requirement sections in codex-rs/config/src/config_requirements.rs.
  • Added cloud parsing coverage in codex-rs/cloud-requirements/src/lib.rs.
  • Updated protocol coverage in codex-rs/app-server-protocol/src/protocol/v2/tests.rs.

Stack

Copy link
Copy Markdown
Contributor

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: cc70905d44

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread codex-rs/config/src/config_requirements.rs
Comment thread codex-rs/config/src/config_requirements.rs
@viyatb-oai viyatb-oai requested a review from a team as a code owner May 6, 2026 21:43
@viyatb-oai viyatb-oai force-pushed the codex/viyatb/managed-artifact-requirements branch from 30b7766 to 5bc2238 Compare May 6, 2026 21:45
@viyatb-oai viyatb-oai changed the title feat: add managed artifact requirements feat: enforce managed artifact requirements May 6, 2026
@viyatb-oai viyatb-oai changed the title feat: enforce managed artifact requirements feat: introduce ability to restrict skills and plugins in requirements May 7, 2026
@viyatb-oai viyatb-oai force-pushed the codex/viyatb/managed-artifact-requirements branch from 51ff359 to 0427128 Compare May 7, 2026 01:07
@viyatb-oai viyatb-oai force-pushed the codex/viyatb/managed-artifact-requirements branch from 9e470f0 to 42e8036 Compare May 7, 2026 01:39
@viyatb-oai viyatb-oai changed the title feat: introduce ability to restrict skills and plugins in requirements feat: add managed artifact requirement schema May 7, 2026
@viyatb-oai viyatb-oai force-pushed the codex/viyatb/managed-artifact-requirements branch from 42e8036 to f0f0058 Compare May 7, 2026 02:20
@viyatb-oai viyatb-oai changed the base branch from main to codex/viyatb/managed-plugin-entrypoints May 7, 2026 02:20
@viyatb-oai viyatb-oai changed the title feat: add managed artifact requirement schema feat: activate managed artifact requirements May 7, 2026
@viyatb-oai viyatb-oai changed the title feat: activate managed artifact requirements feat: let admins configure managed skill and marketplace controls May 7, 2026
@viyatb-oai viyatb-oai force-pushed the codex/viyatb/managed-plugin-entrypoints branch from 9b4c779 to 294f4f9 Compare May 7, 2026 02:36
@viyatb-oai viyatb-oai force-pushed the codex/viyatb/managed-artifact-requirements branch from f0f0058 to c12e95e Compare May 7, 2026 02:36
Co-authored-by: Codex noreply@openai.com
@viyatb-oai viyatb-oai force-pushed the codex/viyatb/managed-plugin-entrypoints branch from 294f4f9 to c7e7818 Compare May 7, 2026 02:58
@viyatb-oai viyatb-oai force-pushed the codex/viyatb/managed-artifact-requirements branch from c12e95e to 4ea99de Compare May 7, 2026 02:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant