Repository navigation
Conversation
The context belongs to ralloc, so release its owner with ralloc_free when uploader creation fails. Derive the embedded pipe pointer only after checking allocation success. Signed-off-by: Satya Benson <satya@benson.earth>
The synthetic split-query case appends starts directly, bypassing the production allocator that zeroes new capacity. Teardown visits the entire capacity to release retained references, so uninitialized spare slots can crash the test. Zero this all-empty synthetic backing before teardown. Signed-off-by: Satya Benson <satya@benson.earth>
 [Low impact] The changes appear safe to merge. SummaryFixes failed Asahi context creation and initializes spare storage in the Zink split-query test.
Reviews (1) · Last reviewed commit: "zink: Initialize spare query-start slots..." · Reviewed by Greptile |
This was referenced Nov 3, 2026
Author
|
Claude Fable 5.2 on @satchlj's behalf Closing in favour of aurora-silicon#161, merged on aurora-wip. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release failed context allocations with ralloc and derive the embedded pipe pointer only after allocation succeeds. Initialize spare query-start slots in the synthetic Zink split-query test before teardown. These are two public-code fixes; context-priority correction is already in #22 and intentionally excluded. Both commits apply cleanly and diff --check passes; historical combined-tree tests passed 158/158, but fresh split-head build/CI remains required before merge.