Skip to content

asahi: fix failed-context cleanup and Zink query test initialization #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
satchlj wants to merge 2 commits into from
Closed

asahi: fix failed-context cleanup and Zink query test initialization #29

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1545fe6
asahi: Release failed context allocations with ralloc
satchlj Nov 3, 2026
39a605a
zink: Initialize spare query-start slots in the query test
satchlj Nov 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/gallium/drivers/asahi/agx_pipe.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1924,12 +1924,13 @@ static struct pipe_context *
agx_create_context(struct pipe_screen *screen, void *priv, unsigned flags)
{
struct agx_context *ctx = rzalloc(NULL, struct agx_context);
struct pipe_context *pctx = &ctx->base;
int ret;

if (!ctx)
return NULL;

struct pipe_context *pctx = &ctx->base;

pctx->screen = screen;
pctx->priv = priv;

Expand All @@ -1938,7 +1939,7 @@ agx_create_context(struct pipe_screen *screen, void *priv, unsigned flags)

pctx->stream_uploader = u_upload_create_default(pctx);
if (!pctx->stream_uploader) {
FREE(pctx);
ralloc_free(ctx);
return NULL;
}
pctx->const_uploader = pctx->stream_uploader;
Expand Down
2 changes: 2 additions & 0 deletions src/gallium/drivers/zink/zink_query_test.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,6 +139,8 @@ main(void)
assert(can_direct_poll_query_result(&q));
util_dynarray_append(&q.starts, split);
assert(!can_direct_poll_query_result(&q));
/* Teardown also visits spare slots, as the production allocator permits. */
memset(q.starts.data, 0, q.starts.capacity);
uint64_t values[] = {2048, 2048};
union pipe_query_result result;
util_query_clear_result(&result, q.type);
Expand Down