Repository navigation
fix: stack the group card's timed unblock and button rows at large text sizes - #125
Merged
Merged
Conversation
…xt sizes At accessibility text sizes the group card's timed unblock row broke "Block Now" and the countdown mid-word, and a partly blocked group's Block All / Unblock All buttons broke letter by letter. Both rows now use AdaptiveStack, like the card's header, so they stack at accessibility sizes and look the same as before at standard sizes.
This was referenced Nov 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Follow-up to #121. At the largest text sizes, two rows on the group card still broke words:
Fix
AdaptiveStack, which fix: scale schedule and group cards for large text #121 added for the card's header. At accessibility sizes they stack; at standard sizes they're unchanged..frame(maxWidth: .infinity, alignment: .leading), the same way the header's name does, instead of aSpacer. This keeps the row the same at standard sizes and avoids an empty gap when it stacks.Tests
testGroupTimedUnblockRowKeepsWholeWordsAtTheLargestTextSize. It starts a timed group unblock at the largest size and reads the screen with on-device text recognition (Vision). Without the fix it fails, reading "Bloc", "K", "Now"; with the fix it passes.