Skip to content

fix: stack the group card's timed unblock and button rows at large text sizes - #125

Merged
ykisana merged 1 commit into
mainfrom
fix/group-card-large-text
Nov 18, 2026
Merged

ykisana merged 1 commit into
mainfrom
fix/group-card-large-text

Conversation

@ykisana

@ykisana ykisana commented Nov 18, 2026

Copy link
Copy Markdown
Contributor

What

Follow-up to #121. At the largest text sizes, two rows on the group card still broke words:

  • Timed unblock row: "Block Now" broke into "Bloc / k / Now", the countdown into "14:5 / 7", and the status badge read "Timed Unblo…".
  • Partly blocked group: the side-by-side Block All and Unblock All buttons broke letter by letter.

Fix

  • Both rows use AdaptiveStack, which fix: scale schedule and group cards for large text #121 added for the card's header. At accessibility sizes they stack; at standard sizes they're unchanged.
  • In the timed unblock row, the timer and countdown take the remaining width with .frame(maxWidth: .infinity, alignment: .leading), the same way the header's name does, instead of a Spacer. This keeps the row the same at standard sizes and avoids an empty gap when it stacks.
  • With the row stacked, the status badge also wraps to "Timed / Unblock" instead of being cut off.

Tests

  • New UI test testGroupTimedUnblockRowKeepsWholeWordsAtTheLargestTextSize. It starts a timed group unblock at the largest size and reads the screen with on-device text recognition (Vision). Without the fix it fails, reading "Bloc", "K", "Now"; with the fix it passes.
  • No UI test for the Block All / Unblock All row: the UI-test seed's group has one app, so it can't be partly blocked. A render of the row at the card's width shows the buttons stacking at the largest size and staying side by side at the default size.
  • Default size unchanged: screenshots of the group card unblocked, blocked and in a timed unblock are pixel-identical before and after, below the status bar.
  • Full suites, iOS 27 simulators: unit 894/894 (iPad Pro 11-inch), UI 58/58 (iPhone 17).

…xt sizes

At accessibility text sizes the group card's timed unblock row broke
"Block Now" and the countdown mid-word, and a partly blocked group's
Block All / Unblock All buttons broke letter by letter. Both rows now use
AdaptiveStack, like the card's header, so they stack at accessibility
sizes and look the same as before at standard sizes.
@ykisana
ykisana merged commit 435af0d into main Nov 18, 2026
1 check passed
@ykisana
ykisana deleted the fix/group-card-large-text branch November 18, 2026 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant