Skip to content

feat: let a blocked group's default duration and key change - #136

Merged
ykisana merged 1 commit into
mainfrom
feat/group-defaults-while-blocked
Nov 19, 2026
Merged

ykisana merged 1 commit into
mainfrom
feat/group-defaults-while-blocked

Conversation

@ykisana

@ykisana ykisana commented Nov 19, 2026

Copy link
Copy Markdown
Contributor

Problem

While anything is blocked, a group's sheet is read-only. That also locked the Unblocking section from #123, so a group's Default Duration and Default Key couldn't be set until every app was unblocked.

Fix

  • The Default Duration and Default Key pickers stay editable while blocked.
  • In the blocked view, Done saves those two values before closing. Before, it only closed the sheet.
  • Name, apps, websites, group keys and Delete stay locked.

Changing these doesn't loosen anything:

  • An unblock still needs a key.
  • The duration sheet already offers every duration, so a group default only skips a choice the user could make anyway.

The sheet's footer still reads "Unblock all apps to add or edit groups.", the same message the Groups list uses.

Tests

While anything is blocked the group sheet is read-only, which also locked
the Unblocking section #123 added. Changing a group's Default Duration or
Default Key doesn't loosen anything: an unblock still needs a key, and the
duration sheet already offers every duration. The two pickers now stay
editable while blocked, and Done saves them. Name, apps, websites and keys
stay locked.
@ykisana
ykisana merged commit 3b5c987 into main Nov 19, 2026
4 checks passed
@ykisana
ykisana deleted the feat/group-defaults-while-blocked branch November 19, 2026 05:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant