Repository navigation
feat: let a blocked group's default duration and key change - #136
Merged
Merged
Conversation
While anything is blocked the group sheet is read-only, which also locked the Unblocking section #123 added. Changing a group's Default Duration or Default Key doesn't loosen anything: an unblock still needs a key, and the duration sheet already offers every duration. The two pickers now stay editable while blocked, and Done saves them. Name, apps, websites and keys stay locked.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
While anything is blocked, a group's sheet is read-only. That also locked the Unblocking section from #123, so a group's Default Duration and Default Key couldn't be set until every app was unblocked.
Fix
Changing these doesn't loosen anything:
The sheet's footer still reads "Unblock all apps to add or edit groups.", the same message the Groups list uses.
Tests
testGroupDefaultDurationCanBeSetWhileBlocked. It starts blocked, sets the group's default to 4 hours, taps Done, then unblocks the group with its key, and checks that the unblock starts without the duration sheet.