Skip to content

test: make UI tests pass on iOS 17 and iPad again - #134

Merged
ykisana merged 1 commit into
mainfrom
fix/backward-compat
Nov 19, 2026
Merged

ykisana merged 1 commit into
mainfrom
fix/backward-compat

Conversation

@ykisana

@ykisana ykisana commented Nov 19, 2026

Copy link
Copy Markdown
Contributor

Backward compatibility review

I reviewed every change since v1.7 for users updating from v1.4–v1.7. Nothing breaks.

  • Saved data: SwiftData models, app-group DTOs and defaults keys, Keychain items, DeviceActivity activity and event names, and the ManagedSettings store name are unchanged or extended safely:
    • new properties are optional or have defaults;
    • new DTO fields are optional;
    • no renames.
    • StoreUpgradeTests opens real 1.4 and 1.5 stores, and 1.6/1.7 have the 1.5 shape.
  • Widgets, Shortcuts, Control Center, deep links and Live Activities: identifiers, parameter names and types, entity ids, raw values and URL formats are unchanged, so existing setups keep working.
  • Two intentional behaviour changes:
    • a v1.4 widget with no duration now uses Settings' default duration;
    • a QR widget opens the scanner directly.
  • Left alone: a v1.4/v1.5 user who did a permanent Unblock All during a running Permanent block schedule, and updates within that schedule's hidden duration, gets the schedule's apps blocked again.
    • It fails closed.
    • It can't be told apart from an unblock that happened before the schedule's start reached Normal, where re-blocking is right.
    • It dates from v1.6's migration.

What this PR fixes

The review turned up UI tests failing on iOS 17 and iPad:

Results

  • iPhone iOS 17.5: 61/61.
  • iPad iOS 17.5: 60 passed, 1 skipped.
  • iPad iOS 27: the large-text tests pass. testGroupTimedUnblockRowKeepsWholeWordsAtTheLargestTextSize failed once in 5 runs, cause not captured.

- testGroupTimedUnblockRowKeepsWholeWordsAtTheLargestTextSize starts with
  everything blocked and a 15-minute default, so it only taps Unblock and the
  QR row. On iOS 17 the Choose Key sheet opens short at the largest text size
  and "Block without key" is off screen.
- testCardsKeepWholeWordsAtTheLargestTextSize waits for the day chips or the
  week strip. On iPad the chips fit at every text size.
- testScheduleCardShowsAWeekStripWhenDayChipsDontFit is skipped on iPad for
  the same reason.
- The UI-test shared store starts with the custom websites setting, as a real
  install already has it. AppContainer mirrors it in a .task that doesn't
  reconcile, so under load the first reconcile could drop the website block
  and testBlockedWebsitesWithoutAppsCanBeUnblockedFromHome failed.
@ykisana
ykisana merged commit 27dcd9e into main Nov 19, 2026
4 checks passed
@ykisana
ykisana deleted the fix/backward-compat branch November 19, 2026 04:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant