Repository navigation
test: make UI tests pass on iOS 17 and iPad again - #134
Merged
Merged
Conversation
- testGroupTimedUnblockRowKeepsWholeWordsAtTheLargestTextSize starts with everything blocked and a 15-minute default, so it only taps Unblock and the QR row. On iOS 17 the Choose Key sheet opens short at the largest text size and "Block without key" is off screen. - testCardsKeepWholeWordsAtTheLargestTextSize waits for the day chips or the week strip. On iPad the chips fit at every text size. - testScheduleCardShowsAWeekStripWhenDayChipsDontFit is skipped on iPad for the same reason. - The UI-test shared store starts with the custom websites setting, as a real install already has it. AppContainer mirrors it in a .task that doesn't reconcile, so under load the first reconcile could drop the website block and testBlockedWebsitesWithoutAppsCanBeUnblockedFromHome failed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backward compatibility review
I reviewed every change since v1.7 for users updating from v1.4–v1.7. Nothing breaks.
StoreUpgradeTestsopens real 1.4 and 1.5 stores, and 1.6/1.7 have the 1.5 shape.What this PR fixes
The review turned up UI tests failing on iOS 17 and iPad:
testGroupTimedUnblockRowKeepsWholeWordsAtTheLargestTextSize(fix: stack the group card's timed unblock and button rows at large text sizes #125): on iOS 17 the Choose Key sheet opens short at the largest text size, so "Block without key" is off screen. The test now starts blocked with a 15-minute default, so it only taps Unblock and the QR row. It still fails without fix: stack the group card's timed unblock and button rows at large text sizes #125's fix on iOS 17.5 and 27.testCardsKeepWholeWordsAtTheLargestTextSize(fix: scale schedule and group cards for large text #121): waits for the day chips or the week strip, because on iPad the chips fit at every text size.testScheduleCardShowsAWeekStripWhenDayChipsDontFit(fix: scale schedule and group cards for large text #121): skipped on iPad for the same reason.testBlockedWebsitesWithoutAppsCanBeUnblockedFromHome: failed 3 of 11 runs on iOS 17.5 under load.AppContainercopies the custom-websites setting into the shared store in a.taskthat doesn't reconcile. In UI tests every launch gets a fresh store, so the first reconcile could drop the website block.Results
testGroupTimedUnblockRowKeepsWholeWordsAtTheLargestTextSizefailed once in 5 runs, cause not captured.