Repository navigation
fix: scale schedule and group cards for large text - #121
Merged
Merged
Conversation
At the largest text sizes, and on narrow screens, the cards broke words
across lines: the schedule card's day chips ("Su/n"), its Block and
Permanent labels ("Bloc/k", "Per-/ma-/nen/t") and the group card's
status ("Un-/block/ed").
Following Apple's large text guidance, side-by-side rows now stack at
accessibility sizes (AdaptiveStack, the WWDC24 Dynamic Type pattern).
When the day chips don't fit on one row, the card shows all seven days
as the same light blue chips, with unscheduled days in gray. On iOS 26
and later, blocked-state footers use safeAreaBar, so content scrolling
under them blurs instead of overlapping.
Reported in #82.
ykisana
force-pushed
the
fix/schedule-weekday-strip
branch
from
November 18, 2026 11:38
bb67c79 to
cff6f6e
Compare
This was referenced Nov 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
At the largest text sizes, and on narrow screens like an iPhone 13 mini with Display Zoom (reported in #82), the cards broke words across lines:
The Schedules footer shown while blocked also drew on top of the card.
Following Apple's guidance for large text (HIG Typography, WWDC24 Get started with Dynamic Type):
safeAreaBar. Content scrolling under them gets the system scroll-edge blur. Earlier versions keepsafeAreaInset.How
AdaptiveStacklays its content out horizontally, then vertically whendynamicTypeSize.isAccessibilitySize, the WWDC24 pattern.ScheduleCardViewandGroupListCardViewuse it for the rows above.ScheduleCardViewputs the chips andWeekdayStripin aViewThatFits, so the chips win whenever they fit. The strip grows with the text up to accessibility size 2.bottomFooterusessafeAreaBaron iOS 26+, otherwisesafeAreaInset.Tests
testCardsKeepWholeWordsAtTheLargestTextSize: at the largest size, reads the Schedules and Groups screens with on-device text recognition (Vision) and checks "Block", "Permanent" and "Unblocked" come out as whole words. It fails on the old layout, which reads as "Bloc", "Per-", "ma-", "nen", "t".testScheduleCardShowsDayChipsWhenTheyFit: chips at the default size.testScheduleCardShowsAWeekStripWhenDayChipsDontFit: the strip at the largest size, and its VoiceOver label.