Skip to content

fix: scale schedule and group cards for large text - #121

Merged
ykisana merged 1 commit into
mainfrom
fix/schedule-weekday-strip
Nov 18, 2026
Merged

ykisana merged 1 commit into
mainfrom
fix/schedule-weekday-strip

Conversation

@ykisana

@ykisana ykisana commented Nov 18, 2026 •

Copy link
Copy Markdown
Contributor

What

At the largest text sizes, and on narrow screens like an iPhone 13 mini with Display Zoom (reported in #82), the cards broke words across lines:

  • the schedule card's day chips ("Su/n", "Mo/n");
  • its Block and Permanent labels ("Bloc/k", "Per-/ma-/nen/t");
  • the group card's status ("Un-/block/ed", "Block/ed").

The Schedules footer shown while blocked also drew on top of the card.

Following Apple's guidance for large text (HIG Typography, WWDC24 Get started with Dynamic Type):

  • Rows stack at accessibility sizes. Rows that sit side by side switch to a vertical stack at the five accessibility text sizes, so text gets the full width instead of breaking mid-word:
    • the schedule's name and OFF badge;
    • Block / Permanent, which also drops the "·" when stacked;
    • a timed schedule's time range and duration;
    • the group's name and status.
    • Default and larger standard sizes look exactly as before.
  • Day chips that don't fit become a week strip. When the chips don't fit on one row, the card shows all seven days as the same light-blue rounded chips, with unscheduled days in gray. Showing every day keeps the single letters unambiguous. VoiceOver reads the full day names.
  • Footers blur instead of overlapping. On iOS 26 and later, the blocked-state footers on Groups, Schedules, Keys, the group and schedule editors, Group Keys and the website editor use safeAreaBar. Content scrolling under them gets the system scroll-edge blur. Earlier versions keep safeAreaInset.

How

  • AdaptiveStack lays its content out horizontally, then vertically when dynamicTypeSize.isAccessibilitySize, the WWDC24 pattern.
  • ScheduleCardView and GroupListCardView use it for the rows above.
  • ScheduleCardView puts the chips and WeekdayStrip in a ViewThatFits, so the chips win whenever they fit. The strip grows with the text up to accessibility size 2.
  • bottomFooter uses safeAreaBar on iOS 26+, otherwise safeAreaInset.

Tests

  • testCardsKeepWholeWordsAtTheLargestTextSize: at the largest size, reads the Schedules and Groups screens with on-device text recognition (Vision) and checks "Block", "Permanent" and "Unblocked" come out as whole words. It fails on the old layout, which reads as "Bloc", "Per-", "ma-", "nen", "t".
  • testScheduleCardShowsDayChipsWhenTheyFit: chips at the default size.
  • testScheduleCardShowsAWeekStripWhenDayChipsDontFit: the strip at the largest size, and its VoiceOver label.
  • Unit tests: 883/883. UI tests: 50/50. Both on the iPhone Air iOS 27.0 simulator.

At the largest text sizes, and on narrow screens, the cards broke words
across lines: the schedule card's day chips ("Su/n"), its Block and
Permanent labels ("Bloc/k", "Per-/ma-/nen/t") and the group card's
status ("Un-/block/ed").

Following Apple's large text guidance, side-by-side rows now stack at
accessibility sizes (AdaptiveStack, the WWDC24 Dynamic Type pattern).
When the day chips don't fit on one row, the card shows all seven days
as the same light blue chips, with unscheduled days in gray. On iOS 26
and later, blocked-state footers use safeAreaBar, so content scrolling
under them blurs instead of overlapping.

Reported in #82.
@ykisana
ykisana force-pushed the fix/schedule-weekday-strip branch from bb67c79 to cff6f6e Compare November 18, 2026 11:38
@ykisana ykisana changed the title fix: show a week strip when a schedule's day chips don't fit fix: scale schedule and group cards for large text Nov 18, 2026
@ykisana
ykisana merged commit f103d06 into main Nov 18, 2026
1 check passed
@ykisana
ykisana deleted the fix/schedule-weekday-strip branch November 18, 2026 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant