Repository navigation
meta: build docs for PRs whose base has no main run - #1248
Merged
Merged
Conversation
prepare downloads the nodejs/node SHA that the latest `main` run of generate.yml used for the PR's base commit. A PR stacked on another PR's branch has a base commit no such run built, so the download failed and generate never ran. Without a base run, prepare now skips the download and builds from the latest SHA of nodejs/node, as a push to main does. generate already skips the comparison when there's no base run, so these PRs still build every target, without a comparison. Assisted-by: Claude Opus 5.5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
ovflowd
added
the
fast track
🚀 Deploying Preview to Cloudflare 🚀Preview Deployments by commit
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1248 +/- ##
=======================================
Coverage 94.13% 94.13%
=======================================
Files 291 291
Lines 28900 28900
Branches 2932 2932
=======================================
Hits 27206 27206
Misses 1672 1672
Partials 22 22 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Member
Author
|
Requesting fast-track to fix this CI bug cc @nodejs/doc-kit |
Contributor
|
avivkeller
approved these changes
Nov 6, 2026
2 of 4 tasks
ovflowd
added a commit
that referenced
this pull request
Nov 6, 2026
Only push runs of generate.yml upload the `commit` artifact. A PR stacked on another PR's branch can find that PR's pull_request run for its base commit, so prepare tried to download an artifact that run never made, and failed. With -e push such a base finds no run, and prepare takes the path without a comparison that #1248 added. Assisted-by: Claude Opus 5.5 <noreply@anthropic.com>
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR stops "Generate and Compare Docs" from failing on PRs whose base has no
mainrun, like the stacked ones in #1238 to #1243.preparelooks up the latest run ofgenerate.ymlfor the PR's base commit and downloads the nodejs/node SHA it built. A PR stacked on another PR's branch has a base commit no run ever built, so the download failed with "Artifact not found for name: commit" andgeneratenever ran. Without a base run,preparenow skips the download and builds from the latest nodejs/node SHA, as a push tomaindoes.generatealready skips the comparison when there's no base run, so these PRs still build every target, just without comparing.Validation
zizmorreports nothing new (the same 6 suppressed findings as onmain), and the format check passes. This PR targetsmain, so its own run still goes through the download and the comparison; the stacked PRs will show the other path once they're rebased onto it.Related Issues
Refs: #1238
Check List
node --run testand all tests passed.node --run format:check&node --run lint.