Skip to content

meta: build docs for PRs whose base has no main run #1248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ovflowd merged 1 commit into from
Nov 6, 2026
+9 −2
Merged

meta: build docs for PRs whose base has no main run #1248

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions .github/workflows/generate.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,17 +57,24 @@ jobs:
echo "run_id=$ID" >> $GITHUB_OUTPUT

- name: Download metadata artifact
if: ${{ github.event_name == 'pull_request' }}
if: ${{ github.event_name == 'pull_request' && steps.main.outputs.run_id }}
uses: actions/download-artifact@9000827ccba6bdab643e8b6fd33ac0654aef8333 # v8.0.2
with:
name: commit
run-id: ${{ steps.main.outputs.run_id }}
github-token: ${{ secrets.GITHUB_TOKEN }}

# A PR whose base has no `main` run, such as one stacked on another PR's
# branch, has nothing to compare against: it builds from the latest SHA
# from nodejs/node, and `generate` skips the comparison
- id: pr
if: ${{ github.event_name == 'pull_request' }}
run: |
SHA=$(cat commit)
if [ -f commit ]; then
SHA=$(cat commit)
else
SHA=$(git ls-remote https://github.com/nodejs/node.git HEAD | awk '{print $1}')
fi
echo "sha=$SHA" >> "$GITHUB_OUTPUT"

generate:
Expand Down
Loading