Repository navigation
hot-fix: look up only push runs for a PR's base - #1249
Merged
Merged
Conversation
Only push runs of generate.yml upload the `commit` artifact. A PR stacked on another PR's branch can find that PR's pull_request run for its base commit, so prepare tried to download an artifact that run never made, and failed. With -e push such a base finds no run, and prepare takes the path without a comparison that #1248 added. Assisted-by: Claude Opus 5.5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1249 +/- ##
=======================================
Coverage 94.13% 94.13%
=======================================
Files 291 291
Lines 28900 28900
Branches 2932 2932
=======================================
Hits 27206 27206
Misses 1672 1672
Partials 22 22 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
🚀 Deploying Preview to Cloudflare 🚀Preview Deployments by commit
|
Contributor
|
ovflowd
added
the
fast track
Member
Author
|
Apologies team (cc @nodejs/doc-kit) hot fix of my previous one... Don't have |
ovflowd
changed the title
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR is a follow-up to #1248, which didn't quite fix it, my bad.
preparelooked up the latest run ofgenerate.ymlfor the PR's base commit, of any event. For a PR stacked on another PR's branch, that finds the lower PR'spull_requestrun, which never uploads thecommitartifact, so the download still failed. It now looks up onlypushruns (-e push): a stacked base finds none and skips the comparison as #1248 intended, while a base onmainfinds the same run as before.Validation
Checked the lookup against the real runs. For #1238's base (
perf/stream-worker), it found #1237'spull_requestrun before and finds nothing with-e push. Formain's head, both find the samepushrun.zizmorreports nothing new, and the format check passes.Related Issues
Refs: #1248
Check List
node --run testand all tests passed.node --run format:check&node --run lint.