Conversation
This was referenced Sep 16, 2026
hweihwang
force-pushed
the
collectives-599/c1-complete
branch
from
September 16, 2026 10:42
e7dfe31 to
52432c5
Compare
hweihwang
changed the title
hweihwang
added this pull request to stack #2791
September 16, 2026 11:18
hweihwang
force-pushed
the
collectives-599/c1-complete
branch
2 times, most recently
from
September 16, 2026 14:34
11df00a to
87427df
Compare
Assisted-by: Codex:gpt-6-astra Signed-off-by: Hoang Pham <hoangmaths96@gmail.com>
Assisted-by: Codex:gpt-6-astra Signed-off-by: Hoang Pham <hoangmaths96@gmail.com>
Assisted-by: Codex:gpt-6-astra Signed-off-by: Hoang Pham <hoangmaths96@gmail.com>
Verified the original Cypress case and both Playwright Viewer cases against the same NC32 runtime and installed Text revision before removing the Cypress fallback case. Assisted-by: Codex:gpt-6-astra Signed-off-by: Hoang Pham <hoangmaths96@gmail.com>
Use the edit button accessibility labels in the shared fixture, including Stop editing for preview. Assisted-by: Codex:gpt-6-astra Signed-off-by: Hoang Pham <hoangmaths96@gmail.com>
Remove the empty suite, unused fixtures and obsolete Cypress comparison selector. Keep the mounted component cases and build the pinned Text assets on the main server leg. Assisted-by: Codex:gpt-6-astra Signed-off-by: Hoang Pham <hoangmaths96@gmail.com>
Assisted-by: Codex:gpt-6-astra Signed-off-by: Hoang Pham <hoangmaths96@gmail.com>
Hold autosave until the Save button request completes, then verify persisted bytes through DAV, preview and reload. Assisted-by: Codex:gpt-6-astra Signed-off-by: Hoang Pham <hoangmaths96@gmail.com>
hweihwang
force-pushed
the
collectives-599/c1-complete
branch
from
September 16, 2026 14:49
87427df to
f58e250
Compare
hweihwang
marked this pull request as ready for review
September 16, 2026 18:52
hweihwang
requested review from
max-nextcloud,
mejo- and
silverkszlo
as code owners
September 16, 2026 18:52
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Move the remaining version tests to Playwright: version management, DAV restore permissions, saved edits, comparison-link recovery and the older Viewer path. Remove the replaced Cypress version suite and its CI selector.
Together with #2787, this replaces all 47 version E2E cases. Keep the seven Cypress component tests.
Depends on #2787.
Tests
The complete stack passed TypeScript checks, lint, the production build and all 116 unit tests locally. All 69 comparison checks and all three page-share checks passed on both NC35 and master with retries disabled. The seven retained Cypress component tests also passed.
AI