Conversation
2 tasks
hweihwang
force-pushed
the
collectives-599/c2-fixed-text-pins-final
branch
from
September 16, 2026 10:42
cc9f14e to
b40ee29
Compare
hweihwang
added this pull request to stack #2791
September 16, 2026 11:18
hweihwang
force-pushed
the
collectives-599/c2-fixed-text-pins-final
branch
from
September 16, 2026 14:12
b40ee29 to
9e2e05a
Compare
hweihwang
force-pushed
the
collectives-599/c2-fixed-text-pins-final
branch
from
September 16, 2026 14:34
9e2e05a to
06ff12a
Compare
Pin the tested Text candidates and verify the initial view, rendered targets, served assets, and delayed-image behavior in the actual comparison dialog. Assisted-by: Codex:gpt-6-astra Signed-off-by: Hoang Pham <hoangmaths96@gmail.com>
Observe the Source component and module worker responses after opening the comparison. Verify their served bytes through the observed URLs because Chromium does not reliably expose module-worker response bodies. Assisted-by: Codex:gpt-6-astra Signed-off-by: Hoang Pham <hoangmaths96@gmail.com>
hweihwang
force-pushed
the
collectives-599/c2-fixed-text-pins-final
branch
from
September 16, 2026 14:49
06ff12a to
279cde7
Compare
hweihwang
marked this pull request as ready for review
September 16, 2026 18:52
hweihwang
requested review from
max-nextcloud,
mejo- and
silverkszlo
as code owners
September 16, 2026 18:52
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Update the pinned Text commits and add nine checks through the installed comparison dialog. Cover the initial view and selected change, formatting changes and comparisons with no rendered differences, Source assets, narrow layouts and delayed images.
Before merging
Tests
The complete stack passed TypeScript checks, lint, the production build and all 116 unit tests locally. All 69 comparison checks and all three page-share checks passed on both NC35 and master with retries disabled. The source-label-only NC35 version previously passed 67 comparison checks, with two Full documents checks skipped. Served Text assets matched the built files.
AI