Skip to content

ci(collectives): update Text comparison pins - #2789

Open
hweihwang wants to merge 2 commits into
collectives-599/c1-completefrom
collectives-599/c2-fixed-text-pins-final
Open

hweihwang wants to merge 2 commits into
collectives-599/c1-completefrom
collectives-599/c2-fixed-text-pins-final

Conversation

@hweihwang

@hweihwang hweihwang commented Sep 16, 2026

Copy link
Copy Markdown
Contributor

Summary

Update the pinned Text commits and add nine checks through the installed comparison dialog. Cover the initial view and selected change, formatting changes and comparisons with no rendered differences, Source assets, narrow layouts and delayed images.

Before merging

Tests

The complete stack passed TypeScript checks, lint, the production build and all 116 unit tests locally. All 69 comparison checks and all three page-share checks passed on both NC35 and master with retries disabled. The source-label-only NC35 version previously passed 67 comparison checks, with two Full documents checks skipped. Served Text assets matched the built files.

AI

  • The content of this PR was partly or fully generated using AI tools.
  • The AI-generated content was reviewed, comprehended and tested by a human.

@hweihwang
hweihwang force-pushed the collectives-599/c2-fixed-text-pins-final branch from cc9f14e to b40ee29 Compare September 16, 2026 10:42
@hweihwang hweihwang changed the title ci(collectives): adopt verified Text comparison changes ci(collectives): update Text comparison pins Sep 16, 2026
@hweihwang
hweihwang added this pull request to stack #2791 September 16, 2026 11:18
@hweihwang hweihwang closed this Sep 16, 2026
@hweihwang hweihwang reopened this Sep 16, 2026
@hweihwang
hweihwang force-pushed the collectives-599/c2-fixed-text-pins-final branch from b40ee29 to 9e2e05a Compare September 16, 2026 14:12
@hweihwang
hweihwang force-pushed the collectives-599/c2-fixed-text-pins-final branch from 9e2e05a to 06ff12a Compare September 16, 2026 14:34
Pin the tested Text candidates and verify the initial view, rendered targets, served assets, and delayed-image behavior in the actual comparison dialog.

Assisted-by: Codex:gpt-6-astra
Signed-off-by: Hoang Pham <hoangmaths96@gmail.com>
Observe the Source component and module worker responses after opening the comparison. Verify their served bytes through the observed URLs because Chromium does not reliably expose module-worker response bodies.

Assisted-by: Codex:gpt-6-astra
Signed-off-by: Hoang Pham <hoangmaths96@gmail.com>
@hweihwang
hweihwang force-pushed the collectives-599/c2-fixed-text-pins-final branch from 06ff12a to 279cde7 Compare September 16, 2026 14:49
@hweihwang
hweihwang marked this pull request as ready for review September 16, 2026 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant