Conversation
hweihwang
changed the title
hweihwang
changed the base branch from
main
to
collectives-599/c2-nc35-comparison-ci
September 16, 2026 10:01
hweihwang
force-pushed
the
collectives-599/c1a-historical-comparison-parity
branch
from
September 16, 2026 10:01
11515f9 to
e1158be
Compare
This was referenced Sep 16, 2026
hweihwang
changed the title
hweihwang
added this pull request to stack #2791
September 16, 2026 11:18
hweihwang
force-pushed
the
collectives-599/c1a-historical-comparison-parity
branch
2 times, most recently
from
September 16, 2026 14:34
a042b6a to
b53c356
Compare
Assisted-by: Codex:gpt-6-astra Signed-off-by: Hoang Pham <hoangmaths96@gmail.com>
Assisted-by: Codex:gpt-6-astra Signed-off-by: Hoang Pham <hoangmaths96@gmail.com>
Assisted-by: Codex:gpt-6-astra Signed-off-by: Hoang Pham <hoangmaths96@gmail.com>
Assisted-by: Codex:gpt-6-astra Signed-off-by: Hoang Pham <hoangmaths96@gmail.com>
Assisted-by: Codex:gpt-6-astra Signed-off-by: Hoang Pham <hoangmaths96@gmail.com>
Remove unused helpers and fixture data after their Cypress consumers move to Playwright, and normalize the remaining spacing. Assisted-by: Codex:gpt-6-astra Signed-off-by: Hoang Pham <hoangmaths96@gmail.com>
Use editor readiness instead of waiting for a session response that may already have arrived. Let resource requests finish before the close-and-reopen assertions. Assisted-by: Codex:gpt-6-astra Signed-off-by: Hoang Pham <hoangmaths96@gmail.com>
hweihwang
force-pushed
the
collectives-599/c1a-historical-comparison-parity
branch
from
September 16, 2026 14:49
b53c356 to
3b1fb15
Compare
hweihwang
marked this pull request as ready for review
September 16, 2026 18:52
hweihwang
requested review from
max-nextcloud,
mejo- and
silverkszlo
as code owners
September 16, 2026 18:52
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Move tests for comparison links, permissions, rich Markdown, responsive controls, selection, caching and failed requests from Cypress to Playwright. Remove the Cypress cases covered by their replacements, along with unused helpers and data.
This is the first of two migration PRs. #2788 finishes the migration and keeps the seven Cypress component tests.
Depends on #2786.
Tests
The complete stack passed TypeScript checks, lint, the production build and all 116 unit tests locally. All 69 comparison checks and all three page-share checks passed on both NC35 and master with retries disabled.
AI