telemetry: add stream_image_success and clean_install_finalized completion metrics - #783
Closed
bfjelds (bfjelds) wants to merge 1 commit into
Conversation
|
Azure Pipelines: 1 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
This was referenced Sep 8, 2026
stream_image_start fires with no matching completion signal. Added stream_image_success, fired in Trident::stream_image() once the underlying install() call returns Ok, mirroring the existing _start metric. (clean_install_finalized was considered for the streaming clean-install completion gap too, but dropped -- the clean_install/finalize_clean_install functions are already #[tracing::instrument]-ed spans, which already give start/end + duration for free; an additional boolean metric would just be redundant with that.)
bfjelds (bfjelds)
force-pushed
the
user/bfjelds/mjolnir/streaming-completion-telemetry
branch
from
September 8, 2026 21:53
26f5eb2 to
9196167
Compare
Member
Author
|
Folded into #778 (stream_image_success is now part of that commit and merged forward through 779/781). Closing since this branch is now redundant. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
stream_image_startmetric is created with no matching completion signal. addstream_image_successand ensure thatclean_install_successis created for stream image.Related PRs in stack: