Skip to content

telemetry: add stream_image_success and clean_install_finalized completion metrics #783

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bfjelds (bfjelds) wants to merge 1 commit into from
Closed

telemetry: add stream_image_success and clean_install_finalized completion metrics #783

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion crates/trident/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -908,7 +908,17 @@ impl Trident {
self.host_config = Some(config);
self.is_stream_image = true;

self.install(datastore, Operations::all(), false, Some(image))
// `stream_image_start` above marks the beginning of a streamed
// install; mirror it with a completion signal here so streaming
// failures/successes are distinguishable in telemetry without
// relying on the downstream `clean_install_*` metrics (which are
// specific to the clean-install engine step, not the streaming
// entry point as a whole).
let result = self.install(datastore, Operations::all(), false, Some(image));
if result.is_ok() {
tracing::info!(metric_name = "stream_image_success", value = true);
}
result
}

pub fn commit(
Expand Down