telemetry: enable Telemetry=OptIn by default for test/dev images - #781
Open
bfjelds (bfjelds) wants to merge 14 commits into
Open
Conversation
|
Azure Pipelines: 1 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
bfjelds (bfjelds)
changed the title
This was referenced Sep 7, 2026
bfjelds (bfjelds)
force-pushed
the
user/bfjelds/mjolnir/installation-servicing-id
branch
from
September 7, 2026 18:45
e8a0cd1 to
0568a97
Compare
bfjelds (bfjelds)
force-pushed
the
user/bfjelds/mjolnir/testimages-telemetry-optin
branch
from
September 7, 2026 18:46
1f21c48 to
3113a53
Compare
bfjelds (bfjelds)
force-pushed
the
user/bfjelds/mjolnir/installation-servicing-id
branch
from
September 7, 2026 18:50
0568a97 to
3d08428
Compare
bfjelds (bfjelds)
force-pushed
the
user/bfjelds/mjolnir/testimages-telemetry-optin
branch
from
September 7, 2026 18:51
3113a53 to
9c5f25f
Compare
bfjelds (bfjelds)
force-pushed
the
user/bfjelds/mjolnir/installation-servicing-id
branch
from
September 7, 2026 19:06
3d08428 to
83315ba
Compare
bfjelds (bfjelds)
force-pushed
the
user/bfjelds/mjolnir/testimages-telemetry-optin
branch
from
September 7, 2026 19:07
9c5f25f to
8481006
Compare
bfjelds (bfjelds)
force-pushed
the
user/bfjelds/mjolnir/installation-servicing-id
branch
from
September 7, 2026 21:16
83315ba to
45b5c66
Compare
bfjelds (bfjelds)
force-pushed
the
user/bfjelds/mjolnir/testimages-telemetry-optin
branch
from
September 7, 2026 21:17
8481006 to
fe8ca7b
Compare
bfjelds (bfjelds)
force-pushed
the
user/bfjelds/mjolnir/installation-servicing-id
branch
from
September 7, 2026 22:13
45b5c66 to
cd47c59
Compare
bfjelds (bfjelds)
force-pushed
the
user/bfjelds/mjolnir/testimages-telemetry-optin
branch
from
September 7, 2026 22:14
fe8ca7b to
dbaeaf5
Compare
bfjelds (bfjelds)
force-pushed
the
user/bfjelds/mjolnir/installation-servicing-id
branch
from
September 7, 2026 22:18
cd47c59 to
b5635ec
Compare
bfjelds (bfjelds)
force-pushed
the
user/bfjelds/mjolnir/testimages-telemetry-optin
branch
from
September 7, 2026 22:18
dbaeaf5 to
bb26845
Compare
bfjelds (bfjelds)
force-pushed
the
user/bfjelds/mjolnir/installation-servicing-id
branch
from
September 7, 2026 22:23
b5635ec to
8458fa1
Compare
bfjelds (bfjelds)
force-pushed
the
user/bfjelds/mjolnir/testimages-telemetry-optin
branch
from
September 7, 2026 22:24
bb26845 to
f2ed3e4
Compare
bfjelds (bfjelds)
force-pushed
the
user/bfjelds/mjolnir/installation-servicing-id
branch
from
September 7, 2026 22:37
8458fa1 to
8fa7b72
Compare
Adds a shared tests/images/common/trident.conf with Telemetry=OptIn and references it from every test/dev image definition, enabling Application Insights telemetry opt-in by default across test/dev images. Originally part of PR #774 (appinsights-telemetry); split out to its own PR, stacked on PR #779 (installation-servicing-id), since these image-definition changes are unrelated to the core telemetry plumbing and servicing-ID work in the earlier PRs in the stack.
bfjelds (bfjelds)
force-pushed
the
user/bfjelds/mjolnir/testimages-telemetry-optin
branch
from
September 7, 2026 22:38
f2ed3e4 to
da85729
Compare
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The manifests consistently reference the valid shared opt-in configuration at the expected agent configuration path.
Pull request overview
Adds a shared telemetry opt-in configuration to test and development images.
Changes:
- Adds
Telemetry=OptInto a sharedtrident.conf. - Installs the configuration across test, installer, container, VM, and verity images.
File summaries
| File | Description |
|---|---|
tests/images/common/trident.conf |
Defines telemetry opt-in. |
tests/images/trident-vm-testimage/base/updateimg-grub.yaml |
Installs shared configuration. |
tests/images/trident-vm-testimage/base/updateimg-grub-verity.yaml |
Installs shared configuration. |
tests/images/trident-vm-testimage/base/updateimg-grub-verity-azure.yaml |
Installs shared configuration. |
tests/images/trident-vm-testimage/base/baseimg-usr-verity.yaml |
Installs shared configuration. |
tests/images/trident-vm-testimage/base/baseimg-root-verity.yaml |
Installs shared configuration. |
tests/images/trident-vm-testimage/base/baseimg-grub.yaml |
Installs shared configuration. |
tests/images/trident-vm-testimage/base/baseimg-grub-verity.yaml |
Installs shared configuration. |
tests/images/trident-vm-testimage/base/baseimg-grub-verity-azure.yaml |
Installs shared configuration. |
tests/images/trident-verity-testimage/usr/host.yaml |
Installs shared configuration. |
tests/images/trident-verity-testimage/usr/container.yaml |
Installs shared configuration. |
tests/images/trident-verity-testimage/base/baseimg.yaml |
Installs shared configuration. |
tests/images/trident-verity-testimage/base/baseimg-container.yaml |
Installs shared configuration. |
tests/images/trident-testimage/base/baseimg.yaml |
Installs shared configuration. |
tests/images/trident-mos/iso.yaml |
Installs shared configuration. |
tests/images/trident-mos/containerhost-iso.yaml |
Installs shared configuration. |
tests/images/trident-installer/base/baseimg.yaml |
Installs shared configuration. |
tests/images/trident-installer/base/baseimg-split.yaml |
Installs shared configuration. |
tests/images/trident-installer/base/baseimg-direct-streaming.yaml |
Installs shared configuration. |
tests/images/trident-functest/base/baseimg.yaml |
Adds and installs the configuration. |
tests/images/trident-container-testimage/base/baseimg.yaml |
Installs shared configuration. |
tests/images/trident-container-installer/base/baseimg.yaml |
Installs shared configuration. |
tests/images/azurelinux-direct-streaming-testimage/base/baseimg.yaml |
Adds and installs the configuration. |
tests/images/azl-installer/installer-iso.yaml |
Installs shared configuration. |
Review details
- Files reviewed: 24/24 changed files
- Comments generated: 0
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
…tionalFiles content - Merge PR #779 (installation/servicing ID) tip forward - Inline shared tests/images/common/trident.conf into each referencing yaml via additionalFiles content: instead of source:, removing the now-unused shared file (23 image definitions updated)
…n-servicing-id' into user/bfjelds/mjolnir/testimages-telemetry-optin
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The inline configuration uses the supported image schema and matches Trident’s telemetry parser across all affected images.
Review details
- Files reviewed: 23/23 changed files
- Comments generated: 0 new
- Review effort level: Balanced
…n-servicing-id' into user/bfjelds/mjolnir/testimages-telemetry-optin
…n-servicing-id' into user/bfjelds/mjolnir/testimages-telemetry-optin
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The inline configuration is valid, consistently applied, and avoids the previously identified dependency-tracking issue.
Review details
- Files reviewed: 23/23 changed files
- Comments generated: 0 new
- Review effort level: Balanced
…n-servicing-id' into user/bfjelds/mjolnir/testimages-telemetry-optin
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
All affected image definitions consistently install the valid telemetry setting at the expected agent configuration path.
Review details
- Files reviewed: 23/23 changed files
- Comments generated: 0 new
- Review effort level: Balanced
…n-servicing-id' into user/bfjelds/mjolnir/testimages-telemetry-optin
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The inline configuration is valid, consistently applied, and avoids the previously identified shared-file dependency issue.
Review details
- Files reviewed: 23/23 changed files
- Comments generated: 0 new
- Review effort level: Balanced
…snapshot + rollback --check fixes)
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The inline configuration is valid, consistently applied, and avoids the previously identified shared-file dependency issue.
Review details
- Files reviewed: 23/23 changed files
- Comments generated: 0 new
- Review effort level: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enable telemetry for test pipelines by adding
trident.confwithTelemetry=OptInto test images.Related PRs in stack: