Repository navigation
Let capture correct an outdated memory in full - #51
Merged
Merged
Conversation
- Treat a memory the code contradicts as a capture candidate and rewrite every contradicted statement - Mark an obsolete memory SUPERSEDED for the audit to drop instead of deleting it - Keep the old body below the marker when the memories folder has no version control
- Put a correction branch first in Step 2 so a wrong memory is never treated as already captured - Run the checks on the rewritten text and Drives on the whole file, so a Check 1 failure has an outcome - Drop Pending and skip Refresh for an obsolete memory, and report corrections in the closing note
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
When a session finds that a memory it relied on is wrong, capture treats the fix like a new note folded into the old one, so the memory gets a patch around a wrong premise instead of a correction. Capture now rewrites every statement the code contradicts, up to the whole memory, and checks the result as a whole.
If nothing true remains, capture marks the memory superseded rather than deleting it, so the audit drops it with approval. Without version control on the memories folder, the old text stays below the marker, since it is the only copy.
Test plan
mcs sync, then work on code a memory describes wrongly and run continuous-learning → expect the contradicted statements rewritten in place, not a section appendedApplies to:and the file kept/memory-audit→ expect that memory proposed as a D1 drop