Skip to content

Require a ship signal before capture saves unmerged work - #52

Merged
bguidolim merged 1 commit into
bruno/capture-memory-correctionsfrom
bruno/capture-ship-signal
Oct 28, 2026
Merged

bguidolim merged 1 commit into
bruno/capture-memory-correctionsfrom
bruno/capture-ship-signal

Conversation

@bguidolim

Copy link
Copy Markdown
Collaborator

Why

Capture saved memories from PoCs and investigations whose branches never merge. Any ticket counted as proof the work was in flight, every branch carries one, and a decision about code that doesn't exist yet has nothing to grep, so neither check held anything back.

Now unmerged work is saved only with a PR the session created or the user named, or the user saying the work will ship. That applies to decisions about code the default branch doesn't have yet, too. Findings about code already on the default branch are saved as before. Anything held back is named in capture's closing note, so the user can supply the signal.

Stacked on #51; merge that first.

Test plan

  • mcs sync, then on a ticket branch with no PR settle a direction and run continuous-learning → expect a skip and the "say if this will ship" note
  • Say "this will ship" and run it again → expect a memory with a **Pending:** line
  • Find a cause in code that exists on the default branch → expect it saved as before

- Count only a PR or the user saying the work will ship as pending; a ticket alone no longer does
- Apply the same signal to decisions about code the default branch does not have yet
- Name skips caused by a missing ship signal in capture's one-line note
@bguidolim
bguidolim added this pull request to stack #53 October 28, 2026 23:26
@bguidolim
bguidolim merged commit 8128fba into main Oct 28, 2026
5 checks passed
@bguidolim
bguidolim deleted the bruno/capture-ship-signal branch October 28, 2026 23:38
bguidolim added a commit that referenced this pull request Oct 29, 2026
- Count a PR or ticket as pending again, since capture runs before a PR usually exists
- Drop the closing-note line for skips caused by a missing ship signal
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant